[issue34994] sysconfig returns the git commands for GITBRANCH, GITVERSION and GITTAG

2018-10-15 Thread Stéphane Wirtel
Stéphane Wirtel added the comment: yep, sure and now, after your explanations (you and victor) I just closed my PR, but to be honnest with your, I was really surprised when I have seen the git commands in the GIT* variables. Thanks for your review and your time. -- resolution: not a

[issue34994] sysconfig returns the git commands for GITBRANCH, GITVERSION and GITTAG

2018-10-15 Thread Stéphane Wirtel
Change by Stéphane Wirtel : -- stage: -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue34994] sysconfig returns the git commands for GITBRANCH, GITVERSION and GITTAG

2018-10-15 Thread Ned Deily
Ned Deily added the comment: Victor is correct. Those GIT* variable are there to communicate between ./configure and the Makefile; they are *not* intended to have actual values for change ids or branch names. Many variables in the Makefile are not intended to be used outside of the build

[issue34994] sysconfig returns the git commands for GITBRANCH, GITVERSION and GITTAG

2018-10-15 Thread STINNER Victor
STINNER Victor added the comment: It seems like you misunderstood the purpose of these variables. They are only used to build getbuildinfo which is used to fill sys._git. Depending on the platform and git version, there are different ways to get the version, branch and tag. These variables

[issue34994] sysconfig returns the git commands for GITBRANCH, GITVERSION and GITTAG

2018-10-15 Thread Stéphane Wirtel
Stéphane Wirtel added the comment: sure, but you can also get these info from sysconfig. and for me, there is a problem with sysconfig. two solutions, remove GIT* from sysconfig or fix sysconfig with the right values. -- stage: patch review ->

[issue34994] sysconfig returns the git commands for GITBRANCH, GITVERSION and GITTAG

2018-10-15 Thread STINNER Victor
STINNER Victor added the comment: Git informations are available as: >>> sys._git ('CPython', 'heads/fakerepr', 'd353239f83') >>> sys.version '3.8.0a0 (heads/fakerepr:d353239f83, Oct 15 2018, 13:20:43) \n[GCC 8.1.1 20180712 (Red Hat 8.1.1-5)]' -- nosy: +vstinner

[issue34994] sysconfig returns the git commands for GITBRANCH, GITVERSION and GITTAG

2018-10-15 Thread Stéphane Wirtel
Change by Stéphane Wirtel : -- keywords: +patch pull_requests: +9257 stage: -> patch review ___ Python tracker ___ ___

[issue34994] sysconfig returns the git commands for GITBRANCH, GITVERSION and GITTAG

2018-10-15 Thread Stéphane Wirtel
New submission from Stéphane Wirtel : > ./configure --prefix=$PWD-build --with-pydebug --quiet > make -j 4 -s > git --git-dir ./.git rev-parse --short HEAD ee171a26c1 > ./python -m sysconfig | grep GIT GITBRANCH = "git --git-dir ./.git name-rev --name-only HEAD" GITTAG = "git --git-dir ./.git