[issue35027] distutils.core.setup does not raise TypeError when if classifiers, keywords and platforms fields are not specified as a list

Karthikeyan Singaravelan added the comment: Since the two PRs are merged as part of triaging I am closing this as fixed. Feel free to reopen this if needed. Thanks Tilman for the PR :) -- resolution: -> fixed stage: patch review -> resolved status: open -> closed

[issue35027] distutils.core.setup does not raise TypeError when if classifiers, keywords and platforms fields are not specified as a list

miss-islington added the comment: New changeset f2679afda06d1eeaf34852e49bbcf4fb39736d19 by Miss Islington (bot) in branch '3.7': bpo-35027, distutils doc: Correct note on setup.py change in Python 3.7 (GH-10032)

[issue35027] distutils.core.setup does not raise TypeError when if classifiers, keywords and platforms fields are not specified as a list

STINNER Victor added the comment: New changeset e80e77a484983ffb527ef22d336ff9500589dce3 by Victor Stinner (TilmanK) in branch 'master': bpo-35027, distutils doc: Correct note on setup.py change in Python 3.7 (GH-10032)

[issue35027] distutils.core.setup does not raise TypeError when if classifiers, keywords and platforms fields are not specified as a list

Change by miss-islington : -- pull_requests: +9416 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35027] distutils.core.setup does not raise TypeError when if classifiers, keywords and platforms fields are not specified as a list

Change by Berker Peksag : -- nosy: +berker.peksag ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35027] distutils.core.setup does not raise TypeError when if classifiers, keywords and platforms fields are not specified as a list

Tilman Krummeck added the comment: I've submitted the PR just now: https://github.com/python/cpython/pull/10032. The CLA is signed but most probably not processed yet. -- ___ Python tracker

[issue35027] distutils.core.setup does not raise TypeError when if classifiers, keywords and platforms fields are not specified as a list

Change by Tilman Krummeck : -- keywords: +patch pull_requests: +9370 stage: -> patch review ___ Python tracker ___ ___

[issue35027] distutils.core.setup does not raise TypeError when if classifiers, keywords and platforms fields are not specified as a list

Karthikeyan Singaravelan added the comment: No problem, since this is a doc fix you can directly fork and edit on GitHub web UI. This requires CLA to be signed but no NEWS entry so it can be done from web UI and you can take wording from the commit 8837dd092fe5ad5184889104e8036811ed839f98.

[issue35027] distutils.core.setup does not raise TypeError when if classifiers, keywords and platforms fields are not specified as a list

Tilman Krummeck added the comment: I guess it's now or never. Give me some time to check the developer's guide and I'll submit a doc fix for this. -- ___ Python tracker ___

[issue35027] distutils.core.setup does not raise TypeError when if classifiers, keywords and platforms fields are not specified as a list

Karthikeyan Singaravelan added the comment: Thanks for the report. It was made as a TypeError in https://bugs.python.org/issue19610#msg306853 in the commit to check for list explicitly [0] . Then since it broke a lot of packages as seen in the discussion and now it accepts string and list

[issue35027] distutils.core.setup does not raise TypeError when if classifiers, keywords and platforms fields are not specified as a list

New submission from Tilman Krummeck : The python documentation states at this point: "Changed in version 3.7: setup now raises a TypeError if classifiers, keywords and platforms fields are not specified as a list." https://docs.python.org/3.7/distutils/setupscript.html#additional-meta-data