[issue35030] Python 2.7 OrderedDict creates circular references

tzickel added the comment: Sorry ignore it. Closed the PR as well. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue35030] Python 2.7 OrderedDict creates circular references

tzickel added the comment: Is this commit interesting ? It has less lines, more simple and makes no cycles to collect, and it seems in my limited benchmark faster than the current implementation. https://github.com/tzickel/cpython/commit/7e8b70b67cd1b817182be4dd2285bd136e6b156d --

[issue35030] Python 2.7 OrderedDict creates circular references

STINNER Victor added the comment: rhettinger: "status: open -> closed" I guess that https://github.com/python/cpython/pull/10002 should be closed as well? -- ___ Python tracker

[issue35030] Python 2.7 OrderedDict creates circular references

Change by Raymond Hettinger : -- resolution: -> not a bug stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue35030] Python 2.7 OrderedDict creates circular references

Change by STINNER Victor : -- nosy: +eric.snow, vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35030] Python 2.7 OrderedDict creates circular references

Raymond Hettinger added the comment: > I see, so basically this would be a problem only if the root > object had a __del__ method and then the GC wouldn't reclaim it ? Yes. That's exactly it. -- ___ Python tracker

[issue35030] Python 2.7 OrderedDict creates circular references

tzickel added the comment: I see, so basically this would be a problem only if the root object had a __del__ method and then the GC wouldn't reclaim it ? -- ___ Python tracker

[issue35030] Python 2.7 OrderedDict creates circular references

tzickel added the comment: You can see the testing code here: https://github.com/numpy/numpy/blob/eb40e161e2e593762da9c77858343e3720351ce7/n umpy/testing/_private/utils.py#L2199 it calls gc.collect in the end and only throws this error if it returns a non zero return value from it (after

[issue35030] Python 2.7 OrderedDict creates circular references

Raymond Hettinger added the comment: I'm unclear whether you're reporting a true leak (one that can't be cleaned-up by a call to gc.collect()) or just a garden variety circular reference that will eventually free, just not as quickly as it would with straight reference counting applied when

[issue35030] Python 2.7 OrderedDict creates circular references

Karthikeyan Singaravelan added the comment: Thanks for the report. I have converted the numpy code as a python helper and I am not sure if such a helper exists in the current test suite. Attaching the file that might help as a simple reproducer. # On master no error ➜ cpython git:(master)

[issue35030] Python 2.7 OrderedDict creates circular references

Change by tzickel : -- keywords: +patch pull_requests: +9344 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list

[issue35030] Python 2.7 OrderedDict creates circular references

Change by Serhiy Storchaka : -- title: Python 2.7 OrderedDict leaks memory -> Python 2.7 OrderedDict creates circular references ___ Python tracker ___