[issue35047] Better error messages in unittest.mock

STINNER Victor added the comment: New changeset 001d63cefaa9d84d6d59aa9db8bac66040c8f0ee by Victor Stinner (Petter Strandmark) in branch 'master': bpo-35047: Update whatsnew/3.8 for better mock error message (GH-13746)

[issue35047] Better error messages in unittest.mock

Change by Petter S : -- pull_requests: +13628 pull_request: https://github.com/python/cpython/pull/13746 ___ Python tracker ___ ___

[issue35047] Better error messages in unittest.mock

STINNER Victor added the comment: Thanks Petter Strandmark! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue35047] Better error messages in unittest.mock

STINNER Victor added the comment: New changeset 47d94241a383e2b8a2c40e81d12d40d5947fb170 by Victor Stinner (Petter Strandmark) in branch 'master': bpo-35047, unittest.mock: Better error messages on assert_called_xxx failures (GH-10090)

[issue35047] Better error messages in unittest.mock

Change by Serhiy Storchaka : -- nosy: +michael.foord ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35047] Better error messages in unittest.mock

Change by Petter S : -- keywords: +patch pull_requests: +9420 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list

[issue35047] Better error messages in unittest.mock

Emmanuel Arias added the comment: I think that is a good change. Maybe you can apply the change on 3.6, 3.7 and 3.8 -- ___ Python tracker ___

[issue35047] Better error messages in unittest.mock

Petter S added the comment: (The example above should have been "m.assert_has_calls([mock.call(3)])" but it does not affect my point.) -- ___ Python tracker ___

[issue35047] Better error messages in unittest.mock

Petter S added the comment: Sure, consider the following code: from unittest import mock m = mock.Mock() m(1, 3) m("Test", data=[42]) When I call m.assert_not_called() I get the following error message: AssertionError: Expected 'mock' to not have been called. Called 2 times. This is

[issue35047] Better error messages in unittest.mock

Emmanuel Arias added the comment: It seems to be a good idea. If you attach a sample, it would be great. -- nosy: +eamanu ___ Python tracker ___

[issue35047] Better error messages in unittest.mock

Change by Serhiy Storchaka : -- title: Better error messages un unittest.mock -> Better error messages in unittest.mock ___ Python tracker ___

[issue35047] Better error messages un unittest.mock

Change by Karthikeyan Singaravelan : -- nosy: +xtreak ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35047] Better error messages un unittest.mock

New submission from Petter S : When developing unit tests with `unittest.mock`, it is common to see error messages like this: AssertionError: Expected 'info' to not have been called. Called 3 times. It would be really helpful if those 3 calls were listed in the assertion error. I am