[issue35081] Rename Include/internals/ to Include/pycore/

STINNER Victor added the comment: Copy of my comment on PR 10271: https://github.com/python/cpython/pull/10271#issuecomment-434897408 I tried to enforce to require Py_BUILD_CORE in pycore_accu.h to be defined using: #ifndef Py_BUILD_CORE # error "Py_BUILD_CORE must be defined to include

[issue35081] Rename Include/internals/ to Include/pycore/

STINNER Victor added the comment: New changeset e281f7d80ce2584a7e6a36acffb5a9cd796a0fe2 by Victor Stinner in branch 'master': bpo-35081: Move accu.h to Include/internal/pycore_accu.h (GH-10271) https://github.com/python/cpython/commit/e281f7d80ce2584a7e6a36acffb5a9cd796a0fe2 --

[issue35081] Rename Include/internals/ to Include/pycore/

Change by STINNER Victor : -- pull_requests: +9583 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35081] Rename Include/internals/ to Include/pycore/

Change by STINNER Victor : -- pull_requests: +9582 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35081] Rename Include/internals/ to Include/pycore/

STINNER Victor added the comment: New changeset 50b48572d9a90c5bb36e2bef6179548ea927a35a by Victor Stinner in branch 'master': bpo-35081: Add _PyThreadState_GET() internal macro (GH-10266) https://github.com/python/cpython/commit/50b48572d9a90c5bb36e2bef6179548ea927a35a --

[issue35081] Rename Include/internals/ to Include/pycore/

STINNER Victor added the comment: New changeset 27e2d1f21975dfb8c0ddcb192fa0f45a51b7977e by Victor Stinner in branch 'master': bpo-35081: Add pycore_ prefix to internal header files (GH-10263) https://github.com/python/cpython/commit/27e2d1f21975dfb8c0ddcb192fa0f45a51b7977e --

[issue35081] Rename Include/internals/ to Include/pycore/

Change by Eric Snow : -- nosy: +eric.snow ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35081] Rename Include/internals/ to Include/pycore/

Change by STINNER Victor : -- pull_requests: +9577 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35081] Rename Include/internals/ to Include/pycore/

STINNER Victor added the comment: > Include/internal/pystate.h uses #include "pystate.h" to include > Include/pystate.h, but it tries to include itself > (Include/internal/pystate.h) which does nothing because of "#ifndef > Py_INTERNAL_PYSTATE_H #define Py_INTERNAL_PYSTATE_H ... #endif". I

[issue35081] Rename Include/internals/ to Include/pycore/

Change by STINNER Victor : -- pull_requests: +9574 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35081] Rename Include/internals/ to Include/pycore/

STINNER Victor added the comment: New changeset 2be00d987d37682a55db67c298e82c405d01b868 by Victor Stinner in branch 'master': bpo-35081: Move Py_BUILD_CORE code to internal/mem.h (GH-10249) https://github.com/python/cpython/commit/2be00d987d37682a55db67c298e82c405d01b868 --

[issue35081] Rename Include/internals/ to Include/pycore/

STINNER Victor added the comment: Include/internal/pystate.h uses #include "pystate.h" to include Include/pystate.h, but it tries to include itself (Include/internal/pystate.h) which does nothing because of "#ifndef Py_INTERNAL_PYSTATE_H #define Py_INTERNAL_PYSTATE_H ... #endif". Remove

[issue35081] Rename Include/internals/ to Include/pycore/

Change by STINNER Victor : -- pull_requests: +9563 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35081] Rename Include/internals/ to Include/pycore/

STINNER Victor added the comment: My changes move Py_BUILD_CORE to Include/internal/. I'm not sure of the effect on the backward compatibility. Since Python 3.7, many "Py_BUILD_CORE" functions rely on Include/internal/, like PyThreadState_GET() which uses _PyRuntime.gilstate.tstate_current.

[issue35081] Rename Include/internals/ to Include/pycore/

STINNER Victor added the comment: Serhiy Storchaka asked: "Would not be better to move files with the content fully surrounded by #ifdef Py_BUILD_CORE out of the Include/ directory?" See his comment and my answer in the PR 10239:

[issue35081] Rename Include/internals/ to Include/pycore/

STINNER Victor added the comment: New changeset 31368a4f0e531c19affe2a1becd25fc316bc7501 by Victor Stinner in branch 'master': bpo-35081: Move Include/pyatomic.c to Include/internal/ (GH-10239) https://github.com/python/cpython/commit/31368a4f0e531c19affe2a1becd25fc316bc7501 --

[issue35081] Rename Include/internals/ to Include/pycore/

STINNER Victor added the comment: New changeset 9204fb8623896cc5f68ae350784ee25e8a7b2184 by Victor Stinner in branch 'master': bpo-35081: Cleanup pystate.c and pystate.h (GH-10240) https://github.com/python/cpython/commit/9204fb8623896cc5f68ae350784ee25e8a7b2184 --

[issue35081] Rename Include/internals/ to Include/pycore/

Change by STINNER Victor : -- pull_requests: +9553 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35081] Rename Include/internals/ to Include/pycore/

Change by STINNER Victor : -- pull_requests: +9552 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35081] Rename Include/internals/ to Include/pycore/

Change by STINNER Victor : -- pull_requests: +9551 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35081] Rename Include/internals/ to Include/pycore/

STINNER Victor added the comment: Discussion on python-dev: https://mail.python.org/pipermail/python-dev/2018-October/155587.html -- ___ Python tracker ___

[issue35081] Rename Include/internals/ to Include/pycore/

STINNER Victor added the comment: See also bpo-35059 which converts C macros to static inline functions. -- ___ Python tracker ___

[issue35081] Rename Include/internals/ to Include/pycore/

STINNER Victor added the comment: I decided to work on this issue while trying to convert the _PyObject_GC_TRACK() macro into a "static inline" function. Currently, the macro uses _PyGC_generation0 which is defined earlier by "extern PyGC_Head *_PyGC_generation0;". Problem:

[issue35081] Rename Include/internals/ to Include/pycore/

Change by STINNER Victor : -- keywords: +patch pull_requests: +9470 stage: -> patch review ___ Python tracker ___ ___

[issue35081] Rename Include/internals/ to Include/pycore/

New submission from STINNER Victor : Currently, #include "pymem.h" may include Include/pymem.h or Include/internal/pymem.h depending where is the C file (.c) and if Include/internal/ is in the header search path or not. I propose to: * Rename Include/internal/ to Include/pycore/ * In this