[issue35086] tkinter docs: errors in A Simple Hello World Program

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.6 ___ Python tracker ___

[issue35086] tkinter docs: errors in A Simple Hello World Program

miss-islington added the comment: New changeset c843a47007293d8361d0bfd45bfd7169afaa601c by Miss Islington (bot) in branch '3.6': bpo-35086: Fix tkinter example "A Simple Hello World Program". (GH-10160) https://github.com/python/cpython/commit/c843a47007293d8361d0bfd45bfd7169afaa601c

[issue35086] tkinter docs: errors in A Simple Hello World Program

miss-islington added the comment: New changeset f51ef51db686938486bff453e791a3093a1df108 by Miss Islington (bot) in branch '3.7': bpo-35086: Fix tkinter example "A Simple Hello World Program". (GH-10160) https://github.com/python/cpython/commit/f51ef51db686938486bff453e791a3093a1df108

[issue35086] tkinter docs: errors in A Simple Hello World Program

Change by miss-islington : -- pull_requests: +9555 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35086] tkinter docs: errors in A Simple Hello World Program

Change by miss-islington : -- pull_requests: +9554 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35086] tkinter docs: errors in A Simple Hello World Program

Serhiy Storchaka added the comment: New changeset a80af770870937271865b5e2b05a2cfe40b024b6 by Serhiy Storchaka (Daniel Lovell) in branch 'master': bpo-35086: Fix tkinter example "A Simple Hello World Program". (GH-10160)

[issue35086] tkinter docs: errors in A Simple Hello World Program

Daniel Lovell added the comment: Thanks for the reply xtreak. I agree that changing the example to include main() isn't necessary - I unintentionally included that from my example of the case where the current version isn't functional. In the PR I submitted on Github

[issue35086] tkinter docs: errors in A Simple Hello World Program

Karthikeyan Singaravelan added the comment: Thanks for the report. So the current example in the docs works fine since root is in global namespace. But this seems to be a sensible change to use self.master which references root instead of relying on root to be global though I don't know we

[issue35086] tkinter docs: errors in A Simple Hello World Program

Change by Daniel Lovell : -- keywords: +patch pull_requests: +9484 stage: -> patch review ___ Python tracker ___ ___

[issue35086] tkinter docs: errors in A Simple Hello World Program

New submission from Daniel Lovell : In the documentation for tkinter, "A Simple Hello World Program" Application class does not hold onto the master Tk() instance as a class attribute. This is a good practice, and newcomers to tkinter would likely have trouble closing the window without this