[issue35218] decompressing and then re-compressing zipfiles with Python 3 zipfile loses flag_bits

2019-03-12 Thread keeely
keeely added the comment: You can take out the test. It wasn't there before so who's going to care? -- ___ Python tracker ___ ___

[issue35218] decompressing and then re-compressing zipfiles with Python 3 zipfile loses flag_bits

2019-03-12 Thread STINNER Victor
STINNER Victor added the comment: > I will not fill in your agreement form, and no I will not provide my reasons, > but you don't need it, it's a one-line fix. Ok. It's up to you, but in that case, we cannot merge your change. Contributors have to sign it. Your test is larger than a single

[issue35218] decompressing and then re-compressing zipfiles with Python 3 zipfile loses flag_bits

2019-03-12 Thread keeely
keeely added the comment: Can you please get on and fix this if you're going to deprecate Python 2.0. It's unkind on your users to deprecate the old version before you've fixed basic regressions like this in the new one. Just to be clear, I am attaching the code that reproduces this

[issue35218] decompressing and then re-compressing zipfiles with Python 3 zipfile loses flag_bits

2019-01-07 Thread STINNER Victor
STINNER Victor added the comment: Hi, > I'm unable to fill in your contributor agreement form Is there a specific reason why you cannot fill it? If you cannot cannot fill it, can someone else convert your patch into a PR? -- nosy: +vstinner ___

[issue35218] decompressing and then re-compressing zipfiles with Python 3 zipfile loses flag_bits

2019-01-03 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue35218] decompressing and then re-compressing zipfiles with Python 3 zipfile loses flag_bits

2019-01-03 Thread keeely
keeely added the comment: Please note: I'm unable to fill in your contributor agreement form, so please consider the patch an illustrative example. In any case, the fix is pretty-much a one-liner, so shouldn't be a big deal to 're-write'. I'm disappointed that this has been largely

[issue35218] decompressing and then re-compressing zipfiles with Python 3 zipfile loses flag_bits

2018-11-13 Thread keeely
Change by keeely : -- keywords: +patch Added file: https://bugs.python.org/file47930/zipfile_flags.patch ___ Python tracker ___ ___

[issue35218] decompressing and then re-compressing zipfiles with Python 3 zipfile loses flag_bits

2018-11-12 Thread keeely
Change by keeely : -- title: Impossible to round-trip decompress -> compress zipfiles with Python 3 due to losing flag_bits -> decompressing and then re-compressing zipfiles with Python 3 zipfile loses flag_bits ___ Python tracker