[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

Ned Deily added the comment: Thanks for the additional PR. Accepted for post-3.6.9 (PR 14576, commit a6d97e200863e7e5fc60bbc8f121b86a2098ef2d - message AWOL?) -- ___ Python tracker

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

Change by Ned Deily : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___ ___

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

Anthony Sottile added the comment: yes, as was the original PR -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

Steve Dower added the comment: Your PR is against 3.6 - is that intentional? -- resolution: fixed -> stage: resolved -> status: closed -> open ___ Python tracker ___

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

Change by Anthony Sottile : -- pull_requests: +14395 pull_request: https://github.com/python/cpython/pull/14576 ___ Python tracker ___

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

Anthony Sottile added the comment: This has regressed again -- I'll make another patch -- ___ Python tracker ___ ___

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

Julien Palard added the comment: New changeset 869652b426bb34a30ce7b39f0a0ac242ed5b1016 by Julien Palard in branch '2.7': [2.7] bpo-35605: Fix documentation build for sphinx<1.6 (GH-12413) https://github.com/python/cpython/commit/869652b426bb34a30ce7b39f0a0ac242ed5b1016 --

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

Change by Julien Palard : -- pull_requests: +12367 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

Ned Deily added the comment: I agree that this can go into 3.6. Thanks, everyone! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

Ned Deily added the comment: New changeset 9bacdce451618a5f0bf62cb1b6f966ebde0492c6 by Ned Deily (Anthony Sottile) in branch '3.6': [3.6] bpo-35605: Fix documentation build for sphinx<1.6 (GH-11368) https://github.com/python/cpython/commit/9bacdce451618a5f0bf62cb1b6f966ebde0492c6

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

Anthony Sottile added the comment: I also had to update the patch for sphinx.util.status_iterator which was also introduced in sphinx 1.6 -- ___ Python tracker ___

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

Change by Anthony Sottile : -- keywords: +patch, patch, patch pull_requests: +10704, 10705, 10706 stage: -> patch review ___ Python tracker ___

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

Change by Anthony Sottile : -- keywords: +patch, patch pull_requests: +10704, 10705 stage: -> patch review ___ Python tracker ___

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

Change by Anthony Sottile : -- keywords: +patch pull_requests: +10704 stage: -> patch review ___ Python tracker ___ ___

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

Julien Palard added the comment: The patch (try/except) to make https://github.com/python/cpython/pull/11251/files work with what Doc/conf.py says about minimum sphinx version (1.2) is OK for me. No need to apply it on 3.7 which needs_sphinx 1.6.6 according to its Doc/conf.py. --

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

Ned Deily added the comment: Julien (@mdk) is the doc builds expert. -- assignee: docs@python -> mdk ___ Python tracker ___ ___

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

Anthony Sottile added the comment: I assume that means I should only target 3.6 -- does the patch look like the right approach? I can make a PR -- ___ Python tracker ___

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

Steve Dower added the comment: I think we're okay to increase the minimum version on the active branches. -- ___ Python tracker ___

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

Anthony Sottile added the comment: If I add a patch which is essentially: try: # sphinx>=1.6 from sphinx.util.logging import getLogger except ImportError: # sphinx<1.6 from logging import getLogger will that be fine? and should I open that against 3.7 to be backported or just

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

Ned Deily added the comment: I would view this as a build regression in 3.6.8 so I would accept a fix for the 3.6 branch. -- ___ Python tracker ___

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

Steve Dower added the comment: We need Ned's approval to fix anything in 3.6 now. Typically we do consider build issues, and this one is fairly innocent (the affected code should only be used on Windows, but the import may trigger elsewhere). I'd be happy to take a patch to use logging when

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

Change by Karthikeyan Singaravelan : -- nosy: +mdk, steve.dower ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

Anthony Sottile added the comment: oops, pressed the button too quickly, meant to mention that sphinx 1.6 was released 2017-05 -- ___ Python tracker ___

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

New submission from Anthony Sottile : Noticed this while packaging 3.6.8 for deadsnakes (ubuntu ppa) This patch: https://github.com/python/cpython/pull/11251 Requires a version of sphinx where `sphinx.util.logging.getLogger` is available. It appears that the first version which that was