[issue35647] Cookie path check returns incorrect results

STINNER Victor added the comment: Well done Karthikeyan Singaravelan! I planned to review your 2.7 change, but I didn't manage to find time for that. So thanks Serhiy for merging it! -- ___ Python tracker

[issue35647] Cookie path check returns incorrect results

Karthikeyan Singaravelan added the comment: Closing this as resolved since the fix was merged to all branches. Thank you all. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue35647] Cookie path check returns incorrect results

Serhiy Storchaka added the comment: New changeset ee15aa2b8501718cb77e339381f72409a416f801 by Serhiy Storchaka (Xtreak) in branch '2.7': [2.7] bpo-35647: Fix path check in cookiejar. (GH-11436) (GH-13427) https://github.com/python/cpython/commit/ee15aa2b8501718cb77e339381f72409a416f801

[issue35647] Cookie path check returns incorrect results

Karthikeyan Singaravelan added the comment: > Python 2.7 is still affected, right? Is there someone interested to backport > the fix? PR 13427 fixes the issue in 2.7 :) -- ___ Python tracker

[issue35647] Cookie path check returns incorrect results

STINNER Victor added the comment: Python 2.7 is still affected, right? Is there someone interested to backport the fix? -- nosy: +vstinner ___ Python tracker ___

[issue35647] Cookie path check returns incorrect results

Change by Karthikeyan Singaravelan : -- pull_requests: +13337 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35647] Cookie path check returns incorrect results

Change by Ned Deily : -- Removed message: https://bugs.python.org/msg342091 ___ Python tracker ___ ___ Python-bugs-list mailing

[issue35647] Cookie path check returns incorrect results

Ned Deily added the comment: New changeset e260f092cd0d8975c777e73ca6fb549d59b5d452 by larryhastings (Xtreak) in branch '3.4': bpo-35647: Fix path check in cookiejar (#11436) (#12278) https://github.com/python/cpython/commit/e260f092cd0d8975c777e73ca6fb549d59b5d452 --

[issue35647] Cookie path check returns incorrect results

Larry Hastings added the comment: New changeset 382981b25092b5e9285f1e4894142af1e8f2ca86 by larryhastings (Xtreak) in branch '3.5': bpo-35647: Fix path check in cookiejar (#11436) (#12277) https://github.com/python/cpython/commit/382981b25092b5e9285f1e4894142af1e8f2ca86 --

[issue35647] Cookie path check returns incorrect results

Larry Hastings added the comment: New changeset e260f092cd0d8975c777e73ca6fb549d59b5d452 by larryhastings (Xtreak) in branch '3.4': bpo-35647: Fix path check in cookiejar (#11436) (#12278) https://github.com/python/cpython/commit/e260f092cd0d8975c777e73ca6fb549d59b5d452 --

[issue35647] Cookie path check returns incorrect results

Senthil Kumaran added the comment: Got it, Larry. I wanted to track it and make sure you don't miss it. Looks like we have the PR from @xtreak for 3.4 and 3.5 branches. Thank you! -- ___ Python tracker

[issue35647] Cookie path check returns incorrect results

Larry Hastings added the comment: You should not assign bugs to the RM who will merge the PR. -- assignee: larry -> ___ Python tracker ___

[issue35647] Cookie path check returns incorrect results

Change by Senthil Kumaran : -- assignee: -> larry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35647] Cookie path check returns incorrect results

Ned Deily added the comment: New changeset 5565b1db6f37f244890369e0d68a3e906aca28b9 by Ned Deily (Miss Islington (bot)) in branch '3.6': bpo-35647: Fix path check in cookiejar (GH-11436) (GH-12268) https://github.com/python/cpython/commit/5565b1db6f37f244890369e0d68a3e906aca28b9 --

[issue35647] Cookie path check returns incorrect results

Change by Karthikeyan Singaravelan : -- versions: +Python 3.4 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35647] Cookie path check returns incorrect results

Change by Karthikeyan Singaravelan : -- pull_requests: +12258 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35647] Cookie path check returns incorrect results

Change by Karthikeyan Singaravelan : -- pull_requests: +12257 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35647] Cookie path check returns incorrect results

Larry Hastings added the comment: Yes, I'd like backports to 3.5 and 3.4. Note that I tag and release 3.4.10 final this weekend, which will be the final release ever of 3.4, so if it can't be ready for merging before then, you might as well skip the 3.4 PR. --

[issue35647] Cookie path check returns incorrect results

Karthikeyan Singaravelan added the comment: The backport to 3.5 might require manual work since I used f-strings for tests that are not present in 3.5 and below. 2.7 is also affected and as I backported the tests and cookie set with path=/foo is sent on request to /foobad/foo . The module

[issue35647] Cookie path check returns incorrect results

miss-islington added the comment: New changeset 97c7d78fda49e03fc773c171ce0c736d02bb73f5 by Miss Islington (bot) in branch '3.7': bpo-35647: Fix path check in cookiejar (GH-11436) https://github.com/python/cpython/commit/97c7d78fda49e03fc773c171ce0c736d02bb73f5 -- nosy:

[issue35647] Cookie path check returns incorrect results

Change by Senthil Kumaran : -- versions: +Python 3.5, Python 3.6 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue35647] Cookie path check returns incorrect results

Change by miss-islington : -- pull_requests: +12252 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35647] Cookie path check returns incorrect results

Senthil Kumaran added the comment: New changeset 0e1f1f01058bd4a9b98cfe443214adecc019a38c by Senthil Kumaran (Xtreak) in branch 'master': bpo-35647: Fix path check in cookiejar (#11436) https://github.com/python/cpython/commit/0e1f1f01058bd4a9b98cfe443214adecc019a38c --

[issue35647] Cookie path check returns incorrect results

Change by miss-islington : -- pull_requests: +12251 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35647] Cookie path check returns incorrect results

Change by Karthikeyan Singaravelan : -- keywords: +patch, patch, patch pull_requests: +10868, 10869, 10870 stage: -> patch review ___ Python tracker ___

[issue35647] Cookie path check returns incorrect results

Change by Karthikeyan Singaravelan : -- keywords: +patch, patch pull_requests: +10868, 10869 stage: -> patch review ___ Python tracker ___

[issue35647] Cookie path check returns incorrect results

Change by Karthikeyan Singaravelan : -- keywords: +patch pull_requests: +10868 stage: -> patch review ___ Python tracker ___ ___

[issue35647] Cookie path check returns incorrect results

New submission from Karthikeyan Singaravelan : I came across the issue during https://bugs.python.org/issue35121#msg332583 . I think this can be dealt as a separate issue not blocking the original report. I am classifying it as security but can be reclassified as a bug fix given the section