[issue35696] remove unnecessary operation in long_compare()

Change by hongweipeng : -- nosy: +hongweipeng ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35696] remove unnecessary operation in long_compare()

Ma Lin added the comment: > I'd fix them, but I'm not sure if we are going to restore CHECK_SMALL_INT() > ¯\_(ツ)_/¯ I suggest we slow down, carefully sort out the recent commits for longobject.c: https://bugs.python.org/issue37812#msg352837 Make the code has consistent style, better

[issue35696] remove unnecessary operation in long_compare()

Sergey Fedoseev added the comment: These warnings are caused by https://github.com/python/cpython/commit/c6734ee7c55add5fdc2c821729ed5f67e237a096. I'd fix them, but I'm not sure if we are going to restore CHECK_SMALL_INT() ¯\_(ツ)_/¯ -- nosy: +sir-sigurd

[issue35696] remove unnecessary operation in long_compare()

STINNER Victor added the comment: I reopen the issue. The win32 job of Azure Pipelines now logs a compiler warning: Objects\longobject.c(412,5): warning C4244: 'function': conversion from 'unsigned long' to 'sdigit', possible loss of data Objects\longobject.c(420,5): warning C4244:

[issue35696] remove unnecessary operation in long_compare()

Change by Inada Naoki : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.9 -Python 3.8 ___ Python tracker ___

[issue35696] remove unnecessary operation in long_compare()

Inada Naoki added the comment: New changeset 42acb7b8d29d078bc97b0cfd7c4911b2266b26b9 by Inada Naoki (HongWeipeng) in branch 'master': bpo-35696: Simplify long_compare() (GH-16146) https://github.com/python/cpython/commit/42acb7b8d29d078bc97b0cfd7c4911b2266b26b9 -- nosy:

[issue35696] remove unnecessary operation in long_compare()

Change by hongweipeng : -- pull_requests: +15756 pull_request: https://github.com/python/cpython/pull/16146 ___ Python tracker ___

[issue35696] remove unnecessary operation in long_compare()

Change by Ma Lin : -- keywords: +patch, patch, patch pull_requests: +10974, 10975, 10976 stage: -> patch review ___ Python tracker ___

[issue35696] remove unnecessary operation in long_compare()

Change by Ma Lin : -- keywords: +patch, patch pull_requests: +10974, 10975 stage: -> patch review ___ Python tracker ___ ___

[issue35696] remove unnecessary operation in long_compare()

Change by Ma Lin : -- keywords: +patch pull_requests: +10974 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list

[issue35696] remove unnecessary operation in long_compare()

New submission from Ma Lin : static int long_compare(PyLongObject *a, PyLongObject *b) { } This function in /Objects/longobject.c is used to compare two PyLongObject's value. We only need the sign, converting to -1 or +1 is not necessary. -- messages: 333293 nosy: Ma Lin