[issue35877] parenthesis is mandatory for named expressions in while statement

2019-02-01 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Thanks a lot Guido and Emily for guidance on this issue. Happy to see this for alpha release :) -- ___ Python tracker ___

[issue35877] parenthesis is mandatory for named expressions in while statement

2019-02-01 Thread Emily Morehouse
Change by Emily Morehouse : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue35877] parenthesis is mandatory for named expressions in while statement

2019-02-01 Thread Emily Morehouse
Emily Morehouse added the comment: New changeset ac19081c26eaa7de3e6aabeb789ddc2e7cdd5b24 by Emily Morehouse in branch 'master': bpo-35877: Add test for while loop named expression without parentheses (GH-11726)

[issue35877] parenthesis is mandatory for named expressions in while statement

2019-02-01 Thread Emily Morehouse
Emily Morehouse added the comment: Thanks, Karthikeyan! I added an additional test to make sure this gets coverage. I'll close out this issue once tests pass and I can merge that. -- ___ Python tracker

[issue35877] parenthesis is mandatory for named expressions in while statement

2019-02-01 Thread Emily Morehouse
Change by Emily Morehouse : -- pull_requests: +11608, 11609, 11610 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue35877] parenthesis is mandatory for named expressions in while statement

2019-02-01 Thread Emily Morehouse
Change by Emily Morehouse : -- pull_requests: +11608 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35877] parenthesis is mandatory for named expressions in while statement

2019-02-01 Thread Emily Morehouse
Change by Emily Morehouse : -- pull_requests: +11608, 11609 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35877] parenthesis is mandatory for named expressions in while statement

2019-02-01 Thread Emily Morehouse
Emily Morehouse added the comment: New changeset d4fceaafb8e3f8700d9ec6ab37a51e903392f74f by Emily Morehouse (Xtreak) in branch 'master': bpo-35877: Make parenthesis optional for named expression in while statement (GH-11724)

[issue35877] parenthesis is mandatory for named expressions in while statement

2019-02-01 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- keywords: +patch, patch, patch pull_requests: +11603, 11604, 11605 stage: needs patch -> patch review ___ Python tracker ___

[issue35877] parenthesis is mandatory for named expressions in while statement

2019-02-01 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- keywords: +patch, patch pull_requests: +11603, 11604 stage: needs patch -> patch review ___ Python tracker ___

[issue35877] parenthesis is mandatory for named expressions in while statement

2019-02-01 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- keywords: +patch pull_requests: +11603 stage: needs patch -> patch review ___ Python tracker ___

[issue35877] parenthesis is mandatory for named expressions in while statement

2019-02-01 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: > Thanks, Karthikeyan! Can you submit that as a PR? Sure, I will submit the patch with tests for the same. Thanks -- ___ Python tracker

[issue35877] parenthesis is mandatory for named expressions in while statement

2019-02-01 Thread Guido van Rossum
Guido van Rossum added the comment: Thanks, Karthikeyan! Can you submit that as a PR? -- ___ Python tracker ___ ___

[issue35877] parenthesis is mandatory for named expressions in while statement

2019-02-01 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: > Emily, I think this would be as simple as making a tiny change to > Grammar/Grammar and running make regen-grammar. Can you take care of that? Thanks, can confirm that this fixes the issue. I changed test to namedexpr_test for while statement in

[issue35877] parenthesis is mandatory for named expressions in while statement

2019-02-01 Thread Guido van Rossum
Guido van Rossum added the comment: Emily, I think this would be as simple as making a tiny change to Grammar/Grammar and running make regen-grammar. Can you take care of that? -- assignee: -> emilyemorehouse stage: -> needs patch ___ Python

[issue35877] parenthesis is mandatory for named expressions in while statement

2019-02-01 Thread Karthikeyan Singaravelan
New submission from Karthikeyan Singaravelan : I thought to open a separate report itself in order to keep the original issue not cluttered with questions since it could be used for other docs. Sorry for my report there. Original report as per msg334341 . It seems parens are mandatory while