[issue36019] test_urllib fail in s390x buildbots: http://www.example.com/

Nikita Sobolev added the comment: I can also reproduce it locally with: `./python.exe -m test -v test_urllib2 -m test_issue16464 -u network` I've opened a new issue for it: https://bugs.python.org/issue46648 -- ___ Python tracker

[issue36019] test_urllib fail in s390x buildbots: http://www.example.com/

Nikita Sobolev added the comment: `test.test_urllib2.MiscTests.test_issue16464` started to fail again: ``` == ERROR: test_issue16464 (test.test_urllib2.MiscTests)

[issue36019] test_urllib fail in s390x buildbots: http://www.example.com/

STINNER Victor added the comment: Stéphane Wirtel backported his fix to Python 2.7. I didn't see failures related to example.com on 3.7 and master branches, so I think that it's now time to close the issue. Thanks Stéphane! -- resolution: -> fixed stage: patch review -> resolved

[issue36019] test_urllib fail in s390x buildbots: http://www.example.com/

STINNER Victor added the comment: New changeset 84772e0ab49ee09acb44e30551aa5cfc1eafe5dc by Victor Stinner (Stéphane Wirtel) in branch '2.7': [2.7] bpo-36019: Use pythontest.net in urllib network tests (GH-11941) (GH-12177)

[issue36019] test_urllib fail in s390x buildbots: http://www.example.com/

Change by Stéphane Wirtel : -- pull_requests: +12172 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36019] test_urllib fail in s390x buildbots: http://www.example.com/

STINNER Victor added the comment: > For the backport, should I add support.TEST_HTTP_URL? Yes > Should I also fix these tests: Yes, all urllib and urllib2 tests which use http://www.example.com/ -- ___ Python tracker

[issue36019] test_urllib fail in s390x buildbots: http://www.example.com/

Stéphane Wirtel added the comment: Victor, Should I also fix these tests: test_urllibnet.py::urlretrieveNetworkTests.test_specified_path test_urllibnet.py::urlretrieveNetworkTests.test_header test_urllibnet.py::urlopenNetworkTests.test_fileno ? --

[issue36019] test_urllib fail in s390x buildbots: http://www.example.com/

Stéphane Wirtel added the comment: Hi Victor, For the backport, should I add support.TEST_HTTP_URL? -- ___ Python tracker ___ ___

[issue36019] test_urllib fail in s390x buildbots: http://www.example.com/

Stéphane Wirtel added the comment: sure, I will do the backport tomorrow. thanks for the notif -- ___ Python tracker ___ ___

[issue36019] test_urllib fail in s390x buildbots: http://www.example.com/

STINNER Victor added the comment: Stéphane: Python 2.7 is also affected by the issue. Would you be interested in backport the fix to Lib/test/test_urllibnet.py? (in master, it's Lib/test/test_urllib2net.py). https://buildbot.python.org/all/#/builders/68/builds/238 Re-running failed tests

[issue36019] test_urllib fail in s390x buildbots: http://www.example.com/

miss-islington added the comment: New changeset 6163210089148ad31c270695f7273fc3561a211a by Miss Islington (bot) in branch '3.7': bpo-36019: Use pythontest.net instead of example.com in network tests (GH-11941) https://github.com/python/cpython/commit/6163210089148ad31c270695f7273fc3561a211a

[issue36019] test_urllib fail in s390x buildbots: http://www.example.com/

STINNER Victor added the comment: > New changeset a40681dd5db8deaf05a635eecb91498dac882aa4 by Victor Stinner > (Stéphane Wirtel) in branch 'master': > bpo-36019: Use pythontest.net instead of example.com in network tests > (GH-11941) I'm not sure that this change will fix

[issue36019] test_urllib fail in s390x buildbots: http://www.example.com/

Change by miss-islington : -- pull_requests: +12012 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36019] test_urllib fail in s390x buildbots: http://www.example.com/

STINNER Victor added the comment: New changeset a40681dd5db8deaf05a635eecb91498dac882aa4 by Victor Stinner (Stéphane Wirtel) in branch 'master': bpo-36019: Use pythontest.net instead of example.com in network tests (GH-11941)

[issue36019] test_urllib fail in s390x buildbots: http://www.example.com/

Pablo Galindo Salgado added the comment: Related failure: https://buildbot.python.org/all/#/builders/141/builds/1233 -- Ran 56 tests in 25.105s OK (skipped=1) Re-running test 'test_normalization' in verbose mode

[issue36019] test_urllib fail in s390x buildbots: http://www.example.com/

Stéphane Wirtel added the comment: @vstinner I have fixed some URLs but we need to update pythontest.net for some tests. For example: test.test_urllib2.MiscTests.test_issue16464 raises a HTTP 405 and pythontest.net does not support the requested method.

[issue36019] test_urllib fail in s390x buildbots: http://www.example.com/

Stéphane Wirtel added the comment: @vstinner and @pablogsal I started to work on this issue, the PR is in WIP mode. -- ___ Python tracker ___

[issue36019] test_urllib fail in s390x buildbots: http://www.example.com/

Change by Stéphane Wirtel : -- keywords: +patch pull_requests: +11965 stage: -> patch review ___ Python tracker ___ ___

[issue36019] test_urllib fail in s390x buildbots: http://www.example.com/

Stéphane Wirtel added the comment: Here is the list of the external resources that we use in the tests. test_issue16464 (test.test_urllib2.MiscTests) ... skipped "Resource 'http://www.example.com/' is not available" test_close (test.test_urllib2net.CloseSocketTest) ... skipped "Resource

[issue36019] test_urllib fail in s390x buildbots: http://www.example.com/

Stéphane Wirtel added the comment: ok for me if you prefer to use a function test with pythontest.net -- ___ Python tracker ___ ___

[issue36019] test_urllib fail in s390x buildbots: http://www.example.com/

STINNER Victor added the comment: > could we mock the http requests? No, the tests are functional tests which use deliberate HTTP request to public servers. I suggest to use a server that we control rather multiple "third-party" servers. I'm trying to keep a list of external services used

[issue36019] test_urllib fail in s390x buildbots: http://www.example.com/

Stéphane Wirtel added the comment: sorry, error with my copy/paste/fixing_words: but my sentence was "could we mock the http requests?" -- ___ Python tracker ___

[issue36019] test_urllib fail in s390x buildbots: http://www.example.com/

Stéphane Wirtel added the comment: Use a public server or pythontest.net server (it's a public server on the Internet). could we the http requests? I use this practice for the unit test with an external web service, but for the integration tests, I prefer to use the real web service.

[issue36019] test_urllib fail in s390x buildbots: http://www.example.com/

Change by STINNER Victor : -- title: test_urllib fail in s390x buildbots -> test_urllib fail in s390x buildbots: http://www.example.com/ ___ Python tracker ___