[issue36043] FileCookieJar constructor don't accept PathLike

Change by Brett Cannon : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___ ___

[issue36043] FileCookieJar constructor don't accept PathLike

miss-islington added the comment: New changeset 4b219ce81ed04234648a4ce4f0cb0865818abb38 by Miss Islington (bot) (Stéphane Wirtel) in branch 'master': bpo-36043: FileCookieJar supports os.PathLike (GH-11945) https://github.com/python/cpython/commit/4b219ce81ed04234648a4ce4f0cb0865818abb38

[issue36043] FileCookieJar constructor don't accept PathLike

Alexander Kapshuna added the comment: Oh sorry, I just thought that everybody has forgotten about this part of library. Nevermind my patch then, your work is certainly better, matrixise. -- ___ Python tracker

[issue36043] FileCookieJar constructor don't accept PathLike

Stéphane Wirtel added the comment: in fact, I have published my PR because I have already the tests and I have another approach for this issue. -- stage: patch review -> ___ Python tracker

[issue36043] FileCookieJar constructor don't accept PathLike

Change by Stéphane Wirtel : -- pull_requests: +11969 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing

[issue36043] FileCookieJar constructor don't accept PathLike

Stéphane Wirtel added the comment: @xtreak sorry, but I have already worked on this issue :/ can I publish my PR? -- nosy: +matrixise versions: +Python 3.6, Python 3.7 ___ Python tracker

[issue36043] FileCookieJar constructor don't accept PathLike

Karthikeyan Singaravelan added the comment: This seems like a good change to me. GitHub PRs are accepted please see https://devguide.python.org/ . Since this is an enhancement it can only go as part of Python 3.8 if accepted. -- nosy: +xtreak versions: -Python 3.6, Python 3.7

[issue36043] FileCookieJar constructor don't accept PathLike

New submission from Alexander Kapshuna : FileCookieJar and it's subclasses don't accept Paths and DirEntrys. Minimal code to reproduce: === import pathlib from http.cookiejar import FileCookieJar saved_cookies = pathlib.Path('my_cookies.txt') jar = FileCookieJar(saved_cookies) === Results