[issue36074] Result of `asyncio.Server.sockets` after `Server.close()` is not clear

Julien Palard added the comment: Thanks Emmanuel for the PR (yes those PRs do not need NEWS). Thanks Kevin for the proposition to try fixing it the other way around, that's appreciated, don't hesitate to filter on easy issues there's some others :) -- resolution: -> fixed stage:

[issue36074] Result of `asyncio.Server.sockets` after `Server.close()` is not clear

miss-islington added the comment: New changeset df5cdc11123a35065bbf1636251447d0bfe789a5 by Miss Islington (bot) (Emmanuel Arias) in branch 'master': bpo-36074: Result of `asyncio.Server.sockets` after `Server.close()` after is not clear (GH-11987)

[issue36074] Result of `asyncio.Server.sockets` after `Server.close()` is not clear

Emmanuel Arias added the comment: > @mdk That's interesting. May I ask which one is the preferred behavior, > `None` or `[]`? IMO changing the returned of the sockets could represent a big change, and I think that this need to be discuss -- ___

[issue36074] Result of `asyncio.Server.sockets` after `Server.close()` is not clear

Kevin Mai-Hsuan Chia added the comment: @mdk That's interesting. May I ask which one is the preferred behavior, `None` or `[]`? IMO both make sense, but `None` is more consistent with the behavior in previous versions. If it is the case, may I work on fixing this(`None` to `[]`) as a

[issue36074] Result of `asyncio.Server.sockets` after `Server.close()` is not clear

Change by STINNER Victor : -- nosy: -vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36074] Result of `asyncio.Server.sockets` after `Server.close()` is not clear

Julien Palard added the comment: Behavior changed in commit c9070d03f5169ad6e171e641b7fa8feab18bf229 (Jan 2018) but has been documented as returning None since 8ebeb03740dad4d9edd65de88f82840a05070941 (Jul 2014). -- nosy: +mdk, vstinner, yselivanov

[issue36074] Result of `asyncio.Server.sockets` after `Server.close()` is not clear

Emmanuel Arias added the comment: > Sure thing. Should it be discussed more detailed before the PR? If the > document or the returned value is controversial, I would like to contribute > if needed. Thanks :) Please, make the comments on the PR. This way, other reviewer can see your

[issue36074] Result of `asyncio.Server.sockets` after `Server.close()` is not clear

Kevin Mai-Hsuan Chia added the comment: Sure thing. Should it be discussed more detailed before the PR? If the document or the returned value is controversial, I would like to contribute if needed. Thanks :) -- ___ Python tracker

[issue36074] Result of `asyncio.Server.sockets` after `Server.close()` is not clear

Emmanuel Arias added the comment: @mhchia yes! sorry! I was testing the .close() return. yes you are right is confused. I will modified the PR. Thanks -- ___ Python tracker

[issue36074] Result of `asyncio.Server.sockets` after `Server.close()` is not clear

Kevin Mai-Hsuan Chia added the comment: Excuse me, I tried 3.7.2 and 3.8.0a1+ with the following code and still failed. Could you help me to try this? or can you give me a pointer to the code returning `None`? Sorry for the inconvenience and thanks a lot. ``` import asyncio import platform

[issue36074] Result of `asyncio.Server.sockets` after `Server.close()` is not clear

Change by Emmanuel Arias : -- keywords: +patch pull_requests: +12010 stage: -> patch review ___ Python tracker ___ ___

[issue36074] Result of `asyncio.Server.sockets` after `Server.close()` is not clear

Emmanuel Arias added the comment: Maybe would be great mention that the None is still return for closed server -- ___ Python tracker ___

[issue36074] Result of `asyncio.Server.sockets` after `Server.close()` is not clear

Emmanuel Arias added the comment: hmm looking in depth when the server is closed, currently return None. -- ___ Python tracker ___

[issue36074] Result of `asyncio.Server.sockets` after `Server.close()` is not clear

Emmanuel Arias added the comment: Yes, that is a problem (in principle) of the docs. But I think that would be appropriate return None if is closed. -- nosy: +eamanu ___ Python tracker

[issue36074] Result of `asyncio.Server.sockets` after `Server.close()` is not clear

New submission from Kevin Mai-Hsuan Chia : It seems the result of `asyncio.Server.sockets` after `asyncio.Server.close()` is performed becomes `[]` instead of `None` since python 3.7. However, in the [document 3.7 and