[issue36373] Deprecate explicit loop parameter in all public asyncio APIs

Change by Andrew Svetlov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue36373] Deprecate explicit loop parameter in all public asyncio APIs

miss-islington added the comment: New changeset 345bfc990f5f3e873774051d43136b06bfed82cb by Miss Islington (bot) in branch '3.8': bpo-36373: Deprecate explicit loop in task and subprocess API (GH-16033) https://github.com/python/cpython/commit/345bfc990f5f3e873774051d43136b06bfed82cb

[issue36373] Deprecate explicit loop parameter in all public asyncio APIs

Andrew Svetlov added the comment: New changeset a488879cbaf4b8b52699cadccf73bb4c271bcb29 by Andrew Svetlov in branch 'master': bpo-36373: Deprecate explicit loop in task and subprocess API (GH-16033) https://github.com/python/cpython/commit/a488879cbaf4b8b52699cadccf73bb4c271bcb29

[issue36373] Deprecate explicit loop parameter in all public asyncio APIs

Change by miss-islington : -- pull_requests: +15661 pull_request: https://github.com/python/cpython/pull/16039 ___ Python tracker ___

[issue36373] Deprecate explicit loop parameter in all public asyncio APIs

Change by Andrew Svetlov : -- pull_requests: +15655 pull_request: https://github.com/python/cpython/pull/16033 ___ Python tracker ___

[issue36373] Deprecate explicit loop parameter in all public asyncio APIs

Andrew Svetlov added the comment: New changeset 4601f7a49fe8ed00c4b6b70b0eda2b3922568e9b by Andrew Svetlov in branch '3.8': [3.8] bpo-36373: Fix deprecation warnings (GH-15889) (GH-15901) https://github.com/python/cpython/commit/4601f7a49fe8ed00c4b6b70b0eda2b3922568e9b --

[issue36373] Deprecate explicit loop parameter in all public asyncio APIs

Change by Andrew Svetlov : -- pull_requests: +15542 pull_request: https://github.com/python/cpython/pull/15901 ___ Python tracker ___

[issue36373] Deprecate explicit loop parameter in all public asyncio APIs

Change by miss-islington : -- pull_requests: +15537 pull_request: https://github.com/python/cpython/pull/15896 ___ Python tracker ___

[issue36373] Deprecate explicit loop parameter in all public asyncio APIs

miss-islington added the comment: New changeset 7264e92b718d307cc499b2f10eab7644b00f0499 by Miss Islington (bot) (Andrew Svetlov) in branch 'master': bpo-36373: Fix deprecation warnings (GH-15889) https://github.com/python/cpython/commit/7264e92b718d307cc499b2f10eab7644b00f0499 --

[issue36373] Deprecate explicit loop parameter in all public asyncio APIs

Andrew Svetlov added the comment: Answered in https://github.com/python/cpython/pull/15889 -- ___ Python tracker ___ ___

[issue36373] Deprecate explicit loop parameter in all public asyncio APIs

Yury Selivanov added the comment: (copying my GitHub message on this topic from https://github.com/python/cpython/pull/15889#issuecomment-530030002) I thought we were going to be more subtle about this. We have two scenarios: 1. Somebody creates an instance of asyncio.Lock outside of a

[issue36373] Deprecate explicit loop parameter in all public asyncio APIs

Yury Selivanov added the comment: (copying my GitHub message on this topic from https://github.com/python/cpython/pull/15889#issuecomment-530030002) I thought we were going to be more subtle about this. We have two scenarios: Somebody creates an instance of asyncio.Lock outside of a

[issue36373] Deprecate explicit loop parameter in all public asyncio APIs

Change by Yury Selivanov : -- Removed message: https://bugs.python.org/msg351728 ___ Python tracker ___ ___ Python-bugs-list

[issue36373] Deprecate explicit loop parameter in all public asyncio APIs

Change by Andrew Svetlov : -- pull_requests: +15530 pull_request: https://github.com/python/cpython/pull/15889 ___ Python tracker ___

[issue36373] Deprecate explicit loop parameter in all public asyncio APIs

Karthikeyan Singaravelan added the comment: Ah okay. There were places like Condition's constructor that has a deprecation warning and we construct a Lock with loop passed in the constructor and I passed along _asyncio_internal. I would be happy to look into your PR since mine is just

[issue36373] Deprecate explicit loop parameter in all public asyncio APIs

Andrew Svetlov added the comment: Better to avoid _asyncio_internal if not strictly necessary. Currently, _asyncio_internal is used for protection of asyncio class direct instantiation. E.g. stream = asyncio.Stream() is forbidden, people should use factories like stream = await

[issue36373] Deprecate explicit loop parameter in all public asyncio APIs

Karthikeyan Singaravelan added the comment: Is it okay to have _asyncio_internal keyword with default value as False and the places where it's used internally in stdlib like AsyncMock (Condition), async_case (Queue) and other tests we can pass in True? I have a patch if that would be a good

[issue36373] Deprecate explicit loop parameter in all public asyncio APIs

Andrew Svetlov added the comment: Thanks for the report xtreak, I'll make a fix. -- ___ Python tracker ___ ___ Python-bugs-list

[issue36373] Deprecate explicit loop parameter in all public asyncio APIs

Karthikeyan Singaravelan added the comment: Few more tests and call sites ./python.exe -Wall -m test test_asyncio Run tests sequentially 0:00:00 load avg: 2.41 [1/1] test_asyncio /Users/karthikeyansingaravelan/stuff/python/cpython/Lib/asyncio/locks.py:335: DeprecationWarning: The loop

[issue36373] Deprecate explicit loop parameter in all public asyncio APIs

Karthikeyan Singaravelan added the comment: async_case passes loop parameter to the queue used to collect tests and this causes below DeprecationWarning with last change over deprecation in queues and locks API. ./python.exe -m unittest Lib.unittest.test.test_async_case

[issue36373] Deprecate explicit loop parameter in all public asyncio APIs

miss-islington added the comment: New changeset 55daf1a56163e0673654712bb92ce47a9b6f7be3 by Miss Islington (bot) in branch '3.8': bpo-36373: Deprecate explicit loop parameter in all public asyncio APIs [queue] (GH-13950)

[issue36373] Deprecate explicit loop parameter in all public asyncio APIs

miss-islington added the comment: New changeset 9008be303a89bfab8c3314c6a42330b5523adc8b by Miss Islington (bot) (Emmanuel Arias) in branch 'master': bpo-36373: Deprecate explicit loop parameter in all public asyncio APIs [queue] (GH-13950)

[issue36373] Deprecate explicit loop parameter in all public asyncio APIs

Change by miss-islington : -- pull_requests: +15488 pull_request: https://github.com/python/cpython/pull/15841 ___ Python tracker ___

[issue36373] Deprecate explicit loop parameter in all public asyncio APIs

miss-islington added the comment: New changeset bb8fc8bd309419c159b632068dff73c3c76d478c by Miss Islington (bot) in branch '3.8': bpo-36373: Deprecate explicit loop parameter in all public asyncio APIs [locks] (GH-13920)

[issue36373] Deprecate explicit loop parameter in all public asyncio APIs

Change by miss-islington : -- pull_requests: +15480 pull_request: https://github.com/python/cpython/pull/15835 ___ Python tracker ___

[issue36373] Deprecate explicit loop parameter in all public asyncio APIs

miss-islington added the comment: New changeset 537877d85d1c27d2c2f5189e39da64a7a0c413d3 by Miss Islington (bot) (Emmanuel Arias) in branch 'master': bpo-36373: Deprecate explicit loop parameter in all public asyncio APIs [locks] (GH-13920)

[issue36373] Deprecate explicit loop parameter in all public asyncio APIs

Change by Emmanuel Arias : -- pull_requests: +13818 pull_request: https://github.com/python/cpython/pull/13950 ___ Python tracker ___

[issue36373] Deprecate explicit loop parameter in all public asyncio APIs

Change by Emmanuel Arias : -- pull_requests: +13793 pull_request: https://github.com/python/cpython/pull/13920 ___ Python tracker ___

[issue36373] Deprecate explicit loop parameter in all public asyncio APIs

miss-islington added the comment: New changeset 8899b11b95f08e2e03478f2acad336ad5933a2d1 by Miss Islington (bot) in branch '3.8': bpo-36373: Deprecate explicit loop parameter in all public asyncio APIs [streams] (GH-13671)

[issue36373] Deprecate explicit loop parameter in all public asyncio APIs

miss-islington added the comment: New changeset 6d64a8f49eb321116f585c4b036c81bb976d2d5c by Miss Islington (bot) (Emmanuel Arias) in branch 'master': bpo-36373: Deprecate explicit loop parameter in all public asyncio APIs [streams] (GH-13671)

[issue36373] Deprecate explicit loop parameter in all public asyncio APIs

Change by miss-islington : -- pull_requests: +13712 pull_request: https://github.com/python/cpython/pull/13833 ___ Python tracker ___

[issue36373] Deprecate explicit loop parameter in all public asyncio APIs

Change by Emmanuel Arias : -- pull_requests: +13560 pull_request: https://github.com/python/cpython/pull/13671 ___ Python tracker ___

[issue36373] Deprecate explicit loop parameter in all public asyncio APIs

Change by Emmanuel Arias : -- keywords: +patch pull_requests: +13559 stage: -> patch review pull_request: https://github.com/python/cpython/pull/13670 ___ Python tracker ___

[issue36373] Deprecate explicit loop parameter in all public asyncio APIs

Change by Andrew Svetlov : -- title: asyncio.gather: no docs for deprecated loop parameter -> Deprecate explicit loop parameter in all public asyncio APIs ___ Python tracker

[issue36373] Deprecate explicit loop parameter in all public asyncio APIs

Change by Andrew Svetlov : -- title: asyncio.gather: no docs for deprecated loop parameter -> Deprecate explicit loop parameter in all public asyncio APIs ___ Python tracker

[issue36373] Deprecate explicit loop parameter in all public asyncio APIs

Change by Andrew Svetlov : -- versions: +Python 3.8 -Python 3.7 ___ Python tracker ___ ___ Python-bugs-list mailing list