[issue3642] Objects/obmalloc.c:529: warning: comparison is always false due to limited range of data type

2008-09-11 Thread Martin v. Löwis
Martin v. Löwis [EMAIL PROTECTED] added the comment: I have now committed the new patch as r66383 and r66384 -- resolution: - fixed status: open - closed ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3642

[issue3642] Objects/obmalloc.c:529: warning: comparison is always false due to limited range of data type

2008-09-10 Thread Martin v. Löwis
Martin v. Löwis [EMAIL PROTECTED] added the comment: Here is my attempt for a patch (obmalloc.diff). Please review. -- keywords: +needs review Added file: http://bugs.python.org/file11457/obmalloc.diff ___ Python tracker [EMAIL PROTECTED]

[issue3642] Objects/obmalloc.c:529: warning: comparison is always false due to limited range of data type

2008-09-10 Thread Brett Cannon
Brett Cannon [EMAIL PROTECTED] added the comment: Patch looks good to me and Martin's analysis of the test being useless on a platform where size_t uint_t makes sense. -- keywords: -needs review ___ Python tracker [EMAIL PROTECTED]

[issue3642] Objects/obmalloc.c:529: warning: comparison is always false due to limited range of data type

2008-09-09 Thread Barry A. Warsaw
Changes by Barry A. Warsaw [EMAIL PROTECTED]: -- priority: deferred blocker - release blocker ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3642 ___

[issue3642] Objects/obmalloc.c:529: warning: comparison is always false due to limited range of data type

2008-09-09 Thread Brett Cannon
Brett Cannon [EMAIL PROTECTED] added the comment: Going with what Martin suggested, the attached patch reverts what Christian did and adds an #ifdef sizeof(uint) = sizeof(uint) around the PY_SIZE_MAX check. Someone should obviously test on an AMD64 machine (I have a Core 2 Mac, but I don't know

[issue3642] Objects/obmalloc.c:529: warning: comparison is always false due to limited range of data type

2008-09-09 Thread Martin v. Löwis
Martin v. Löwis [EMAIL PROTECTED] added the comment: It doesn't work that way - you can't use sizeof() in the preprocessor. Instead, the pyconfig.h constants should be used. I'll try to look into this later today. ___ Python tracker [EMAIL PROTECTED]

[issue3642] Objects/obmalloc.c:529: warning: comparison is always false due to limited range of data type

2008-09-03 Thread Benjamin Peterson
Changes by Benjamin Peterson [EMAIL PROTECTED]: -- priority: release blocker - deferred blocker ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3642 ___

[issue3642] Objects/obmalloc.c:529: warning: comparison is always false due to limited range of data type

2008-08-24 Thread Christian Heimes
Christian Heimes [EMAIL PROTECTED] added the comment: I've fixed both compiler warnings in trunk and py3k branch. -- resolution: - fixed status: open - closed ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3642

[issue3642] Objects/obmalloc.c:529: warning: comparison is always false due to limited range of data type

2008-08-24 Thread Martin v. Löwis
Martin v. Löwis [EMAIL PROTECTED] added the comment: I think the patch is fairly incomplete. i still stays at uint, so if numarenas would ever overflow uint, the loop would never reach numarenas, and all arenas would get discarded. Likewise, maxarenas still stays at uint, so when numarenas

[issue3642] Objects/obmalloc.c:529: warning: comparison is always false due to limited range of data type

2008-08-24 Thread Martin v. Löwis
Martin v. Löwis [EMAIL PROTECTED] added the comment: In my humble opinion it should be safe to limit the amount of arenas to UINT_MAX instead of PY_SIZE_MAX. 4,294,967,295 arenas should be more than sufficient for the next decade or two. Do you concur? It is certainly reasonable to limit

[issue3642] Objects/obmalloc.c:529: warning: comparison is always false due to limited range of data type

2008-08-23 Thread Brett Cannon
Brett Cannon [EMAIL PROTECTED] added the comment: There is no patch here, so undoing the needs review flag. -- keywords: -needs review nosy: +brett.cannon ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3642

[issue3642] Objects/obmalloc.c:529: warning: comparison is always false due to limited range of data type

2008-08-22 Thread Christian Heimes
Christian Heimes [EMAIL PROTECTED] added the comment: The warning in obmalloc.c was silenced in r65975 (trunk) and r65976 (py3k) ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3642 ___

[issue3642] Objects/obmalloc.c:529: warning: comparison is always false due to limited range of data type

2008-08-21 Thread Christian Heimes
New submission from Christian Heimes [EMAIL PROTECTED]: I'm getting a compiler warning on Linux AMD64. It's most probably an issue related to 64bit builds, because size_t uint_t on 64bit systems. Such warnings may hide overflow issues. gcc -pthread -c -fno-strict-aliasing -g -Wall

[issue3642] Objects/obmalloc.c:529: warning: comparison is always false due to limited range of data type

2008-08-21 Thread Christian Heimes
Christian Heimes [EMAIL PROTECTED] added the comment: I'm seeing a similar issue in py3k: Objects/bytesobject.c: In function '_PyBytes_FormatLong': Objects/bytesobject.c:3203: warning: comparison is always false due to limited range of data type ___ Python