[issue37053] Tools/parser/unparse.py does not handle u"bar" correctly

miss-islington added the comment: New changeset aaf47caf35984e614d93bd8bea5227df55e0e3e6 by Miss Islington (bot) (Chih-Hsuan Yen) in branch 'master': bpo-37053: handle strings like u"bar" correctly in Tools/parser/unparse.py (GH-13583) https://github.com/python/cpython/commit/aaf47caf35984e6

[issue37053] Tools/parser/unparse.py does not handle u"bar" correctly

Pablo Galindo Salgado added the comment: Confirmed that this fixes the broken buildbots: ./python -m test test_tools - -uall -m test_files == CPython 3.8.0a4+ (heads/master:91f4380ced, May 26 2019, 17:30:21) [GCC 8.3.0] == Linux-5.0.15-1-MANJARO-x86_64-with-glibc2.29 little-endian == cwd:

[issue37053] Tools/parser/unparse.py does not handle u"bar" correctly

Chih-Hsuan Yen added the comment: After reading Python/ast.c, I think my patch is correct, so I submitted it to GitHub as https://github.com/python/cpython/pull/13583 :) -- ___ Python tracker __

[issue37053] Tools/parser/unparse.py does not handle u"bar" correctly

Change by Chih-Hsuan Yen : -- keywords: +patch pull_requests: +13490 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/13583 ___ Python tracker __

[issue37053] Tools/parser/unparse.py does not handle u"bar" correctly

Guido van Rossum added the comment: Please submit a PR. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: h

[issue37053] Tools/parser/unparse.py does not handle u"bar" correctly

Ivan Levkivskyi added the comment: On the other hand, if this causes troubles, feel free to just replace u"bar" with "bar" in that test. It is not really important. -- nosy: +levkivskyi ___ Python tracker _

[issue37053] Tools/parser/unparse.py does not handle u"bar" correctly

Change by Serhiy Storchaka : -- keywords: +easy nosy: +gvanrossum stage: -> needs patch type: behavior -> enhancement ___ Python tracker ___ __

[issue37053] Tools/parser/unparse.py does not handle u"bar" correctly

New submission from Chih-Hsuan Yen : Currently (135c6a56e55d2f4f8718b3b9f03ce3c692b15f0f) the following test fails: ./python -m test.regrtest -v test_tools.test_unparse -u cpu (Note that -u cpu is needed to force test_unparse.DirectoryTestCase to check all files under Lib/ and Lib/test/.) An