[issue37120] Provide knobs to disable session ticket generation on TLS 1.3

Change by Christian Heimes : -- stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs-list

[issue37120] Provide knobs to disable session ticket generation on TLS 1.3

miss-islington added the comment: New changeset bbad695e7890513be7a9bc662e2d8ae13bfcd313 by Miss Islington (bot) in branch '3.8': bpo-37120: Fix _ssl get_num_tickets() (GH-14668) https://github.com/python/cpython/commit/bbad695e7890513be7a9bc662e2d8ae13bfcd313 --

[issue37120] Provide knobs to disable session ticket generation on TLS 1.3

Change by miss-islington : -- pull_requests: +14479 pull_request: https://github.com/python/cpython/pull/14671 ___ Python tracker ___

[issue37120] Provide knobs to disable session ticket generation on TLS 1.3

miss-islington added the comment: New changeset 76611c7c0af6b2f4d0d98a5db827d34cff54ce25 by Miss Islington (bot) (Victor Stinner) in branch 'master': bpo-37120: Fix _ssl get_num_tickets() (GH-14668) https://github.com/python/cpython/commit/76611c7c0af6b2f4d0d98a5db827d34cff54ce25

[issue37120] Provide knobs to disable session ticket generation on TLS 1.3

Change by STINNER Victor : -- pull_requests: +14476 stage: commit review -> patch review pull_request: https://github.com/python/cpython/pull/14668 ___ Python tracker ___

[issue37120] Provide knobs to disable session ticket generation on TLS 1.3

STINNER Victor added the comment: New changeset 78c7d527799dacca91b9ed67057cb996efe526b0 by Christian Heimes in branch 'master': bpo-37120: Add SSLContext.num_tickets (GH-13719) https://github.com/python/cpython/commit/78c7d527799dacca91b9ed67057cb996efe526b0 This change introduced this

[issue37120] Provide knobs to disable session ticket generation on TLS 1.3

Nathaniel Smith added the comment: > Regarding your comment on client_context.num_ticket getter: IMHO it's not a > good idea to raise an exception on attribute access. It may break > introspection. Hmm, I see what you mean. Basically my intuition is: it's a bit weird to make the

[issue37120] Provide knobs to disable session ticket generation on TLS 1.3

Change by Christian Heimes : -- resolution: -> fixed stage: patch review -> commit review status: open -> pending ___ Python tracker ___

[issue37120] Provide knobs to disable session ticket generation on TLS 1.3

Christian Heimes added the comment: I have merged the PR to land the feature in time for the feature freeze. Regarding your comment on client_context.num_ticket getter: IMHO it's not a good idea to raise an exception on attribute access. It may break introspection. --

[issue37120] Provide knobs to disable session ticket generation on TLS 1.3

Christian Heimes added the comment: New changeset 78c7d527799dacca91b9ed67057cb996efe526b0 by Christian Heimes in branch 'master': bpo-37120: Add SSLContext.num_tickets (GH-13719) https://github.com/python/cpython/commit/78c7d527799dacca91b9ed67057cb996efe526b0 --

[issue37120] Provide knobs to disable session ticket generation on TLS 1.3

Christian Heimes added the comment: +1 for the idea Yes, for simple flags and settings, an attribute on the SSLContext is prefer. The SSLContext object is the configuration space for its connections. I would prefer to keep the setting only on the context and not clutter SSLSocket and

[issue37120] Provide knobs to disable session ticket generation on TLS 1.3

Change by Christian Heimes : -- keywords: +patch pull_requests: +13607 stage: -> patch review pull_request: https://github.com/python/cpython/pull/13719 ___ Python tracker

[issue37120] Provide knobs to disable session ticket generation on TLS 1.3

New submission from Nathaniel Smith : Maybe we should expose the SSL_CTX_set_num_tickets function: https://www.openssl.org/docs/man1.1.1/man3/SSL_CTX_set_num_tickets.html This is a new function added in OpenSSL 1.1.1, that lets you control the number of tickets issued by a TLS 1.3 connection.