[issue37253] PyCompilerFlags got a new cf_feature_version field

Change by STINNER Victor : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue37253] PyCompilerFlags got a new cf_feature_version field

STINNER Victor added the comment: > It's fine to document the current state. I don't think you should spend any > time *changing* the API to "future-proof" it. Ok. > I am hoping that larger changes to the compiler implementation will happen > before Python 4, which will make the whole API

[issue37253] PyCompilerFlags got a new cf_feature_version field

miss-islington added the comment: New changeset 032bf30643fff49b5595b53f9c1ce5b2cd2df504 by Miss Islington (bot) in branch '3.8': bpo-37253: Remove PyAST_obj2mod_ex() function (GH-14020) https://github.com/python/cpython/commit/032bf30643fff49b5595b53f9c1ce5b2cd2df504 --

[issue37253] PyCompilerFlags got a new cf_feature_version field

STINNER Victor added the comment: New changeset 022ac0a497b668d8b15e34e582a6396ead1a35e1 by Victor Stinner in branch 'master': bpo-37253: Remove PyAST_obj2mod_ex() function (GH-14020) https://github.com/python/cpython/commit/022ac0a497b668d8b15e34e582a6396ead1a35e1 --

[issue37253] PyCompilerFlags got a new cf_feature_version field

Change by miss-islington : -- pull_requests: +13906 pull_request: https://github.com/python/cpython/pull/14044 ___ Python tracker ___

[issue37253] PyCompilerFlags got a new cf_feature_version field

STINNER Victor added the comment: New changeset f9445a391e6a91103fbe88bff4d3adc07f526c73 by Victor Stinner in branch '3.8': [3.8] bpo-37253: Document PyCompilerFlags.cf_feature_version (GH-14019) (GH-14038) https://github.com/python/cpython/commit/f9445a391e6a91103fbe88bff4d3adc07f526c73

[issue37253] PyCompilerFlags got a new cf_feature_version field

miss-islington added the comment: New changeset 92e836c7dcaf74f7b8617250414224d24d1eb1f2 by Miss Islington (bot) in branch '3.8': bpo-37253: Add _PyCompilerFlags_INIT macro (GH-14018) https://github.com/python/cpython/commit/92e836c7dcaf74f7b8617250414224d24d1eb1f2 -- nosy:

[issue37253] PyCompilerFlags got a new cf_feature_version field

STINNER Victor added the comment: Many PyRun_xxx() functions of the public C API accept a "PyCompilerFlags* flags" parameter. So yeah, I documented the new cf_feature_version. PyCompilerFlags structure is kind of public ;-) -- ___ Python tracker

[issue37253] PyCompilerFlags got a new cf_feature_version field

Change by STINNER Victor : -- pull_requests: +13902 pull_request: https://github.com/python/cpython/pull/14038 ___ Python tracker ___

[issue37253] PyCompilerFlags got a new cf_feature_version field

Change by miss-islington : -- pull_requests: +13901 pull_request: https://github.com/python/cpython/pull/14037 ___ Python tracker ___

[issue37253] PyCompilerFlags got a new cf_feature_version field

STINNER Victor added the comment: New changeset a04ea4f92ccbe20ffdbb5fa9b6bb93ee8da50f5d by Victor Stinner in branch 'master': bpo-37253: Fix typo in PyCompilerFlags doc (GH-14036) https://github.com/python/cpython/commit/a04ea4f92ccbe20ffdbb5fa9b6bb93ee8da50f5d --

[issue37253] PyCompilerFlags got a new cf_feature_version field

STINNER Victor added the comment: New changeset 37d66d7d4bc7dbac9809d69966a774ebb32563be by Victor Stinner in branch 'master': bpo-37253: Add _PyCompilerFlags_INIT macro (GH-14018) https://github.com/python/cpython/commit/37d66d7d4bc7dbac9809d69966a774ebb32563be --

[issue37253] PyCompilerFlags got a new cf_feature_version field

Change by STINNER Victor : -- pull_requests: +13900 pull_request: https://github.com/python/cpython/pull/14036 ___ Python tracker ___

[issue37253] PyCompilerFlags got a new cf_feature_version field

STINNER Victor added the comment: New changeset 2c9b498759f4fc74da82a0a96d059d666fa73f16 by Victor Stinner in branch 'master': bpo-37253: Document PyCompilerFlags.cf_feature_version (GH-14019) https://github.com/python/cpython/commit/2c9b498759f4fc74da82a0a96d059d666fa73f16 --

[issue37253] PyCompilerFlags got a new cf_feature_version field

Change by miss-islington : -- pull_requests: +13899 pull_request: https://github.com/python/cpython/pull/14035 ___ Python tracker ___

[issue37253] PyCompilerFlags got a new cf_feature_version field

Guido van Rossum added the comment: It's fine to document the current state. I don't think you should spend any time *changing* the API to "future-proof" it. I am hoping that larger changes to the compiler implementation will happen before Python 4, which will make the whole API moot

[issue37253] PyCompilerFlags got a new cf_feature_version field

STINNER Victor added the comment: > Something else, ast.parse() has been modified to use a (major, minor) version > tuple rather an integer to specify the Python version in feature_version, but > PyCompilerFlags still only uses the minor major. This API will be broken once > the Python

[issue37253] PyCompilerFlags got a new cf_feature_version field

Change by STINNER Victor : -- pull_requests: +13885 pull_request: https://github.com/python/cpython/pull/14020 ___ Python tracker ___

[issue37253] PyCompilerFlags got a new cf_feature_version field

Change by STINNER Victor : -- pull_requests: +13884 pull_request: https://github.com/python/cpython/pull/14019 ___ Python tracker ___

[issue37253] PyCompilerFlags got a new cf_feature_version field

Change by STINNER Victor : -- keywords: +patch pull_requests: +13883 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14018 ___ Python tracker ___

[issue37253] PyCompilerFlags got a new cf_feature_version field

New submission from STINNER Victor : The commit dcfcd146f8e6fc5c2fc16a4c192a0c5f5ca8c53c of bpo-35766 added a new cf_feature_version field to PyCompilerFlags. Each PyCompilerFlags variable must properly initialize this new field to PY_MINOR_VERSION. I propose to add a new