[issue37322] test_ssl: test_pha_required_nocert() emits a ResourceWarning

STINNER Victor added the comment: ResourceWarning is no longer emitted. I close the issue. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue37322] test_ssl: test_pha_required_nocert() emits a ResourceWarning

Christian Heimes added the comment: I have cherry-picked e047239eafefe8b19725efffe7756443495cf78b into both backports and rebased them on top of upstream/3.8 and upstream/3.9. -- ___ Python tracker

[issue37322] test_ssl: test_pha_required_nocert() emits a ResourceWarning

Łukasz Langa added the comment: I re-ran CI on the pull requests, the 3.8 and 3.9 failures on Windows X64 and macOS reproduced the same. -- nosy: +lukasz.langa ___ Python tracker

[issue37322] test_ssl: test_pha_required_nocert() emits a ResourceWarning

Change by Christian Heimes : -- pull_requests: +24292 pull_request: https://github.com/python/cpython/pull/25573 ___ Python tracker ___

[issue37322] test_ssl: test_pha_required_nocert() emits a ResourceWarning

Change by Christian Heimes : -- pull_requests: +24291 pull_request: https://github.com/python/cpython/pull/25572 ___ Python tracker ___

[issue37322] test_ssl: test_pha_required_nocert() emits a ResourceWarning

Christian Heimes added the comment: New changeset c8666cfa7cdc48915a14cd16095a69029720736a by Christian Heimes in branch 'master': bpo-37322: Fix ResourceWarning and exception handling in test (GH-25553) https://github.com/python/cpython/commit/c8666cfa7cdc48915a14cd16095a69029720736a

[issue37322] test_ssl: test_pha_required_nocert() emits a ResourceWarning

Change by Christian Heimes : -- pull_requests: +24273 pull_request: https://github.com/python/cpython/pull/25553 ___ Python tracker ___

[issue37322] test_ssl: test_pha_required_nocert() emits a ResourceWarning

Christian Heimes added the comment: I wasn't aware of this bpo and created bpo-43885 a couple of days ago. tl;dr I do not understand test changes in fb7e7505ed1337bf40fa7b8b68317d1e86675a86 at all. I think that these changes are broken, too. ThreadedEchoServer and ConnectionHandler must

[issue37322] test_ssl: test_pha_required_nocert() emits a ResourceWarning

Change by Matthew Hughes : -- pull_requests: +20541 pull_request: https://github.com/python/cpython/pull/21393 ___ Python tracker ___

[issue37322] test_ssl: test_pha_required_nocert() emits a ResourceWarning

Matthew Hughes added the comment: Whoops, I realise the patch I shared contained a combination of two (independent) approaches I tried: 1. Add sleep and perform cleanup 2. Naively patch catch_threading_exception to accept a cleanup routine to be run upon exiting but before removing the

[issue37322] test_ssl: test_pha_required_nocert() emits a ResourceWarning

Matthew Hughes added the comment: I noticed this test was still emitting a "ResourceWarning": -- $ ./python -m test test_ssl -m TestPostHandshakeAuth 0:00:00 load avg: 0.74 Run tests sequentially 0:00:00 load avg: 0.74 [1/1]

[issue37322] test_ssl: test_pha_required_nocert() emits a ResourceWarning

miss-islington added the comment: New changeset 4c403b8ca2d0ef44b691cceaeeac9e110fd3f05a by Miss Islington (bot) in branch '3.8': bpo-37322: ssl test_pha_required_nocert() ignores expected SSLError (GH-14670) https://github.com/python/cpython/commit/4c403b8ca2d0ef44b691cceaeeac9e110fd3f05a

[issue37322] test_ssl: test_pha_required_nocert() emits a ResourceWarning

STINNER Victor added the comment: New changeset 73ea54620a6f91c3f2e53880373dd47813691a21 by Victor Stinner in branch 'master': bpo-37322: ssl test_pha_required_nocert() ignores expected SSLError (GH-14670) https://github.com/python/cpython/commit/73ea54620a6f91c3f2e53880373dd47813691a21

[issue37322] test_ssl: test_pha_required_nocert() emits a ResourceWarning

Change by miss-islington : -- pull_requests: +14481 pull_request: https://github.com/python/cpython/pull/14673 ___ Python tracker ___

[issue37322] test_ssl: test_pha_required_nocert() emits a ResourceWarning

STINNER Victor added the comment: The test also logs an "Exception in thread Thread-2:" error: --- vstinner@apu$ ./python -m test test_ssl -m test_pha_required_nocert -v == CPython 3.9.0a0 (heads/master:110a47c4f4, Jul 8 2019, 23:52:00) [GCC 9.1.1 20190503 (Red Hat 9.1.1-1)] ==

[issue37322] test_ssl: test_pha_required_nocert() emits a ResourceWarning

Change by STINNER Victor : -- pull_requests: +14478 pull_request: https://github.com/python/cpython/pull/14670 ___ Python tracker ___

[issue37322] test_ssl: test_pha_required_nocert() emits a ResourceWarning

STINNER Victor added the comment: New changeset 61b1bc56069719fc6f17c73fdf2193636dbf6cc2 by Victor Stinner in branch 'master': Revert "bpo-37322: Fix test_ssl.test_pha_required_nocert() ResourceWarning (GH-14662)" (GH-14669)

[issue37322] test_ssl: test_pha_required_nocert() emits a ResourceWarning

STINNER Victor added the comment: > New changeset cf9c41c422de3774862db964fe3153086bad3f61 by Victor Stinner in > branch 'master': > bpo-37322: Fix test_ssl.test_pha_required_nocert() ResourceWarning (GH-14662) Oh. This test started to fail on Windows with this change. Example:

[issue37322] test_ssl: test_pha_required_nocert() emits a ResourceWarning

Change by STINNER Victor : -- pull_requests: +14477 pull_request: https://github.com/python/cpython/pull/14669 ___ Python tracker ___

[issue37322] test_ssl: test_pha_required_nocert() emits a ResourceWarning

Change by STINNER Victor : -- pull_requests: +14475 pull_request: https://github.com/python/cpython/pull/14667 ___ Python tracker ___

[issue37322] test_ssl: test_pha_required_nocert() emits a ResourceWarning

Change by miss-islington : -- pull_requests: +14473 pull_request: https://github.com/python/cpython/pull/14665 ___ Python tracker ___

[issue37322] test_ssl: test_pha_required_nocert() emits a ResourceWarning

STINNER Victor added the comment: New changeset cf9c41c422de3774862db964fe3153086bad3f61 by Victor Stinner in branch 'master': bpo-37322: Fix test_ssl.test_pha_required_nocert() ResourceWarning (GH-14662) https://github.com/python/cpython/commit/cf9c41c422de3774862db964fe3153086bad3f61

[issue37322] test_ssl: test_pha_required_nocert() emits a ResourceWarning

Change by STINNER Victor : -- keywords: +patch pull_requests: +14470 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14662 ___ Python tracker ___

[issue37322] test_ssl: test_pha_required_nocert() emits a ResourceWarning

STINNER Victor added the comment: I marked bpo-37525 as duplicate of this issue. -- ___ Python tracker ___ ___ Python-bugs-list

[issue37322] test_ssl: test_pha_required_nocert() emits a ResourceWarning

New submission from STINNER Victor : vstinner@apu$ ./python -X tracemalloc=10 -m test --fail-env-changed -v test_ssl -m test_pha_required_nocert == CPython 3.9.0a0 (heads/master-dirty:00f6493084, Jun 17 2019, 21:50:32) [GCC 9.1.1 20190503 (Red Hat 9.1.1-1)] ==