[issue37412] os.getcwdb() doesn't implement PEP 528 (UTF-8) on Windows

STINNER Victor added the comment: > This is fixed now, right? The buildbots seem happy at least. I'll close. Yeah, I forgot to close. I got some issues with backports, but the two commits are now merged into 3.8 as well. -- ___ Python tracker

[issue37412] os.getcwdb() doesn't implement PEP 528 (UTF-8) on Windows

Steve Dower added the comment: This is fixed now, right? The buildbots seem happy at least. I'll close. -- assignee: -> vstinner resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue37412] os.getcwdb() doesn't implement PEP 528 (UTF-8) on Windows

miss-islington added the comment: New changeset e3761ca91cda86462206d60244078f05c636dd13 by Miss Islington (bot) in branch '3.8': bpo-37412: Fix test_os.test_getcwd_long_path() on macOS (GH-14452) https://github.com/python/cpython/commit/e3761ca91cda86462206d60244078f05c636dd13 --

[issue37412] os.getcwdb() doesn't implement PEP 528 (UTF-8) on Windows

Change by miss-islington : -- pull_requests: +14271 pull_request: https://github.com/python/cpython/pull/14454 ___ Python tracker ___

[issue37412] os.getcwdb() doesn't implement PEP 528 (UTF-8) on Windows

STINNER Victor added the comment: New changeset 29f609ed07aa7856741ff8b8b8b050369d0faf81 by Victor Stinner in branch 'master': bpo-37412: Fix test_os.test_getcwd_long_path() on macOS (GH-14452) https://github.com/python/cpython/commit/29f609ed07aa7856741ff8b8b8b050369d0faf81 --

[issue37412] os.getcwdb() doesn't implement PEP 528 (UTF-8) on Windows

STINNER Victor added the comment: Fail on FreeBSD as well: https://buildbot.python.org/all/#/builders/168/builds/1222 == FAIL: test_getcwd_long_path (test.test_os.MiscTests)

[issue37412] os.getcwdb() doesn't implement PEP 528 (UTF-8) on Windows

STINNER Victor added the comment: Oh. Now the test fails on macOS: https://buildbot.python.org/all/#/builders/145/builds/2021 == FAIL: test_getcwd_long_path (test.test_os.MiscTests)

[issue37412] os.getcwdb() doesn't implement PEP 528 (UTF-8) on Windows

Change by STINNER Victor : -- pull_requests: +14268 stage: resolved -> patch review pull_request: https://github.com/python/cpython/pull/14452 ___ Python tracker ___

[issue37412] os.getcwdb() doesn't implement PEP 528 (UTF-8) on Windows

STINNER Victor added the comment: Ok, the regression should now be fixed and test_os now also tests os.getcwd() with a "long path" :-) Thank a lot Eryk Sun for your great advices on reviews! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed

[issue37412] os.getcwdb() doesn't implement PEP 528 (UTF-8) on Windows

STINNER Victor added the comment: New changeset 68c1c398f3534af16309a86ab815b61d2487e6db by Victor Stinner (Miss Islington (bot)) in branch '3.8': bpo-37412: Fix os.getcwd() for long path on Windows (GH-14424) (GH-14451)

[issue37412] os.getcwdb() doesn't implement PEP 528 (UTF-8) on Windows

STINNER Victor added the comment: New changeset 64580da33122a10aef75c76aa3ff87c0ee11e3d7 by Victor Stinner in branch 'master': bpo-37412: pythoninfo: add Windows long paths (GH-14434) https://github.com/python/cpython/commit/64580da33122a10aef75c76aa3ff87c0ee11e3d7 --

[issue37412] os.getcwdb() doesn't implement PEP 528 (UTF-8) on Windows

STINNER Victor added the comment: New changeset ec3e20a2d1edddb0558f9d32e2b367904ccdde88 by Victor Stinner in branch 'master': bpo-37412: Fix os.getcwd() for long path on Windows (GH-14424) https://github.com/python/cpython/commit/ec3e20a2d1edddb0558f9d32e2b367904ccdde88 --

[issue37412] os.getcwdb() doesn't implement PEP 528 (UTF-8) on Windows

Change by miss-islington : -- pull_requests: +14267 pull_request: https://github.com/python/cpython/pull/14451 ___ Python tracker ___

[issue37412] os.getcwdb() doesn't implement PEP 528 (UTF-8) on Windows

Change by STINNER Victor : -- pull_requests: +14251 stage: resolved -> patch review pull_request: https://github.com/python/cpython/pull/14434 ___ Python tracker ___

[issue37412] os.getcwdb() doesn't implement PEP 528 (UTF-8) on Windows

STINNER Victor added the comment: > This update breaks long-path support in Windows. Oops. This is the risk of not testing a feature :-) My PR added very basic tests for getcwd() and getcwdb(). I wrote PR 14424 to not only fix the integer overflow check, but also to add a new unit tests

[issue37412] os.getcwdb() doesn't implement PEP 528 (UTF-8) on Windows

Change by STINNER Victor : -- pull_requests: +14240 pull_request: https://github.com/python/cpython/pull/14424 ___ Python tracker ___

[issue37412] os.getcwdb() doesn't implement PEP 528 (UTF-8) on Windows

Eryk Sun added the comment: This update breaks long-path support in Windows. It includes the following unnecessary check, which is using the wrong comparison operator: if (len >= PY_SSIZE_T_MAX / sizeof(wchar_t)) PyMem_RawMalloc already checks this and returns NULL if size >

[issue37412] os.getcwdb() doesn't implement PEP 528 (UTF-8) on Windows

STINNER Victor added the comment: Ok, it's merged into 3.8. Thanks for the review Steve. One less deprecation warning. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.9 ___ Python tracker

[issue37412] os.getcwdb() doesn't implement PEP 528 (UTF-8) on Windows

miss-islington added the comment: New changeset 63429c839b19c6fe604deddcb12497443ca01a9a by Miss Islington (bot) in branch '3.8': bpo-37412: os.getcwdb() now uses UTF-8 on Windows (GH-14396) https://github.com/python/cpython/commit/63429c839b19c6fe604deddcb12497443ca01a9a -- nosy:

[issue37412] os.getcwdb() doesn't implement PEP 528 (UTF-8) on Windows

Change by miss-islington : -- pull_requests: +14213 pull_request: https://github.com/python/cpython/pull/14399 ___ Python tracker ___

[issue37412] os.getcwdb() doesn't implement PEP 528 (UTF-8) on Windows

STINNER Victor added the comment: New changeset 689830ee6243126798a6c519c05aa11ba73db7cd by Victor Stinner in branch 'master': bpo-37412: os.getcwdb() now uses UTF-8 on Windows (GH-14396) https://github.com/python/cpython/commit/689830ee6243126798a6c519c05aa11ba73db7cd --

[issue37412] os.getcwdb() doesn't implement PEP 528 (UTF-8) on Windows

STINNER Victor added the comment: I retargeted my PR 14396 to Python 3.8. -- versions: +Python 3.8 -Python 3.9 ___ Python tracker ___

[issue37412] os.getcwdb() doesn't implement PEP 528 (UTF-8) on Windows

STINNER Victor added the comment: > I think it can go to 3.8 as well. Thoughts? Oh, 3.8 is not released yet. Well, it's more or less a new feature, or a bugfix, depending on the point of view. I would not be comfortable to change the encoding in 3.8.1, but it should be fine to do the

[issue37412] os.getcwdb() doesn't implement PEP 528 (UTF-8) on Windows

Steve Dower added the comment: Definitely just an oversight. Thanks for fixing this! I think it can go to 3.8 as well. Thoughts? -- ___ Python tracker ___

[issue37412] os.getcwdb() doesn't implement PEP 528 (UTF-8) on Windows

Change by STINNER Victor : -- nosy: +eryksun ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37412] os.getcwdb() doesn't implement PEP 528 (UTF-8) on Windows

Zackery Spytz added the comment: See also bpo-32920. -- nosy: +ZackerySpytz ___ Python tracker ___ ___ Python-bugs-list mailing

[issue37412] os.getcwdb() doesn't implement PEP 528 (UTF-8) on Windows

STINNER Victor added the comment: My PR 14396 modify os.getcwdb() to use UTF-8 and it removes the deprecation warning. -- ___ Python tracker ___

[issue37412] os.getcwdb() doesn't implement PEP 528 (UTF-8) on Windows

Change by STINNER Victor : -- keywords: +patch pull_requests: +14210 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14396 ___ Python tracker ___

[issue37412] os.getcwdb() doesn't implement PEP 528 (UTF-8) on Windows

New submission from STINNER Victor : On Windows, os.getcwdb() is implemented using getcwd() on Windows. This function uses the ANSI code page, whereas PEP 529 "Change Windows filesystem encoding to UTF-8" is supposed to use UTF-8 for all bytes paths and filenames. Moreover, this function