[issue37703] Inconsistent gather with child exception

miss-islington added the comment: New changeset 58f59a962180123a6d29ece512d198b365726b33 by Miss Islington (bot) in branch '3.8': bpo-37703: improve asyncio.gather documentation regarding cancellation (GH-15312)

[issue37703] Inconsistent gather with child exception

miss-islington added the comment: New changeset 46634b7aa82f014cd0039afb7f0ed860605beb9d by Miss Islington (bot) in branch '3.9': bpo-37703: improve asyncio.gather documentation regarding cancellation (GH-15312)

[issue37703] Inconsistent gather with child exception

Change by Andrew Svetlov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue37703] Inconsistent gather with child exception

Change by miss-islington : -- pull_requests: +20704 pull_request: https://github.com/python/cpython/pull/21558 ___ Python tracker ___

[issue37703] Inconsistent gather with child exception

miss-islington added the comment: New changeset d42528a3a2c7d79fd2e6c9f2a02f3ce12d44c8cc by Vinay Sharma in branch 'master': bpo-37703: improve asyncio.gather documentation regarding cancellation (GH-15312) https://github.com/python/cpython/commit/d42528a3a2c7d79fd2e6c9f2a02f3ce12d44c8cc

[issue37703] Inconsistent gather with child exception

Change by miss-islington : -- pull_requests: +20705 pull_request: https://github.com/python/cpython/pull/21559 ___ Python tracker ___

[issue37703] Inconsistent gather with child exception

Change by miss-islington : -- pull_requests: +20703 pull_request: https://github.com/python/cpython/pull/21557 ___ Python tracker ___

[issue37703] Inconsistent gather with child exception

Vinay Sharma added the comment: Hi Andrew, Thanks for replying! I understand that the behavior change is not backward compatible. But the current behavior is a bit ambiguous ad mentioned by Dimitri, therefore I have updated the documentation and opened a Pull request. I would be very glad

[issue37703] Inconsistent gather with child exception

Change by Vinay Sharma : -- pull_requests: +15031 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15312 ___ Python tracker ___

[issue37703] Inconsistent gather with child exception

Andrew Svetlov added the comment: The behavior change is not backward compatible, we cannot apply it. Also, please use github pull requests for proposing a patch: https://devguide.python.org/pullrequest/ -- ___ Python tracker

[issue37703] Inconsistent gather with child exception

Change by Vinay Sharma : Added file: https://bugs.python.org/file48548/gather_cancel_code.patch ___ Python tracker ___ ___ Python-bugs-list

[issue37703] Inconsistent gather with child exception

Vinay Sharma added the comment: Hi Dimitri, You are right, gather.cancel() doesn't work once it has propagated an exception. This happens because after propagating the exception to the caller, gather is marked as done. And cancel doesn't work after a Future object has been marked done. You

[issue37703] Inconsistent gather with child exception

New submission from Dmitrii Ivaniushin : I found some issue that I suppose is a bug. Let us have long running coroutines. We use them in gather, and one of them raises an error. Since then we cannot cancel the gather anymore, thus remaining children are not cancelable and executed until