[issue38150] test_capi: test_c_subclass_of_heap_ctype_with_del_modifying_dunder_class_only_decrefs_once() leaks

Stéphane Wirtel added the comment: Thank you, I close this issue. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue38150] test_capi: test_c_subclass_of_heap_ctype_with_del_modifying_dunder_class_only_decrefs_once() leaks

Stéphane Wirtel added the comment: New changeset 53ff2ca89feb90c1fbf2605321bcef35b457f16f by Stéphane Wirtel in branch '3.8': [3.8] bpo-38150: Fix refleak in the finalizer of a _testcapimodule type (GH-16115) (GH-16118)

[issue38150] test_capi: test_c_subclass_of_heap_ctype_with_del_modifying_dunder_class_only_decrefs_once() leaks

Change by Stéphane Wirtel : -- pull_requests: +15732 pull_request: https://github.com/python/cpython/pull/16118 ___ Python tracker ___

[issue38150] test_capi: test_c_subclass_of_heap_ctype_with_del_modifying_dunder_class_only_decrefs_once() leaks

miss-islington added the comment: New changeset a67ac2f2d9550e5a36d28f9b6eeacf6575dda2d5 by Miss Islington (bot) (Eddie Elizondo) in branch 'master': bpo-38150 Fix refleak in the finalizer of a _testcapimodule type (GH-16115)

[issue38150] test_capi: test_c_subclass_of_heap_ctype_with_del_modifying_dunder_class_only_decrefs_once() leaks

Change by Eddie Elizondo : -- keywords: +patch pull_requests: +15730 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16115 ___ Python tracker ___

[issue38150] test_capi: test_c_subclass_of_heap_ctype_with_del_modifying_dunder_class_only_decrefs_once() leaks

Eddie Elizondo added the comment: > Checking for refleak takes between 2 and 6 hours. Ouch! Makes sense then. We could potentially add a `pre-merge` job that only runs once the merge starts to get executed. Anyways, that's a conversation for another time :-) --- Thanks Stephane I'm very

[issue38150] test_capi: test_c_subclass_of_heap_ctype_with_del_modifying_dunder_class_only_decrefs_once() leaks

Stéphane Wirtel added the comment: Eddie, For the next time, when you change something in the C part, you could run the tests with this command: ./python -m test test_capi -R 3:3 -- nosy: +matrixise ___ Python tracker

[issue38150] test_capi: test_c_subclass_of_heap_ctype_with_del_modifying_dunder_class_only_decrefs_once() leaks

STINNER Victor added the comment: > Also, I thought that the PR build bots already ran refleak tests by default? > Do you know why this it's not integrated to the PR flow? Checking for refleak takes between 2 and 6 hours. We would like to keep our pre-commit CI fast enough (less than 30

[issue38150] test_capi: test_c_subclass_of_heap_ctype_with_del_modifying_dunder_class_only_decrefs_once() leaks

Eddie Elizondo added the comment: On it. Also, I thought that the PR build bots already ran refleak tests by default? Do you know why this it's not integrated to the PR flow? -- nosy: +eelizondo ___ Python tracker

[issue38150] test_capi: test_c_subclass_of_heap_ctype_with_del_modifying_dunder_class_only_decrefs_once() leaks

STINNER Victor added the comment: The new test was added by: commit ff023ed36ea260ab64be5895f1f1f087c798987a Author: Eddie Elizondo Date: Wed Sep 11 05:17:13 2019 -0400 bpo-37879: Suppress subtype_dealloc decref when base type is a C heap type (GH-15323) --

[issue38150] test_capi: test_c_subclass_of_heap_ctype_with_del_modifying_dunder_class_only_decrefs_once() leaks

New submission from STINNER Victor : vstinner@apu$ ./python -m test test_capi -R 3:3 -m test.test_capi.CAPITest.test_c_subclass_of_heap_ctype_with_del_modifying_dunder_class_only_decrefs_once Run tests sequentially 0:00:00 load avg: 0.57 [1/1] test_capi beginning 6 repetitions 123456 ..