[issue38155] Add __all__ to the datetime module

Paul Ganssle added the comment: Closing this as resolved. I don't think we should backport this, as it's more of an enhancement than a bug fix (and since no one has ever complained about it to my knowledge, I don't think there's any big rush to see this released). Thanks Tahia and all the

[issue38155] Add __all__ to the datetime module

Paul Ganssle added the comment: New changeset 96b1c59c71534db3f0f3799cd84e2006923a5098 by Paul Ganssle (t k) in branch 'master': bpo-38155: Add __all__ to datetime module (GH-16203) https://github.com/python/cpython/commit/96b1c59c71534db3f0f3799cd84e2006923a5098 --

[issue38155] Add __all__ to the datetime module

Tahia K added the comment: Thanks @corona10. I've posted a PR with all these bits. -- ___ Python tracker ___ ___ Python-bugs-list

[issue38155] Add __all__ to the datetime module

Change by Tahia K : -- keywords: +patch pull_requests: +15807 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/16203 ___ Python tracker

[issue38155] Add __all__ to the datetime module

Dong-hee Na added the comment: @ta1hia My idea is that both tests should be added. @p-ganssle's test aims to check the attr is allowed or not. And your test aims to check attribute equalities of pure python module and c module. -- ___ Python

[issue38155] Add __all__ to the datetime module

Tahia K added the comment: I'll definitely add that test @Paul. Speaking of, what do you guys think of this test: def test_c_all(self): """Test that __all__ symbols between the c datetime module and the python datetime library are equivalent.""" c_datetime =

[issue38155] Add __all__ to the datetime module

Dong-hee Na added the comment: Good news, When this issue is solved. Can we solve the issue from https://github.com/python/cpython/pull/15633 ? -- nosy: +corona10 ___ Python tracker

[issue38155] Add __all__ to the datetime module

Paul Ganssle added the comment: Actually, how about adding this simpler test into `Lib/test/datetimetester.py`, right above test_name_cleanup (https://github.com/python/cpython/blob/ff2e18286560e981f4e09afb0d2448ea994414d8/Lib/test/datetimetester.py#L65): def test_all(self):

[issue38155] Add __all__ to the datetime module

Paul Ganssle added the comment: Hi Tahia: Go ahead and make a PR, no need to worry about the test. I mainly put in the bit about tests because I was hoping to nerd-snipe someone into figuring out how to do it for me ;) It's not a particularly important test. --

[issue38155] Add __all__ to the datetime module

Tahia K added the comment: Hello! I'm interested in picking up this task. Is it okay if I grab it? The import test bit seems tricky, since (from what I understand) inspecting on an "import *" statement might conflict against other global imports in that test file. I'm a new contributor and

[issue38155] Add __all__ to the datetime module

New submission from Paul Ganssle : Currently the datetime module has no __all__, which means we only advertise what is public and private based on leading underscores. Additionally, because there are two implementations (Python and C), you actually get different things when you do `from