[issue38453] ntpath.realpath() should make absolute path earlier

miss-islington added the comment: New changeset aa909b6b1242b4969b20bb0250ac386f9b4120d7 by Miss Islington (bot) in branch '3.8': bpo-38453: Resolve test directories before chdir to them (GH-16723) https://github.com/python/cpython/commit/aa909b6b1242b4969b20bb0250ac386f9b4120d7 --

[issue38453] ntpath.realpath() should make absolute path earlier

Change by miss-islington : -- pull_requests: +16343 pull_request: https://github.com/python/cpython/pull/16783 ___ Python tracker ___

[issue38453] ntpath.realpath() should make absolute path earlier

Steve Dower added the comment: New changeset d83fc2702951f56a7339aa95d62414ed6e0fb40d by Steve Dower in branch 'master': bpo-38453: Resolve test directories before chdir to them (GH-16723) https://github.com/python/cpython/commit/d83fc2702951f56a7339aa95d62414ed6e0fb40d --

[issue38453] ntpath.realpath() should make absolute path earlier

Steve Dower added the comment: PR 16723 is just for the test fix. The realpath() fix should get tests that chdir (without change_cwd()) into a symlink and then realpath() on a relative path. Today, that should fail to resolve the sections in the CWD, and with the fix it should resolve the

[issue38453] ntpath.realpath() should make absolute path earlier

Change by Steve Dower : -- keywords: +patch pull_requests: +16301 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/16723 ___ Python tracker

[issue38453] ntpath.realpath() should make absolute path earlier

Steve Dower added the comment: Updating change_cwd() in Lib/test/support/__init__.py to call chdir(realpath(path)) also fixes the test issues I was facing, but the realpath() implementation needs fixing. -- ___ Python tracker

[issue38453] ntpath.realpath() should make absolute path earlier

New submission from Steve Dower : Because the abspath() call is deferred until the end of the resolution process, if the current working directory is not already a real path, it will not be fully resolved. By passing it through abspath() at the start of the function, we ensure that the