[issue38722] runpy should use io.open_code() instead of open()

Tal Einat added the comment: Thanks for the clarification Steve! I've backported this to 3.8. -- ___ Python tracker ___ ___

[issue38722] runpy should use io.open_code() instead of open()

miss-islington added the comment: New changeset e37767bee1f7f1940b30768d21bfe2ae68c20a5f by Miss Islington (bot) in branch '3.8': bpo-38722: Runpy use io.open_code() (GH-17234) https://github.com/python/cpython/commit/e37767bee1f7f1940b30768d21bfe2ae68c20a5f --

[issue38722] runpy should use io.open_code() instead of open()

Change by miss-islington : -- pull_requests: +16743 pull_request: https://github.com/python/cpython/pull/17244 ___ Python tracker ___

[issue38722] runpy should use io.open_code() instead of open()

Steve Dower added the comment: > I hadn't realized that we'd made such a declaration WRT opening of code files > in general. It wasn't exactly a hugely publicised declaration :) The relevant quote from PEP 578 is: > All import and execution functionality involving code from a file will be

[issue38722] runpy should use io.open_code() instead of open()

Change by Tal Einat : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue38722] runpy should use io.open_code() instead of open()

Tal Einat added the comment: Thanks for reporting this, Dominic! Thanks for the PR, Jason! -- ___ Python tracker ___ ___

[issue38722] runpy should use io.open_code() instead of open()

Change by miss-islington : -- pull_requests: +16740 pull_request: https://github.com/python/cpython/pull/17241 ___ Python tracker ___

[issue38722] runpy should use io.open_code() instead of open()

Tal Einat added the comment: Thanks Steve! I hadn't realized that we'd made such a declaration WRT opening of code files in general. In that case, this is certainly at least a bug fix, and should be backported. -- type: enhancement -> security versions: +Python 3.8

[issue38722] runpy should use io.open_code() instead of open()

miss-islington added the comment: New changeset e243bae418859106328d9fce71815b7eb2fe by Miss Islington (bot) (jsnklln) in branch 'master': bpo-38722: Runpy use io.open_code() (GH-17234) https://github.com/python/cpython/commit/e243bae418859106328d9fce71815b7eb2fe -- nosy:

[issue38722] runpy should use io.open_code() instead of open()

Steve Dower added the comment: It's a security issue because Python 3.8 says it will open files to be executed with io.open_code() instead of open(). This allows a way to bypass that. That said, this appears to be a fallback case, so I'm not hugely concerned. I haven't quite figured out why

[issue38722] runpy should use io.open_code() instead of open()

Change by Zachary Ware : -- nosy: +steve.dower ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38722] runpy should use io.open_code() instead of open()

Tal Einat added the comment: I don't see why this should be considered a security issue. This should likely have been done when io.open_code() was initially added, but now that 3.8 is out, I don't think backporting this would be wise. -- nosy: +taleinat type: security -> enhancement

[issue38722] runpy should use io.open_code() instead of open()

Change by Tal Einat : -- versions: +Python 3.8 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38722] runpy should use io.open_code() instead of open()

Jason Killen added the comment: Tests working now. PR submitted. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue38722] runpy should use io.open_code() instead of open()

Change by Jason Killen : -- keywords: +patch pull_requests: +16734 stage: -> patch review pull_request: https://github.com/python/cpython/pull/17234 ___ Python tracker ___

[issue38722] runpy should use io.open_code() instead of open()

Jason Killen added the comment: I made the change but the test suite is giving me fits and I don't know why. Running: ./python -m test ... == Tests result: FAILURE == 392 tests OK. 1 test failed: test_tools 26 tests skipped: test_curses test_dbm_gnu test_dbm_ndbm test_devpoll

[issue38722] runpy should use io.open_code() instead of open()

Jason Killen added the comment: I'll plan on tackling this one. I already did pdb. -- nosy: +Jason.Killen ___ Python tracker ___

[issue38722] runpy should use io.open_code() instead of open()

New submission from Dominic Littlewood <11dlittlew...@gmail.com>: Fairly obviously, if you're using something called runpy you're probably trying to run some code. To do this it has to open the script as a file. This is similar to two other issues I'm posting, but they're in different