[issue38857] AsyncMock issue with awaitable return_value/side_effect/wraps

Dima Tisnek added the comment: Thank you for explanation, Jason! I guess that the bug report and the patch were too technical for me to understand  I'm happy with the behaviour in Python 3.8.1 and now I know it's going to stay, I'll just change the tests in our code base. --

[issue38857] AsyncMock issue with awaitable return_value/side_effect/wraps

Jason Fried added the comment: Its not possible to have it both ways. Also it stinks too much of trying to guess. The root of your issue is you want a normal MagicMock not an AsyncMock. Its the automatic behavior of patch to pick AsyncMock vs MagicMock that is the heart of your issue.

[issue38857] AsyncMock issue with awaitable return_value/side_effect/wraps

Change by Karthikeyan Singaravelan : -- nosy: +xtreak ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38857] AsyncMock issue with awaitable return_value/side_effect/wraps

Dima Tisnek added the comment: I think this deserves discussion :) On one hand, it's a welcome change, on another it's kind of a regression. Up until 3.8, our tests used to look like this: --- # code under test async def foo(): return await bar() # test async def helper(value):

[issue38857] AsyncMock issue with awaitable return_value/side_effect/wraps

Change by Lisa Roach : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue38857] AsyncMock issue with awaitable return_value/side_effect/wraps

Andrew Svetlov added the comment: New changeset b2744c1be73f5af0d2dc4b952389efc90c8de94e by Andrew Svetlov (Lisa Roach) in branch '3.8': [3.8] bpo-38857: AsyncMock fix for awaitable values and StopIteration fix [3.8] (GH-17269) (#17304)

[issue38857] AsyncMock issue with awaitable return_value/side_effect/wraps

Change by Lisa Roach : -- pull_requests: +16796 pull_request: https://github.com/python/cpython/pull/17304 ___ Python tracker ___

[issue38857] AsyncMock issue with awaitable return_value/side_effect/wraps

Lisa Roach added the comment: New changeset 046442d02bcc6e848e71e93e47f6cde9e279e993 by Lisa Roach (Jason Fried) in branch 'master': bpo-38857: AsyncMock fix for awaitable values and StopIteration fix [3.8] (GH-17269)

[issue38857] AsyncMock issue with awaitable return_value/side_effect/wraps

Change by Jason Fried : -- keywords: +patch pull_requests: +16761 stage: -> patch review pull_request: https://github.com/python/cpython/pull/17269 ___ Python tracker ___

[issue38857] AsyncMock issue with awaitable return_value/side_effect/wraps

Change by Jason Fried : -- type: -> behavior ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38857] AsyncMock issue with awaitable return_value/side_effect/wraps

New submission from Jason Fried : If you are trying to use AsyncMock to mock a coroutine that returns awaitable objects, AsyncMock awaits on those objects instead of returning them as is. Example: mock = AsyncMock(return_value=asyncio.Future()) v = await mock() # blocks on trying to