[issue39033] zipimport raises NameError: name '_boostrap_external' is not defined

Petr Viktorin added the comment: Thank you, Mihail and Karthikeyan! -- nosy: +petr.viktorin stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue39033] zipimport raises NameError: name '_boostrap_external' is not defined

miss-islington added the comment: New changeset 9955f33cdbf27de270038dfbad37d15b160ecca2 by Miss Islington (bot) (Karthikeyan Singaravelan) in branch '3.8': [3.8] bpo-39033: Fix NameError in zipimport during hash validation (GH-17588) (GH-17642) https://github.com/python/cpython/commit/9955f

[issue39033] zipimport raises NameError: name '_boostrap_external' is not defined

Change by Karthikeyan Singaravelan : -- pull_requests: +17111 pull_request: https://github.com/python/cpython/pull/17642 ___ Python tracker ___

[issue39033] zipimport raises NameError: name '_boostrap_external' is not defined

Nick Coghlan added the comment: New changeset 79f02fee1a542c440fd906fd54154c73fc0f8235 by Nick Coghlan (Xtreak) in branch 'master': bpo-39033: Fix NameError in zipimport during hash validation (GH-17588) https://github.com/python/cpython/commit/79f02fee1a542c440fd906fd54154c73fc0f8235 -

[issue39033] zipimport raises NameError: name '_boostrap_external' is not defined

Change by Karthikeyan Singaravelan : -- keywords: +patch pull_requests: +17060 stage: -> patch review pull_request: https://github.com/python/cpython/pull/17588 ___ Python tracker ___

[issue39033] zipimport raises NameError: name '_boostrap_external' is not defined

Karthikeyan Singaravelan added the comment: Sure Serhiy, I will create one. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue39033] zipimport raises NameError: name '_boostrap_external' is not defined

Serhiy Storchaka added the comment: Wince you has virtually written a patch, do you mind to create a PR Karthikeyan? -- ___ Python tracker ___

[issue39033] zipimport raises NameError: name '_boostrap_external' is not defined

Karthikeyan Singaravelan added the comment: Ma Lin, Running pylint/flake8 could possibly detect it but needs to be manually checked. issue36948 was a similar report I filed in the past using flake8 regarding NameError. pylint - Lib/zipimport.py:611:20: E0602: Undefined variable '_boostrap_e

[issue39033] zipimport raises NameError: name '_boostrap_external' is not defined

Karthikeyan Singaravelan added the comment: Also since the fix involves modifying zipimport.py it would also require running "make regen-importlib && make -s" for changes to ensure the updated regen code is used. -- ___ Python tracker

[issue39033] zipimport raises NameError: name '_boostrap_external' is not defined

Karthikeyan Singaravelan added the comment: A possible test case to trigger this code path based on testUncheckedHashBasedPyc would be as below. check_hash_based_pycs can be patched to be "always" so that the hash is validated using _bootstrap_external._validate_hash_pyc. The difference betw

[issue39033] zipimport raises NameError: name '_boostrap_external' is not defined

Ma Lin added the comment: Is it possible to scan stdlib to find similar bugs? -- nosy: +Ma Lin ___ Python tracker ___ ___ Python-bu

[issue39033] zipimport raises NameError: name '_boostrap_external' is not defined

Change by Karthikeyan Singaravelan : -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe

[issue39033] zipimport raises NameError: name '_boostrap_external' is not defined

Zachary Ware added the comment: Good catch! Would you like to submit a pull request to fix it? Ideally such a PR should also include a test to exercise this code. -- nosy: +twouters, zach.ware ___ Python tracker

[issue39033] zipimport raises NameError: name '_boostrap_external' is not defined

New submission from Mihail Georgiev : I think there's a "t" missing: Lib/zipimport.py 609- 610-try: 611:_boostrap_external._validate_hash_pyc( 612-data, source_hash, fullname, exc_details) 613-except ImportError: 614-