[issue3928] os.mknod missing on Solaris

Jesús Cea Avión added the comment: Patch committed. trunk (2.7): r80574 2.6: r80575 py3k (3.2): r80576 3.1: r80577 -- resolution: -> accepted stage: commit review -> committed/rejected status: open -> closed ___ Python tracker

[issue3928] os.mknod missing on Solaris

Roumen Petrov added the comment: Sorry Jesús, right now I cannot test new patch it but It looks goodand I expect first test to succeed so that second won't be tested as result OCF_XXX to be defined. If there is no spelling error it is fine. Roumen --

[issue3928] os.mknod missing on Solaris

Jesús Cea Avión added the comment: Informal europeans! :-). Hi, Antoine, I am Jesús (sunny Spain!). Deprecation request mailed to python-dev. -- ___ Python tracker ___

[issue3928] os.mknod missing on Solaris

Antoine Pitrou added the comment: > Reading PEP11, I don't see the procedure to propose a platform for > deprecation. Just mailing python-dev? Yes. > Thanks for the review, Pitrou. You can call me Antoine. -- ___ Python tracker

[issue3928] os.mknod missing on Solaris

Jesús Cea Avión added the comment: Pitrou, the code configures correctly in Linux. Reading PEP11, I don't see the procedure to propose a platform for deprecation. Just mailing python-dev? I will delay the patch committing a couple of days, just in case somebody else want to comment. Thanks

[issue3928] os.mknod missing on Solaris

Antoine Pitrou added the comment: Jesus, this looks ok, have you checked the changes work fine under e.g. Linux? I don't think DEC Unix is supported anymore, actually I'm not sure anyone still uses it. -- priority: release blocker -> high ___ Python

[issue3928] os.mknod missing on Solaris

Jesús Cea Avión added the comment: Please, Review. Roumen?. I plan to commit this to 2.7, 2.6, 3.1 and 3.2, if you agree. -- Added file: http://bugs.python.org/file17097/mknod-solaris_3.diff ___ Python tracker ___

[issue3928] os.mknod missing on Solaris

Changes by Jesús Cea Avión : Removed file: http://bugs.python.org/file16536/mknod-solaris_2.diff ___ Python tracker ___ ___ Python-bugs-list ma

[issue3928] os.mknod missing on Solaris

Changes by Benjamin Peterson : -- priority: deferred blocker -> release blocker ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue3928] os.mknod missing on Solaris

Benjamin Peterson added the comment: I think this small change can slip in after beta. -- nosy: +benjamin.peterson priority: release blocker -> deferred blocker ___ Python tracker __

[issue3928] os.mknod missing on Solaris

Roumen Petrov added the comment: >>> "HAVE_DEVICE_MACROS" is defined if "configure" finds "makedev()" macro. >> And what is result on you platform ? >It is defined if I add the new "include". a) Why you touch test case for "AC_MSG_CHECKING(for major, minor, and makedev) AC_TRY_LINK([ #if define

[issue3928] os.mknod missing on Solaris

Jesús Cea Avión added the comment: My browser keeps deleting nosy. Sorry. Roumen, please read. -- nosy: +barry, rpetrov ___ Python tracker ___ _

[issue3928] os.mknod missing on Solaris

Jesús Cea Avión added the comment: Roumen Petrov (rpetrov) wrote: >> >> Jesús Cea Avión added the comment: >> >> I just did the minimal change. I don't know if removing >> "defined(HAVE_MAKEDEV)" is safe. > The python build system is full with minimal changes and result is a > big mess. Did y

[issue3928] os.mknod missing on Solaris

Changes by Barry A. Warsaw : -- priority: deferred blocker -> release blocker ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue3928] os.mknod missing on Solaris

Jesús Cea Avión added the comment: Sorry, Barry. Don't know what happened. Probably write a followup without reloading the page and "undid" previous changes. I keep my issues permanently open in firefox tabs. I will try to be more careful. -- ___

[issue3928] os.mknod missing on Solaris

Barry A. Warsaw added the comment: jcea, why did you make this a release blocker for 2.6.5? -- nosy: +barry priority: release blocker -> deferred blocker ___ Python tracker ___

[issue3928] os.mknod missing on Solaris

Roumen Petrov added the comment: Jesús Cea Avión wrote: > > Jesús Cea Avión added the comment: > > I just did the minimal change. I don't know if removing > "defined(HAVE_MAKEDEV)" is safe. The python build system is full with minimal changes and result is a big mess. Did you found which rev

[issue3928] os.mknod missing on Solaris

Jesús Cea Avión added the comment: I just did the minimal change. I don't know if removing "defined(HAVE_MAKEDEV)" is safe. "HAVE_DEVICE_MACROS" is defined if "configure" finds "makedev()" macro. Clarify your comment about configure.in changes being wrong. -- nosy: -barry, rpetrov p

[issue3928] os.mknod missing on Solaris

Roumen Petrov added the comment: Some questions: - why patch don't update posixmodule.c and remove defined(HAVE_MAKEDEV) ? - how is defined HAVE_DEVICE_MACROS in pyconfig.h About changes in configure.in - I'm not sure that they are correct (more later). -- nosy: +rpetrov __

[issue3928] os.mknod missing on Solaris

Barry A. Warsaw added the comment: This will not block 2.6.5 but is a candidate for 2.6.6. -- nosy: +barry priority: release blocker -> deferred blocker ___ Python tracker ___ __

[issue3928] os.mknod missing on Solaris

Changes by Jesús Cea Avión : -- priority: normal -> release blocker ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue3928] os.mknod missing on Solaris

Changes by Jesús Cea Avión : Removed file: http://bugs.python.org/file16533/mknod-solaris.diff ___ Python tracker ___ ___ Python-bugs-list mail

[issue3928] os.mknod missing on Solaris

Jesús Cea Avión added the comment: Please, do the final review, ready for commiting. I have asked about committing to 2.6 in the python-committers mailing list. -- versions: +Python 2.6, Python 2.7, Python 3.1, Python 3.2 -Python 2.5 Added file: http://bugs.python.org/file16536/mknod-s

[issue3928] os.mknod missing on Solaris

Changes by Jesús Cea Avión : -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/o

[issue3928] os.mknod missing on Solaris

Jesús Cea Avión added the comment: Please, do the final review, ready for commiting. I have asked about committing to 2.6 in the python-committers mailing list. -- stage: patch review -> commit review type: behavior -> feature request ___ Python tra

[issue3928] os.mknod missing on Solaris

Martin v. Löwis added the comment: You do need a NEWS entry. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue3928] os.mknod missing on Solaris

Antoine Pitrou added the comment: Compiles fine under Debian stable. You shouldn't commit to 2.6 until 2.6.5 is released, though. If you want to do so, contact Barry first. -- nosy: +pitrou ___ Python tracker

[issue3928] os.mknod missing on Solaris

Changes by Jesús Cea Avión : -- stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://m

[issue3928] os.mknod missing on Solaris

Jesús Cea Avión added the comment: The patch seems to be trivial. I need review, specially compiling under non-Solaris OS. I plan to commit this patch to 2.6, 2.7, 3.1 and 3.2. Must I update "NEWS"? -- assignee: -> jcea keywords: +needs review, patch nosy: +jcea priority: -> normal

[issue3928] os.mknod missing on Solaris

Changes by John Levon : -- nosy: +movement ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.or

[issue3928] os.mknod missing on Solaris

Martin v. Löwis <[EMAIL PROTECTED]> added the comment: It would be best if you could contribute a patch to fix this. The source of configure is configure.in; you need autoconf to generate configure from it. -- nosy: +loewis ___ Python tracker <[EMAIL

[issue3928] os.mknod missing on Solaris

New submission from Erik Sandberg <[EMAIL PROTECTED]>: When building Python on Solaris, I don't get the os.mknod function. This seems to be a combination of two errors: 1. The definition of posix_mknod() in posixmodule.c is surrounded by: #if defined(HAVE_MKNOD) && defined(HAVE_MAKEDEV) It works