[issue39355] The Python library will not compile with a C++2020 compiler because the code uses the reserved “module” keyword

STINNER Victor added the comment: Follow-up issue: bpo-47165 "[C API] Test that the Python C API is compatible with C++". -- ___ Python tracker ___

[issue39355] The Python library will not compile with a C++2020 compiler because the code uses the reserved “module” keyword

Change by Dong-hee Na : -- nosy: +corona10 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue39355] The Python library will not compile with a C++2020 compiler because the code uses the reserved “module” keyword

Erlend E. Aasland added the comment: > The C++20 "module" keyword is "contextual keyword". It's only a keyword if > the first line if a file contains "module". Great! No changes needed. Thanks for investigating. -- ___ Python tracker

[issue39355] The Python library will not compile with a C++2020 compiler because the code uses the reserved “module” keyword

STINNER Victor added the comment: The C++20 "module" keyword is "contextual keyword". It's only a keyword if the first line if a file contains "module". * https://en.cppreference.com/w/cpp/language/modules#Module_declarations * https://en.cppreference.com/w/cpp/keyword/module It's not the

[issue39355] The Python library will not compile with a C++2020 compiler because the code uses the reserved “module” keyword

STINNER Victor added the comment: I wrote the draft PR GH-32175 to test https://bugs.python.org/issue39355 and GH-31282. Problem: I don't get any compiler warning or error about the "module" C++20 keyword. I tested GCC 11.2.1 and clang 13.0.0 of Fedora 35. --

[issue39355] The Python library will not compile with a C++2020 compiler because the code uses the reserved “module” keyword

Change by STINNER Victor : -- pull_requests: +30252 pull_request: https://github.com/python/cpython/pull/32175 ___ Python tracker ___

[issue39355] The Python library will not compile with a C++2020 compiler because the code uses the reserved “module” keyword

STINNER Victor added the comment: STINNER Victor: > What is the error message? How can the error be reproduced? Keith (aCuria): > Compile with a compiler supporting the C++20 core feature (Modules) > https://en.cppreference.com/w/cpp/compiler_support I built a C++ extension which calls

[issue39355] The Python library will not compile with a C++2020 compiler because the code uses the reserved “module” keyword

STINNER Victor added the comment: When I wrote a PR to use the C header file pythoncapi_compat.h in the datatable C++ project, I got multiple C++ compiler warnings in static inline functions and in some macros: https://github.com/h2oai/datatable/pull/3231#issuecomment-1032864790 * Usage of

[issue39355] The Python library will not compile with a C++2020 compiler because the code uses the reserved “module” keyword

STINNER Victor added the comment: If I build a C++ extension with -std=c++20, I get a compiler error on PyModuleDef_HEAD_INIT: Modules/_testcppext.cpp:419:5: error: either all initializer clauses should be designated or none of them should be 419 | .m_name = "_testcppext", |

[issue39355] The Python library will not compile with a C++2020 compiler because the code uses the reserved “module” keyword

Keith added the comment: Compile with a compiler supporting the C++20 core feature (Modules) https://en.cppreference.com/w/cpp/compiler_support In visual studio, use C/C++ > Language > CPP Language Standard > C++20 or higher On Mon, Mar 7, 2022 at 5:32 PM STINNER Victor wrote: > > STINNER

[issue39355] The Python library will not compile with a C++2020 compiler because the code uses the reserved “module” keyword

STINNER Victor added the comment: > The Python library will not compile with a C++2020 compiler because the code > uses the reserved “module” keyword What is the error message? How can the error be reproduced? -- ___ Python tracker

[issue39355] The Python library will not compile with a C++2020 compiler because the code uses the reserved “module” keyword

Change by Hasan : -- pull_requests: +29442 pull_request: https://github.com/python/cpython/pull/31282 ___ Python tracker ___ ___

[issue39355] The Python library will not compile with a C++2020 compiler because the code uses the reserved “module” keyword

Erlend E. Aasland added the comment: > There will be huge changes for this issue as this keyword has been used in a > lot of places. For external extension modules, it should be sufficient to change only the exposed headers; that is Include/*.h and Include/cpython/*.h. We should also

[issue39355] The Python library will not compile with a C++2020 compiler because the code uses the reserved “module” keyword

Change by Erlend E. Aasland : -- Removed message: https://bugs.python.org/msg413055 ___ Python tracker ___ ___ Python-bugs-list

[issue39355] The Python library will not compile with a C++2020 compiler because the code uses the reserved “module” keyword

Erlend E. Aasland added the comment: > There will be huge changes for this issue as this keyword has been used in a > lot of places. It should be sufficient to change only the exposed headers; that is Include/*.h and Include/cpython/*.h. We should also change the AC tool, since that may be

[issue39355] The Python library will not compile with a C++2020 compiler because the code uses the reserved “module” keyword

Change by Hasan : -- pull_requests: +26787 pull_request: https://github.com/python/cpython/pull/28373 ___ Python tracker ___ ___

[issue39355] The Python library will not compile with a C++2020 compiler because the code uses the reserved “module” keyword

Change by Hasan : -- keywords: +patch pull_requests: +26773 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/28359 ___ Python tracker

[issue39355] The Python library will not compile with a C++2020 compiler because the code uses the reserved “module” keyword

Hasan added the comment: Okey. There will be huge changes for this issue as this keyword has been used in a lot of places. That's why i will try to send pull requests module by module to keep it clean and simple for review. -- ___ Python

[issue39355] The Python library will not compile with a C++2020 compiler because the code uses the reserved “module” keyword

Keith added the comment: the word "module" should be treated as a reserved keyword. Any use of "module" as an argument name should be changed to something else throughout the code base. On Fri, Aug 20, 2021 at 11:28 PM Hasan wrote: > > Hasan added the comment: > > We have tested with

[issue39355] The Python library will not compile with a C++2020 compiler because the code uses the reserved “module” keyword

Hasan added the comment: We have tested with cxx-modules that issue. module is just a specifier for export (only export is a compiler-based keyword in >= C++20) That's why we can use module as argument name and there's no need to rename or delete *module arguments from header files. What do

[issue39355] The Python library will not compile with a C++2020 compiler because the code uses the reserved “module” keyword

STINNER Victor added the comment: Please go ahead. Anyone is free to propose a fix. -- ___ Python tracker ___ ___ Python-bugs-list

[issue39355] The Python library will not compile with a C++2020 compiler because the code uses the reserved “module” keyword

Hasan added the comment: If nobody works, i would like to solve this -- nosy: +AliyevH ___ Python tracker ___ ___ Python-bugs-list

[issue39355] The Python library will not compile with a C++2020 compiler because the code uses the reserved “module” keyword

Change by Petr Viktorin : -- nosy: +petr.viktorin ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue39355] The Python library will not compile with a C++2020 compiler because the code uses the reserved “module” keyword

Serhiy Storchaka added the comment: Qt has different issue. "slots" is not a keyword, and the issue can be avoided by including Python.h before Qt.h or undefining the "slots" macro. It could be a harder issue if "module" would be a field name of a public structure. But names of arguments

[issue39355] The Python library will not compile with a C++2020 compiler because the code uses the reserved “module” keyword

STINNER Victor added the comment: Qt has a similar issue with "slots": bpo-1086854 and bpo-38007. -- ___ Python tracker ___ ___

[issue39355] The Python library will not compile with a C++2020 compiler because the code uses the reserved “module” keyword

Serhiy Storchaka added the comment: Names of arguments can be just removed from function declarations in header files. -- keywords: +easy (C) nosy: +serhiy.storchaka stage: -> needs patch type: -> enhancement versions: -Python 2.7, Python 3.5, Python 3.6

[issue39355] The Python library will not compile with a C++2020 compiler because the code uses the reserved “module” keyword

Change by Karthikeyan Singaravelan : -- nosy: +vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue39355] The Python library will not compile with a C++2020 compiler because the code uses the reserved “module” keyword

New submission from Keith : The Python library will not compile with a C++2020 compiler because the code uses the reserved “module” keyword For example, in warnings.h, we have the following code: #ifndef Py_LIMITED_API PyAPI_FUNC(int) PyErr_WarnExplicitObject( PyObject *category,