[issue39389] gzip metadata fails to reflect compresslevel

Change by Ned Deily : -- resolution: -> fixed stage: backport needed -> resolved status: open -> closed ___ Python tracker ___ ___

[issue39389] gzip metadata fails to reflect compresslevel

Ned Deily added the comment: New changeset 12c45efe828a90a2f2f58a1f95c85d792a0d9c0a by Miss Islington (bot) in branch '3.7': [3.7] bpo-39389: gzip: fix compression level metadata (GH-18077) (GH-18101) https://github.com/python/cpython/commit/12c45efe828a90a2f2f58a1f95c85d792a0d9c0a

[issue39389] gzip metadata fails to reflect compresslevel

Ned Deily added the comment: "either" -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue39389] gzip metadata fails to reflect compresslevel

Ned Deily added the comment: Ping. The 3.7.x backport (PR 18101) for this issue is still open and neither needs to be fixed or closed. -- nosy: +ned.deily resolution: fixed -> stage: resolved -> backport needed status: closed -> open ___ Python

[issue39389] gzip metadata fails to reflect compresslevel

William Chargin added the comment: My pleasure; thanks for the triage and review! -- ___ Python tracker ___ ___ Python-bugs-list

[issue39389] gzip metadata fails to reflect compresslevel

miss-islington added the comment: New changeset ab0d8e356ecd351d55f89519a6a97a1e69c0dfab by Miss Islington (bot) in branch '3.8': bpo-39389: gzip: fix compression level metadata (GH-18077) https://github.com/python/cpython/commit/ab0d8e356ecd351d55f89519a6a97a1e69c0dfab -- nosy:

[issue39389] gzip metadata fails to reflect compresslevel

Serhiy Storchaka added the comment: Thank you for your contribution William! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue39389] gzip metadata fails to reflect compresslevel

Change by miss-islington : -- pull_requests: +17489 pull_request: https://github.com/python/cpython/pull/18100 ___ Python tracker ___

[issue39389] gzip metadata fails to reflect compresslevel

Serhiy Storchaka added the comment: New changeset eab3b3f1c60afecfb4db3c3619109684cb04bd60 by Serhiy Storchaka (William Chargin) in branch 'master': bpo-39389: gzip: fix compression level metadata (GH-18077) https://github.com/python/cpython/commit/eab3b3f1c60afecfb4db3c3619109684cb04bd60

[issue39389] gzip metadata fails to reflect compresslevel

Change by miss-islington : -- pull_requests: +17490 pull_request: https://github.com/python/cpython/pull/18101 ___ Python tracker ___

[issue39389] gzip metadata fails to reflect compresslevel

William Chargin added the comment: PR URL, for reference: -- ___ Python tracker ___

[issue39389] gzip metadata fails to reflect compresslevel

William Chargin added the comment: Sure, PR sent (pull_request17470). -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue39389] gzip metadata fails to reflect compresslevel

Change by William Chargin : -- keywords: +patch pull_requests: +17470 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/18077 ___ Python tracker

[issue39389] gzip metadata fails to reflect compresslevel

Serhiy Storchaka added the comment: Looks reasonable. gzip should write b'\002' for compresslevel == _COMPRESS_LEVEL_BEST, b'\004' for compresslevel == _COMPRESS_LEVEL_FAST, and b'\000' otherwise. Do you mind to create a PR William. -- keywords: +easy nosy: +serhiy.storchaka stage:

[issue39389] gzip metadata fails to reflect compresslevel

William Chargin added the comment: (The commit reference above was meant to be git558f07891170, not a Mercurial reference. Pardon the churn; I'm new here. :-) ) -- ___ Python tracker

[issue39389] gzip metadata fails to reflect compresslevel

Change by William Chargin : -- type: -> behavior ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue39389] gzip metadata fails to reflect compresslevel

New submission from William Chargin : The `gzip` module properly uses the user-specified compression level to control the underlying zlib stream compression level, but always writes metadata that indicates that the maximum compression level was used. Repro: ``` import gzip blob = b"The quick