[issue39493] typing.py has an incorrect definition of closed

Guido van Rossum added the comment: New changeset 194c7aeb6f3d6c2b0015457d22b38253652f4f38 by Miss Islington (bot) in branch '3.7': [3.7] bpo-39493: Fix definition of IO.closed in typing.py (GH-18273) https://github.com/python/cpython/commit/194c7aeb6f3d6c2b0015457d22b38253652f4f38

[issue39493] typing.py has an incorrect definition of closed

Guido van Rossum added the comment: Thanks, Shantanu! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue39493] typing.py has an incorrect definition of closed

miss-islington added the comment: New changeset 58076df0c59677111dc77b72852cb2a313a2ef91 by Miss Islington (bot) in branch '3.8': bpo-39493: Fix definition of IO.closed in typing.py (GH-18265) https://github.com/python/cpython/commit/58076df0c59677111dc77b72852cb2a313a2ef91 --

[issue39493] typing.py has an incorrect definition of closed

Change by miss-islington : -- pull_requests: +17649 pull_request: https://github.com/python/cpython/pull/18274 ___ Python tracker ___

[issue39493] typing.py has an incorrect definition of closed

Change by miss-islington : -- pull_requests: +17648 pull_request: https://github.com/python/cpython/pull/18273 ___ Python tracker ___

[issue39493] typing.py has an incorrect definition of closed

Guido van Rossum added the comment: New changeset 2e6569b6692298fcc9aae0df3eb3181adb2a5099 by Shantanu in branch 'master': bpo-39493: Fix definition of IO.closed in typing.py (#18265) https://github.com/python/cpython/commit/2e6569b6692298fcc9aae0df3eb3181adb2a5099 -- nosy:

[issue39493] typing.py has an incorrect definition of closed

Change by Shantanu : -- keywords: +patch pull_requests: +17642 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18265 ___ Python tracker ___

[issue39493] typing.py has an incorrect definition of closed

New submission from Shantanu : Hello! typing.py has the following definition of `closed`: https://github.com/python/cpython/blob/master/Lib/typing.py#L1834 ``` @abstractmethod def closed(self) -> bool: pass ``` This is inconsistent with the behaviour at runtime: ``` In [17]: