[issue39494] Extra null terminators in keyword arrays in sqlite module

2020-01-29 Thread Berker Peksag
Change by Berker Peksag : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed type: resource usage -> ___ Python tracker ___

[issue39494] Extra null terminators in keyword arrays in sqlite module

2020-01-29 Thread Berker Peksag
Berker Peksag added the comment: New changeset 188bb5b1e868eecf2342195dc45caa332ac3b6c7 by Alex Henrie in branch 'master': bpo-39494: Remove extra null terminators from kwlist vars (GH-18267) https://github.com/python/cpython/commit/188bb5b1e868eecf2342195dc45caa332ac3b6c7 -- nosy:

[issue39494] Extra null terminators in keyword arrays in sqlite module

2020-01-29 Thread Alex Henrie
Change by Alex Henrie : -- keywords: +patch pull_requests: +17644 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18267 ___ Python tracker ___

[issue39494] Extra null terminators in keyword arrays in sqlite module

2020-01-29 Thread Alex Henrie
New submission from Alex Henrie : Modules/_sqlite/cursor.c currently has the following variable declaration: static char *kwlist[] = {"size", NULL, NULL}; The second null terminator is unnecessary and detrimental in that it makes the code harder to read and understand.