[issue39502] test_zipfile fails on AIX due to time.localtime

Michael Felt added the comment: My apologies for the late reply - Here is 3.6.10: Python 3.6.10 (default, Mar 24 2020, 14:12:31) [C] on aix5 Type "help", "copyright", "credits" or "license" for more information. >>> import time >>> time.gmtime(4386268800) time.struct_time(tm_year=2108,

[issue39502] test_zipfile fails on AIX due to time.localtime

STINNER Victor added the comment: Does time.gmtime() accept year after 2038 on 64-bit AIX? Example on Linux: >>> time.gmtime(4386268800) time.struct_time(tm_year=2108, tm_mon=12, tm_mday=30, tm_hour=0, tm_min=0, tm_sec=0, tm_wday=6, tm_yday=365, tm_isdst=0) --

[issue39502] test_zipfile fails on AIX due to time.localtime

STINNER Victor added the comment: New changeset de6f38db4859f7b8fe4da4556f06c52675fff24a by Michael Felt in branch 'master': bpo-39502: Fix 64-bit Python PyTime_localtime() on AIX (GH-18285) https://github.com/python/cpython/commit/de6f38db4859f7b8fe4da4556f06c52675fff24a --

[issue39502] test_zipfile fails on AIX due to time.localtime

David Edelsohn added the comment: I think that Victor means AIX kernel and filesystems are not prepared for Y2038. -- nosy: +David.Edelsohn ___ Python tracker ___

[issue39502] test_zipfile fails on AIX due to time.localtime

Michael Felt added the comment: Not sure I understand what bug I am supposed to report. I apologize if my message https://bugs.python.org/issue39502#msg361116. I assume your comment re: time.localtime(91301504) comes from this bit of the test message (mtime_ns=913015040). Assuming

[issue39502] test_zipfile fails on AIX due to time.localtime

STINNER Victor added the comment: > test_add_file_after_2107 (test.test_zipfile.StoredTestsWithSourceFile) ... > skipped 'Linux VFS/XFS kernel bug detected: mtime_ns=913015040' AIX kernel seems to have a bug. You should report it to AIX. >>> time.localtime(91301504)

[issue39502] test_zipfile fails on AIX due to time.localtime

Michael Felt added the comment: p.s., I manually added #18282 to the test, and the results are the same as without - using 64-bit. Will rebuild the 32-bit and try test again. -- ___ Python tracker

[issue39502] test_zipfile fails on AIX due to time.localtime

Michael Felt added the comment: OK. There have been some comments/questions re: PR18282. a) my PR is missing that PR, seems we just missed each other. b) when using my patch I took a suggestion from issue39460 to test again: root@x065:[/home/python/python3-3.9]./python -m test -v

[issue39502] test_zipfile fails on AIX due to time.localtime

Change by Michael Felt : -- pull_requests: +17660 pull_request: https://github.com/python/cpython/pull/18285 ___ Python tracker ___

[issue39502] test_zipfile fails on AIX due to time.localtime

STINNER Victor added the comment: > Seems to be working on 64-bit, starting 32-bit test (with overflow expected). > Once finished will post a PR. test_time already has tests for timestamps after year 2038, no? -- ___ Python tracker

[issue39502] test_zipfile fails on AIX due to time.localtime

Michael Felt added the comment: Seems to be working on 64-bit, starting 32-bit test (with overflow expected). Once finished will post a PR. root@x065:[/data/prj/python/python3-3.9]./python Python 3.9.0a3+ (heads/bpo-39502-dirty:8d49f7ceb4, Jan 30 2020, 14:47:52) [C] on aix Type "help",

[issue39502] test_zipfile fails on AIX due to time.localtime

miss-islington added the comment: New changeset b841633cc2d7619cf4a7db108d91b14926450a6e by Miss Islington (bot) in branch '3.8': bpo-39502: Skip test_zipfile.test_add_file_after_2107() on AIX (GH-18282) https://github.com/python/cpython/commit/b841633cc2d7619cf4a7db108d91b14926450a6e

[issue39502] test_zipfile fails on AIX due to time.localtime

STINNER Victor added the comment: > bpo-39502: Skip test_zipfile.test_add_file_after_2107() on AIX (GH-18282) Even if localtime() is updated to support larger timestamp, this change is still needed for 32-bit AIX. -- ___ Python tracker

[issue39502] test_zipfile fails on AIX due to time.localtime

EGuesnet added the comment: > I'm not sure of the meaning of your patch. Are you saying that localtime() > supports timestamp after the year 2038 on 64-bit AIX? Did you test that > time.localtime(2**32) actually works as expected? I think it worked as expected before 3.8 on 64 bit. On AIX

[issue39502] test_zipfile fails on AIX due to time.localtime

STINNER Victor added the comment: New changeset c232c9110cfefa0935cbf158e35e91746a8a9361 by Victor Stinner in branch 'master': bpo-39502: Skip test_zipfile.test_add_file_after_2107() on AIX (GH-18282) https://github.com/python/cpython/commit/c232c9110cfefa0935cbf158e35e91746a8a9361

[issue39502] test_zipfile fails on AIX due to time.localtime

Change by miss-islington : -- pull_requests: +17658 pull_request: https://github.com/python/cpython/pull/18283 ___ Python tracker ___

[issue39502] test_zipfile fails on AIX due to time.localtime

Michael Felt added the comment: >From memory I recall the 64-bit version worked with values above the threshold >value that broke the 32-bit library. And the additional test was needed because the AIX library (iirc did not return NULL on error) - so had to test range before the call to get

[issue39502] test_zipfile fails on AIX due to time.localtime

STINNER Victor added the comment: > Probably this broke the 64-bit usage. I'm not sure of the meaning of your patch. Are you saying that localtime() supports timestamp after the year 2038 on 64-bit AIX? Did you test that time.localtime(2**32) actually works as expected? In my timezone,

[issue39502] test_zipfile fails on AIX due to time.localtime

Michael Felt added the comment: Probably this broke the 64-bit usage. diff --git a/Python/pytime.c b/Python/pytime.c index 54ddfc952b..6f13e62490 100644 --- a/Python/pytime.c +++ b/Python/pytime.c @@ -1059,7 +1059,7 @@ _PyTime_localtime(time_t t, struct tm *tm) return 0; #else /*

[issue39502] test_zipfile fails on AIX due to time.localtime

STINNER Victor added the comment: > Tested on Python 3.8.1 on both 32 and 64 bits. Test is now skipped. Good. I created PR 18282 from my patch. -- ___ Python tracker ___

[issue39502] test_zipfile fails on AIX due to time.localtime

Change by STINNER Victor : -- pull_requests: +17657 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18282 ___ Python tracker ___

[issue39502] test_zipfile fails on AIX due to time.localtime

EGuesnet added the comment: Tested on Python 3.8.1 on both 32 and 64 bits. Test is now skipped. test_add_file_after_2107 (test.test_zipfile.StoredTestsWithSourceFile) ... skipped 'time.localtime(4386268800) raises OverflowError' -- ___ Python

[issue39502] test_zipfile fails on AIX due to time.localtime

STINNER Victor added the comment: I suggest to skip the test if time.localtime() fails with OverflowError. Can you please try attached patch on AIX, on the master branch if possible? (Or on Python 3.8 at least.) -- keywords: +patch nosy: +vstinner Added file:

[issue39502] test_zipfile fails on AIX due to time.localtime

Change by Michael Felt : -- nosy: +Michael.Felt ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue39502] test_zipfile fails on AIX due to time.localtime

New submission from EGuesnet : Hi, I have an error during regression tests with Python3.8.1 on AIX 6.1 compiled with GCC 8.3. It occurs only on 64 bit. Test passes on 32 bit. ``` == ERROR: test_add_file_after_2107