[issue39542] Cleanup object.h header

Jim Jewett added the comment: Raymond, did you replace the screenshot with a later one showing that things are fixed now? The timestamp suggests it went up at the same time as your comment, but what I see in the .png file is that the two are identical other than addresses. -- nosy:

[issue39542] Cleanup object.h header

STINNER Victor added the comment: Since the PEP 620 is still a draft, I created PR 21390 to fix the performance issue. As I wrote, I didn't expect any impact on performances since I added _PyType_HasFeature() which access directly the structure member. But I was wrong. This change is not

[issue39542] Cleanup object.h header

Serhiy Storchaka added the comment: I do not know the purpose of this issue. The new code does not look cleaner to me, but maybe it is only for me. But performance regressions should be fixed. We cannot rely on compiler-specific global optimization, which is hard to test and does not work f

[issue39542] Cleanup object.h header

Raymond Hettinger added the comment: Victor, is there any reason PyType_GetFlags() can't be converted to a macro or an inlined function? That seems like a simple and robust fix that won't get in the way of anything else you're doing. We shouldn't disregard macOS timings. It is an important p

[issue39542] Cleanup object.h header

Stefan Krah added the comment: s/PyPy as a bottleneck/the C-API as a bottle neck for PyPy/ -- ___ Python tracker ___ ___ Python-bug

[issue39542] Cleanup object.h header

Stefan Krah added the comment: A brief note for Victor that *nothing* was directed against him. On the contrary, msg372995 was supporting him in case the commit had actually been unreviewed, which it apparently wasn't. Sorry for jumping on the bandwagon there. > PEP 620 for the overall plan.

[issue39542] Cleanup object.h header

Raymond Hettinger added the comment: Serhiy, do you have any insights to offer? -- nosy: +serhiy.storchaka ___ Python tracker ___ _

[issue39542] Cleanup object.h header

Raymond Hettinger added the comment: Here are two timings for math.dist(). They were run with the production macOS builds from python.org: $ python3.8 -m timeit -r 11 -s 'from math import dist' -s 'p=(1.1, 2.2); q=(1.7, 2.3)' 'dist(p, q)' 500 loops, best of 11: 58.4 nsec per loop $ pyt

[issue39542] Cleanup object.h header

STINNER Victor added the comment: Stefan Krah: > Christian Heimes has expressed an interest (quite rudely) in unreviewed > commits elsewhere. I wonder if that applies to everyone regardless of > employer. I don't understand the relationship between this issue, Christian Heimes and making r

[issue39542] Cleanup object.h header

STINNER Victor added the comment: Raymond: > PyTuple_Check() got slower across the board. This is problematic because the > principal use case for PyTuple_Check() is as a guard for various fast paths. Raymond gave more context in this email: https://mail.python.org/archives/list/python-...@py

[issue39542] Cleanup object.h header

Łukasz Langa added the comment: Good catch, Raymond. I'll mark this as a release blocker to ensure I don't miss it. The last beta is scheduled for July 20th. Is this enough time for you? I would very much like to avoid refactors of any sort during the release candidate stage. -- prio

[issue39542] Cleanup object.h header

Stefan Krah added the comment: I have no opinion about this commit (I did not benchmark anything, but I wouldn't be surprised if Victor did). I do have the opinion that unreviewed commits occur quite frequently and nearly every committer has made some (or a lot), including the committers who m

[issue39542] Cleanup object.h header

Change by Christian Heimes : -- nosy: -christian.heimes ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue39542] Cleanup object.h header

Christian Heimes added the comment: Stefan, stop it! I feel offended and harassed by you. Do not ever talk to me in public, private, or even insinuate to reference to my person in any public conversation. -- ___ Python tracker

[issue39542] Cleanup object.h header

Raymond Hettinger added the comment: Let's just focus on getting it fixed before 3.9 goes out. -- ___ Python tracker ___ ___ Python

[issue39542] Cleanup object.h header

Stefan Krah added the comment: Ah, I see that the subject has already been answered in the negative: https://discuss.python.org/t/make-code-review-mandatory/4174 He must have forgotten. -- ___ Python tracker _

[issue39542] Cleanup object.h header

Stefan Krah added the comment: Christian Heimes has expressed an interest (quite rudely) in unreviewed commits elsewhere. I wonder if that applies to everyone regardless of employer. -- nosy: +christian.heimes, skrah ___ Python tracker

[issue39542] Cleanup object.h header

Raymond Hettinger added the comment: PyTuple_Check() got slower across the board. This is problematic because the principal use case for PyTuple_Check() is as a guard for various fast paths. The direct cause of the degradation is that the inlining of PyType_Check() didn't go so well — commit

[issue39542] Cleanup object.h header

Change by STINNER Victor : -- pull_requests: +17758 pull_request: https://github.com/python/cpython/pull/18384 ___ Python tracker ___ __

[issue39542] Cleanup object.h header

STINNER Victor added the comment: New changeset 2844336e6bb0dc932d710be5f4d8c126d0768d03 by Victor Stinner in branch 'master': bpo-39542: Document limited C API changes (GH-18378) https://github.com/python/cpython/commit/2844336e6bb0dc932d710be5f4d8c126d0768d03 -- _

[issue39542] Cleanup object.h header

Change by STINNER Victor : -- pull_requests: +17755 pull_request: https://github.com/python/cpython/pull/18378 ___ Python tracker ___ __

[issue39542] Cleanup object.h header

STINNER Victor added the comment: New changeset 58f4e1a6ee4c6ea82f3f5075d9d9d344ce6b8a56 by Victor Stinner in branch 'master': bpo-39542: Declare _Py_AddToAllObjects() in pycore_object.h (GH-18368) https://github.com/python/cpython/commit/58f4e1a6ee4c6ea82f3f5075d9d9d344ce6b8a56 --

[issue39542] Cleanup object.h header

Change by STINNER Victor : -- pull_requests: +17742 pull_request: https://github.com/python/cpython/pull/18368 ___ Python tracker ___ __

[issue39542] Cleanup object.h header

STINNER Victor added the comment: Ok, object.h looks much better now! I close the issue. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue39542] Cleanup object.h header

STINNER Victor added the comment: New changeset 0e4e735d06967145b49fd00693627f3624991dbc by Victor Stinner in branch 'master': bpo-39542: Define PyTypeObject earlier in object.h (GH-18366) https://github.com/python/cpython/commit/0e4e735d06967145b49fd00693627f3624991dbc --

[issue39542] Cleanup object.h header

Change by STINNER Victor : -- pull_requests: +17741 pull_request: https://github.com/python/cpython/pull/18366 ___ Python tracker ___ __

[issue39542] Cleanup object.h header

STINNER Victor added the comment: New changeset 509dd90f4684e40af3105dd3e754fa4b9c1530c1 by Victor Stinner in branch 'master': bpo-39542: Convert PyType_Check() to static inline function (GH-18364) https://github.com/python/cpython/commit/509dd90f4684e40af3105dd3e754fa4b9c1530c1 --

[issue39542] Cleanup object.h header

Change by STINNER Victor : -- pull_requests: +17739 pull_request: https://github.com/python/cpython/pull/18364 ___ Python tracker ___ __

[issue39542] Cleanup object.h header

STINNER Victor added the comment: New changeset f58bd7c1693fe041f7296a5778d0a11287895648 by Victor Stinner in branch 'master': bpo-39542: Make PyObject_INIT() opaque in limited C API (GH-18363) https://github.com/python/cpython/commit/f58bd7c1693fe041f7296a5778d0a11287895648 -- ___

[issue39542] Cleanup object.h header

Change by STINNER Victor : -- pull_requests: +17738 pull_request: https://github.com/python/cpython/pull/18363 ___ Python tracker ___ __

[issue39542] Cleanup object.h header

STINNER Victor added the comment: New changeset 0fa4f43db086ac3459811cca4ec5201ffbee694a by Victor Stinner in branch 'master': bpo-39542: Exclude trashcan from the limited C API (GH-18362) https://github.com/python/cpython/commit/0fa4f43db086ac3459811cca4ec5201ffbee694a --

[issue39542] Cleanup object.h header

Change by STINNER Victor : -- pull_requests: +17737 pull_request: https://github.com/python/cpython/pull/18362 ___ Python tracker ___ __

[issue39542] Cleanup object.h header

STINNER Victor added the comment: New changeset 40e547dfbb9052ca0c667b242f6825ed1c23c195 by Victor Stinner in branch 'master': bpo-39542: Make _Py_NewReference() opaque in C API (GH-18346) https://github.com/python/cpython/commit/40e547dfbb9052ca0c667b242f6825ed1c23c195 --

[issue39542] Cleanup object.h header

Change by STINNER Victor : -- pull_requests: +17720 pull_request: https://github.com/python/cpython/pull/18346 ___ Python tracker ___ __

[issue39542] Cleanup object.h header

STINNER Victor added the comment: New changeset 49932fec62c616ec88da52642339d83ae719e924 by Victor Stinner in branch 'master': bpo-39542: Simplify _Py_NewReference() (GH-18332) https://github.com/python/cpython/commit/49932fec62c616ec88da52642339d83ae719e924 --

[issue39542] Cleanup object.h header

Change by STINNER Victor : -- pull_requests: +17705 pull_request: https://github.com/python/cpython/pull/18332 ___ Python tracker ___ __

[issue39542] Cleanup object.h header

STINNER Victor added the comment: New changeset 4b524161a0f9d50d782e739a3708434ffd4e94a5 by Victor Stinner in branch 'master': bpo-39542: Move object.h debug functions to internal C API (GH-18331) https://github.com/python/cpython/commit/4b524161a0f9d50d782e739a3708434ffd4e94a5 --

[issue39542] Cleanup object.h header

Change by STINNER Victor : -- keywords: +patch pull_requests: +17704 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18331 ___ Python tracker ___ _

[issue39542] Cleanup object.h header

New submission from STINNER Victor : In bpo-39489, I removed the COUNT_ALLOCS special build. The object.h header can now be cleaned up to simplify the code. -- components: C API messages: 361305 nosy: vstinner priority: normal severity: normal status: open title: Cleanup object.h heade