[issue39953] Let's update ssl error codes

Michael Felt added the comment: Checked with latest version - and working as expected. Sorry for the noise. On 15/04/2020 17:53, SilentGhost wrote: > SilentGhost added the comment: > > Michael, could you try with the latest fix in 584a3cfda4? > > -- > nosy: +SilentGhost > >

[issue39953] Let's update ssl error codes

Michael Felt added the comment: I did update, and saw that there was one more patch applied. I think that fixed the define issues, but there may be a new concern. Ran out of time to document it today. Will post tomorrow. Sent from my iPhone > On 15 Apr 2020, at 17:53, SilentGhost

[issue39953] Let's update ssl error codes

SilentGhost added the comment: Michael, could you try with the latest fix in 584a3cfda4? -- nosy: +SilentGhost ___ Python tracker ___

[issue39953] Let's update ssl error codes

Michael Felt added the comment: And when I use a standard OpenSSL library (on AIX): building '_ssl' extension gcc -pthread -Wno-unused-result -Wsign-compare -g -Og -Wall -std=c99 -Wextra -Wno-unused-result -Wno-unused-parameter -Wno-missing-field-initializers

[issue39953] Let's update ssl error codes

Michael Felt added the comment: Also checking with gcc: get the following messages: Failed to build these modules: _ssl Could not build the ssl module! Python requires an OpenSSL 1.0.2 or 1.1 compatible libssl with X509_VERIFY_PARAM_set1_host(). LibreSSL 2.6.4 and earlier do not provide the

[issue39953] Let's update ssl error codes

Michael Felt added the comment: Do I need to open a new issue? This breaks building _ssl on AIX. building '_ssl' extension xlc_r -O -I./Include/internal -I/opt/aixtools/include -I./Include -I. -I/home/aixtools/python/cpython-master/Include -I/home/aixtools/python/cpython-master -c

[issue39953] Let's update ssl error codes

miss-islington added the comment: New changeset c496e29c2bd0c29327c93174d5a40d2dc5a09402 by Miss Islington (bot) in branch '3.8': closes bpo-40266, closes bpo-39953: Use numeric lib code if compiling against old OpenSSL. (GH-19506)

[issue39953] Let's update ssl error codes

Benjamin Peterson added the comment: New changeset 584a3cfda4d7a65ea0c1ea1ee541378bb7be46ca by Benjamin Peterson in branch 'master': closes bpo-40266, closes bpo-39953: Use numeric lib code if compiling against old OpenSSL. (GH-19506)

[issue39953] Let's update ssl error codes

Change by miss-islington : -- pull_requests: +18859 pull_request: https://github.com/python/cpython/pull/19507 ___ Python tracker ___

[issue39953] Let's update ssl error codes

Benjamin Peterson added the comment: On Mon, Apr 13, 2020, at 17:54, Christian Heimes wrote: > > Christian Heimes added the comment: > > Could you please give me a chance to review PRs for the SSL module? The original PR was open for 23 days before I merged it. I happy to here feedback

[issue39953] Let's update ssl error codes

Christian Heimes added the comment: Could you please give me a chance to review PRs for the SSL module? Python is still failing to compile with OpenSSL 1.0.2 and LibreSSL. The new table contains also wrong values for LibreSSL and OpenSSL 1.0.2. -- resolution: fixed -> stage:

[issue39953] Let's update ssl error codes

Anthony Sottile added the comment: this is still broken even with the latest patch: https://bugs.python.org/issue40266 -- nosy: +Anthony Sottile ___ Python tracker ___

[issue39953] Let's update ssl error codes

miss-islington added the comment: New changeset f35e7d3bb0488a15cbb45ff10f02be558a3777cd by Miss Islington (bot) in branch '3.8': closes bpo-39953: Generate ifdefs around library code definitions. (GH-19490) https://github.com/python/cpython/commit/f35e7d3bb0488a15cbb45ff10f02be558a3777cd

[issue39953] Let's update ssl error codes

Benjamin Peterson added the comment: New changeset 909b87d2bb3d6330d39c48e43f7f50f4d086cc41 by Benjamin Peterson in branch 'master': closes bpo-39953: Generate ifdefs around library code definitions. (GH-19490) https://github.com/python/cpython/commit/909b87d2bb3d6330d39c48e43f7f50f4d086cc41

[issue39953] Let's update ssl error codes

Change by miss-islington : -- pull_requests: +18843 pull_request: https://github.com/python/cpython/pull/19491 ___ Python tracker ___

[issue39953] Let's update ssl error codes

Change by Benjamin Peterson : -- pull_requests: +18842 stage: resolved -> patch review pull_request: https://github.com/python/cpython/pull/19490 ___ Python tracker ___

[issue39953] Let's update ssl error codes

Benjamin Peterson added the comment: Sorry, I thought I had tested with multissl. On Sun, Apr 12, 2020, at 06:22, Christian Heimes wrote: > > Christian Heimes added the comment: > > The PR broke backwards compatibility with OpenSSL 1.0.2 and LibreSSL. > OpenSSL 1.1.x introduced new error

[issue39953] Let's update ssl error codes

Christian Heimes added the comment: The PR broke backwards compatibility with OpenSSL 1.0.2 and LibreSSL. OpenSSL 1.1.x introduced new error codes or reused existing numbers for different errors codes. Although OpenSSL 1.0.2 has reached EOL we should keep keep Python 3.8 and 3.9 compatible

[issue39953] Let's update ssl error codes

hai shi added the comment: Got some compiling error of _ssl extension module in my vm after PR19082 merged: building '_ssl' extension gcc -pthread -Wno-unused-result -Wsign-compare -g -Og -Wall -fPIC -I./Include -I. -I/usr/local/include -I/temp/shihai/cpython/Include -I/temp/shihai/cpython -c

[issue39953] Let's update ssl error codes

miss-islington added the comment: New changeset 2714c907df7cfe97911df6ce90364001270d9a43 by Miss Islington (bot) in branch '3.8': closes bpo-39953: Update OpenSSL error codes table. (GH-19082) https://github.com/python/cpython/commit/2714c907df7cfe97911df6ce90364001270d9a43 --

[issue39953] Let's update ssl error codes

Benjamin Peterson added the comment: New changeset 3e0dd3730b5eff7e9ae6fb921aa77cd26efc9e3a by Benjamin Peterson in branch 'master': closes bpo-39953: Update OpenSSL error codes table. (GH-19082) https://github.com/python/cpython/commit/3e0dd3730b5eff7e9ae6fb921aa77cd26efc9e3a --

[issue39953] Let's update ssl error codes

Change by miss-islington : -- nosy: +miss-islington nosy_count: 7.0 -> 8.0 pull_requests: +18832 pull_request: https://github.com/python/cpython/pull/19478 ___ Python tracker

[issue39953] Let's update ssl error codes

Change by Benjamin Peterson : -- keywords: +patch nosy: +benjamin.peterson nosy_count: 6.0 -> 7.0 pull_requests: +18441 stage: -> patch review pull_request: https://github.com/python/cpython/pull/19082 ___ Python tracker

[issue39953] Let's update ssl error codes

Change by Emmanuel Arias : -- nosy: +eamanu ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue39953] Let's update ssl error codes

Change by Serhiy Storchaka : -- nosy: +alex, christian.heimes, dstufft, janssen ___ Python tracker ___ ___ Python-bugs-list mailing

[issue39953] Let's update ssl error codes

New submission from Dima Tisnek : Let's consider ssl error `291` (https://bugs.python.org/issue39951): It was introduced into openssl 2 years ago: https://github.com/openssl/openssl/commit/358ffa05cd3a088822c7d06256bc87516d918798 The documentation states: