[issue40105] Updating zip comment doesn't truncate the zip file

miss-islington added the comment: New changeset 048f54dc75d51e8a1c5822ab7b2828295192aaa5 by Miss Islington (bot) in branch '3.9': bpo-40105: ZipFile truncate in append mode with shorter comment (GH-19337) https://github.com/python/cpython/commit/048f54dc75d51e8a1c5822ab7b2828295192aaa5

[issue40105] Updating zip comment doesn't truncate the zip file

Change by miss-islington : -- pull_requests: +21468 pull_request: https://github.com/python/cpython/pull/22439 ___ Python tracker ___

[issue40105] Updating zip comment doesn't truncate the zip file

miss-islington added the comment: New changeset e4008404fbc0002c49becc565d42e93eca11dd75 by Miss Islington (bot) in branch '3.8': bpo-40105: ZipFile truncate in append mode with shorter comment (GH-19337) https://github.com/python/cpython/commit/e4008404fbc0002c49becc565d42e93eca11dd75

[issue40105] Updating zip comment doesn't truncate the zip file

Change by miss-islington : -- nosy: +miss-islington nosy_count: 5.0 -> 6.0 pull_requests: +21466 pull_request: https://github.com/python/cpython/pull/22436 ___ Python tracker

[issue40105] Updating zip comment doesn't truncate the zip file

Tal Einat added the comment: Thanks for the report and initial PR, Yudi! Thanks for the second PR, Jan! -- nosy: -miss-islington resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue40105] Updating zip comment doesn't truncate the zip file

Change by miss-islington : -- pull_requests: +21467 pull_request: https://github.com/python/cpython/pull/22437 ___ Python tracker ___

[issue40105] Updating zip comment doesn't truncate the zip file

Change by Tal Einat : -- versions: +Python 3.10, Python 3.9 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40105] Updating zip comment doesn't truncate the zip file

Tal Einat added the comment: New changeset ff9147d93b868f0e13b9fe14e2a76c2879f6787b by Jan Mazur in branch 'master': bpo-40105: ZipFile truncate in append mode with shorter comment (GH-19337) https://github.com/python/cpython/commit/ff9147d93b868f0e13b9fe14e2a76c2879f6787b -- nosy:

[issue40105] Updating zip comment doesn't truncate the zip file

Change by Cheryl Sabella : -- nosy: +serhiy.storchaka, twouters ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue40105] Updating zip comment doesn't truncate the zip file

Change by mzr : -- pull_requests: +18700 pull_request: https://github.com/python/cpython/pull/19337 ___ Python tracker ___ ___

[issue40105] Updating zip comment doesn't truncate the zip file

Change by Yudi : -- keywords: +patch pull_requests: +18698 stage: -> patch review pull_request: https://github.com/python/cpython/pull/19333 ___ Python tracker ___

[issue40105] Updating zip comment doesn't truncate the zip file

Change by mzr : -- nosy: +mzr ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40105] Updating zip comment doesn't truncate the zip file

New submission from Yudi : Updating the zip file comment to a shorter comment should truncate the zip file at the end of the new comment. Instead, the new comment is written to the zip file but the file length stays the same. For example, for a zip file that has the following zip comment: