[issue40158] MSBuild Extensions in CPython NuGet Package has Bad Expression

Steve Dower added the comment: New changeset e6685ad05385f8cb492e8e1c7c07889a94517f55 by Miss Islington (bot) in branch '3.8': bpo-40158: Fix CPython MSBuild Properties in NuGet Package (GH-19343) https://github.com/python/cpython/commit/e6685ad05385f8cb492e8e1c7c07889a94517f55 --

[issue40158] MSBuild Extensions in CPython NuGet Package has Bad Expression

Steve Dower added the comment: New changeset 7f70456b92c9ff0bcc4df2a2cec213ab2a897591 by Miss Islington (bot) in branch '3.7': bpo-40158: Fix CPython MSBuild Properties in NuGet Package (GH-19343) https://github.com/python/cpython/commit/7f70456b92c9ff0bcc4df2a2cec213ab2a897591 --

[issue40158] MSBuild Extensions in CPython NuGet Package has Bad Expression

Change by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue40158] MSBuild Extensions in CPython NuGet Package has Bad Expression

Change by miss-islington : -- nosy: +miss-islington nosy_count: 7.0 -> 8.0 pull_requests: +18712 pull_request: https://github.com/python/cpython/pull/19349 ___ Python tracker

[issue40158] MSBuild Extensions in CPython NuGet Package has Bad Expression

Change by miss-islington : -- pull_requests: +18713 pull_request: https://github.com/python/cpython/pull/19350 ___ Python tracker ___

[issue40158] MSBuild Extensions in CPython NuGet Package has Bad Expression

Steve Dower added the comment: New changeset 6e623ff9d251e0ce86e9b18a01bfd6f067079d7a by Chris Martinez in branch 'master': bpo-40158: Fix CPython MSBuild Properties in NuGet Package (GH-19343) https://github.com/python/cpython/commit/6e623ff9d251e0ce86e9b18a01bfd6f067079d7a --

[issue40158] MSBuild Extensions in CPython NuGet Package has Bad Expression

Change by Chris Martinez : -- keywords: +patch pull_requests: +18707 stage: -> patch review pull_request: https://github.com/python/cpython/pull/19343 ___ Python tracker ___

[issue40158] MSBuild Extensions in CPython NuGet Package has Bad Expression

Steve Dower added the comment: Either of those fixes look good. I normally use IO.Path personally, which might be because it's been around longer, but anything that works on VS 2017 and later should be fine. -- ___ Python tracker

[issue40158] MSBuild Extensions in CPython NuGet Package has Bad Expression

Chris Martinez added the comment: In testing the fix, another issue has arisen. It appears the specified expression will never yield a usable path. Expression 1: $([msbuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), "python_d.exe")) Expression 2:

[issue40158] MSBuild Extensions in CPython NuGet Package has Bad Expression

Steve Dower added the comment: The closing parentheses are needed - a PR would be appreciated for that. The quotes around a variable reference are unnecessary. At a parser level, it just changes it from a variable reference to a string literal with substitutions (unlike most shells, which

[issue40158] MSBuild Extensions in CPython NuGet Package has Bad Expression

New submission from Chris Martinez : CPython provides a NuGet package as a mechanism to support non-installed Python distributions. The package includes MSBuild support to integrate with its build process. The expressions on lines 32 and 33 in the file: