[issue40474] Code coverage report not entirely accurate

Change by Brett Cannon : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue40474] Code coverage report not entirely accurate

Brett Cannon added the comment: New changeset d9c1f1991969e99791de75b2bc935e6445bc5dcd by lrjball in branch 'master': bpo-40474: Updated coverage.yml to better report coverage stats (#19851) https://github.com/python/cpython/commit/d9c1f1991969e99791de75b2bc935e6445bc5dcd -- nosy:

[issue40474] Code coverage report not entirely accurate

Lewis Ball added the comment: I don't have triage permissions so I don't think I can request a review. Although @aeros has requested one. -- ___ Python tracker ___

[issue40474] Code coverage report not entirely accurate

Terry J. Reedy added the comment: Use git to find out who previously edited the file and request reviews from at least a couple. The 2 recommendations on the PR may be based on that, but good to check. -- nosy: +terry.reedy ___ Python tracker

[issue40474] Code coverage report not entirely accurate

Lewis Ball added the comment: I've updated the travis.yml now to fix this issue and global statements are now showing as covered in the coverage report. This means an extra 4k lines show as covered which weren't previously showing. See the report for the PR here

[issue40474] Code coverage report not entirely accurate

Change by Lewis Ball : -- keywords: +patch pull_requests: +19168 stage: -> patch review pull_request: https://github.com/python/cpython/pull/19851 ___ Python tracker ___

[issue40474] Code coverage report not entirely accurate

New submission from Lewis Ball : The current reported code coverage stats on codecov.io miss some global statements of modules imported before coveragepy begins. This is documented in the dev guide, and the suggested fix is here: