[issue40655] Fix 'from x import *' which is bad programming practice from 'Lib/ctypes/test/'.

2020-05-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Pure cosmetic changes to satisfy some aesthetic preferences are not accepted. Every changes has its cost (it consumes the time of core developers to review, has maintenance cost, and disturbs the history of the files) and should be made only if it has a

[issue40655] Fix 'from x import *' which is bad programming practice from 'Lib/ctypes/test/'.

2020-05-17 Thread Hakan
Hakan added the comment: Are code quality enhancement contributions not accepted? Since the 'from x import * `structure is used in the current code, it is not understood where the objects come from. I thought it would be good to fix this. -- ___

[issue40655] Fix 'from x import *' which is bad programming practice from 'Lib/ctypes/test/'.

2020-05-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I do not think there is something wrong with the current code. -- nosy: +serhiy.storchaka ___ Python tracker ___

[issue40655] Fix 'from x import *' which is bad programming practice from 'Lib/ctypes/test/'.

2020-05-17 Thread Hakan
Change by Hakan : -- keywords: +patch pull_requests: +19452 stage: -> patch review pull_request: https://github.com/python/cpython/pull/20147 ___ Python tracker ___

[issue40655] Fix 'from x import *' which is bad programming practice from 'Lib/ctypes/test/'.

2020-05-17 Thread Hakan
Change by Hakan : -- title: Fix a bad programming practice from 'from x import *', 'Lib / ctypes / test /'. -> Fix 'from x import *' which is bad programming practice from 'Lib/ctypes/test/'. ___ Python tracker