[issue4067] ast.fix_missing_locations() breaks if node doesn't have _attributes variable

Armin Ronacher [EMAIL PROTECTED] added the comment: Fixed in changeset 66973 for trunk. ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue4067 ___ ___

[issue4067] ast.fix_missing_locations() breaks if node doesn't have _attributes variable

Changes by Armin Ronacher [EMAIL PROTECTED]: -- resolution: - fixed status: open - closed ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue4067 ___ ___

[issue4067] ast.fix_missing_locations() breaks if node doesn't have _attributes variable

New submission from Marcin Bachry [EMAIL PROTECTED]: ast.fix_missing_locations() fails if any node is missing _attributes instance variable - but it's the case of some fundamental nodes like alias or identifier. When I run simple test: import ast with open(__file__) as fp: tree =

[issue4067] ast.fix_missing_locations() breaks if node doesn't have _attributes variable

Armin Ronacher [EMAIL PROTECTED] added the comment: The root of the problem is that ast.AST doesn't have _fields or _attributes. I think the better solution is to add these attributes to the root class which makes it easier to work with these objects. I attached a diff for asdl_c.py which

[issue4067] ast.fix_missing_locations() breaks if node doesn't have _attributes variable

Amaury Forgeot d'Arc [EMAIL PROTECTED] added the comment: empty_tuple should be DECREF'ed at the end of the function. Otherwise the patch is fine. -- nosy: +amaury.forgeotdarc ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue4067