[issue40874] Update to libmpdec-2.5.0

Stefan Krah added the comment: More than that, I had *promised* Matthias privately to release a new libmpdec for the sqrt-max-prec feature a couple of months ago. I request that further packaging issues will be dealt with primarily by Matthias and myself. --

[issue40874] Update to libmpdec-2.5.0

Change by Christian Heimes : -- nosy: -christian.heimes ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40874] Update to libmpdec-2.5.0

Stefan Krah added the comment: > The standalone libmpdec had to be updated, and was updated according to the Debian-friendly way requested by Matthias himself. Not updated, of course the sqrt-max-prec *had never been* in the standalone libmpdec, it is new in 2.5.0. --

[issue40874] Update to libmpdec-2.5.0

Stefan Krah added the comment: As noted in the first message of this thread, the sqrt-max-prec feature (requested by Mark and Tim) was already in 3.9 long before the beta freeze. I'm not sure why this is not clear from the original message. That fix is safe for Python, but not for the

[issue40874] Update to libmpdec-2.5.0

Stefan Krah added the comment: Thanks for taking a look, Antoine. IIRC, the version pinning already accommodates Debian: #if !defined(MPD_VERSION_HEX) || MPD_VERSION_HEX < 0x0205 #error "libmpdec version >= 2.5.0 required" #endif In the first libmpdec versions, I had a stricter

[issue40874] Update to libmpdec-2.5.0

Antoine Pitrou added the comment: Thanks for the clarification. I agree this does not seem to be a very big deal, if slightly annoying for the packager who will have to deal with it. -- ___ Python tracker

[issue40874] Update to libmpdec-2.5.0

Stefan Krah added the comment: > In any case, I would have had a hard time giving a competent opinion on this > issue. Essentially it's a really simple Linux packaging issue for the external libmpdec. To have the exact same behavior for the external libmpdec as for the included libmpdec,

[issue40874] Update to libmpdec-2.5.0

Antoine Pitrou added the comment: Hmm, I'm only taking notice of this comment thread now. (sorry, but due to spam filtering issues I only receive bpo e-mail notifications intermittently... and that's despite having tried two separate e-mail providers which otherwise give me no problems :-/)

[issue40874] Update to libmpdec-2.5.0

Stefan Krah added the comment: How witty! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed type: -> behavior ___ Python tracker ___

[issue40874] Update to libmpdec-2.5.0

Christian Heimes added the comment: Are you saying that you are not follow advises and guidelines of the developer guide? -- ___ Python tracker ___

[issue40874] Update to libmpdec-2.5.0

Stefan Krah added the comment: > Finally, while Raymond and Antoine are welcome to voice their opinions on the > matter, your change is landing in 3.9.0b4 which I'm about to announce. So we > won't be reverting it. In the future let's make sure we stick to the release > calendar to avoid

[issue40874] Update to libmpdec-2.5.0

Stefan Krah added the comment: Finally, about the Debian issue, of course you could also link 3.8 against the static lib. -- ___ Python tracker ___

[issue40874] Update to libmpdec-2.5.0

Stefan Krah added the comment: Łukasz, which one is nicer? > reverting this patch passes all the tests, what's the motivation and why were > there no code reviews for this? or: > Yeah, I already felt a bit guilty about adding you -- it could be a compiler > bug or an actual overflow. My

[issue40874] Update to libmpdec-2.5.0

Łukasz Langa added the comment: > And a release manager who has no libmpdec expertise or authority took the > side of the "bug" reporter without much thought. What is this elusive "authority" you keep bringing up? > Note that I do not go straight into accusing people, especially in uncertain

[issue40874] Update to libmpdec-2.5.0

Stefan Krah added the comment: > both 3.8 and 3.9 have to be available on the systems for the transition > period. If sonames can be incremented for libraries even if they are ABI compatible, how about using up as many as you need for the Debian package? Next time when I release mpdecimal,

[issue40874] Update to libmpdec-2.5.0

Stefan Krah added the comment: > In the mean time may I request that you follow our protocol for code review. Ah, who reviews libffi? It is just updated. Not counting the thousands of other cases people commit unreviewed, like in changing the C-API. And no, Christian, that isn't

[issue40874] Update to libmpdec-2.5.0

Stefan Krah added the comment: Matthias, to tell the truth, I was never sure about the soname. I read this: https://www.debian.org/doc/debian-policy/ch-sharedlibs.html """ The SONAME and binary package name need not, and indeed normally should not, change if new interfaces are added but

[issue40874] Update to libmpdec-2.5.0

Stefan Krah added the comment: Since this issue has been brought to the attention of the CoC committee. Here is how *I* report issues: https://bugs.python.org/issue40223#msg372578 https://bugs.python.org/issue40223#msg372637 https://github.com/google/sanitizers/issues/1257 Note

[issue40874] Update to libmpdec-2.5.0

Matthias Klose added the comment: I'm +-0 on if that should be integrated into 3.9. Only a few people are using --with-system-libmpdec. However the way that mpdecimal 2.4 and 2.5 are released, they are not usable for Debian or Ubuntu for the transition from 3.8 to 3.9. For that, both 3.8

[issue40874] Update to libmpdec-2.5.0

Stefan Krah added the comment: > backwards incompatible changes. It is not a backwards incompatible change. Slamming a 3.9 into a nightly build has never been supported. -- ___ Python tracker

[issue40874] Update to libmpdec-2.5.0

Stefan Krah added the comment: Raymond, Mark, Antoine: If you think this should be reverted, I'll revert it. -- nosy: +mark.dickinson, pitrou, rhettinger ___ Python tracker

[issue40874] Update to libmpdec-2.5.0

Stefan Krah added the comment: I was accused of breaking the release, which is false. It is outside of a release manager's authority to claim that an *experimental* and *nightly* build that uses a flag in an unintended manner needs counts as breakage. --

[issue40874] Update to libmpdec-2.5.0

Christian Heimes added the comment: > I was the one being attacked in this issue, while releasing a zero fault library whose release procedures resemble those found in avionics software. I have reported this incident to the steering council and Code of Conduct working group. I let them

[issue40874] Update to libmpdec-2.5.0

Change by Stefan Krah : -- components: +Extension Modules resolution: -> fixed stage: patch review -> resolved status: open -> closed type: -> behavior ___ Python tracker

[issue40874] Update to libmpdec-2.5.0

Stefan Krah added the comment: Christian, you are also completely ignoring the original attack of Anthony, so you are biased and there is no point continuing. -- ___ Python tracker

[issue40874] Update to libmpdec-2.5.0

Stefan Krah added the comment: I was the one being attacked in this issue, while releasing a zero fault library whose release procedures resemble those found in avionics software. -- ___ Python tracker

[issue40874] Update to libmpdec-2.5.0

Christian Heimes added the comment: As soon as a Python release enters beta phase, all dependencies are locked. Since Python 3.9.0-b1 supported --with-system-libmpdec with libmpdec-2.4.2, all future releases of 3.9.0 until EOL of 3.9 branch have to support 2.4.2. Since 3.9.0-b3 does not

[issue40874] Update to libmpdec-2.5.0

Stefan Krah added the comment: It is instructive that ArchLinux quietly and professionally packaged mpdecimal-2.5.0 hours after the release: https://www.archlinux.org/packages/?sort==mpdecimal== This is in stark contrast with Python-dev, where a maintainer of an *experimental* *nightly*

[issue40874] Update to libmpdec-2.5.0

Stefan Krah added the comment: Since this is an ongoing problem: When I submitted the decNumber patches to Cowlishaw, he asked me if I would be interested in maintaining decNumber. I declined at the time due to time constraints. Had I accepted, I'd control 2/3 of the decimal market now, the

[issue40874] Update to libmpdec-2.5.0

Stefan Krah added the comment: > You'll have to let the readers of this thread judge that for themselves. Ask Cowlishaw or the mpfr developers to read this thread. As for politeness, msg372581 was entirely polite and directly answered by an inappropriate and petulant msg372584. This no way

[issue40874] Update to libmpdec-2.5.0

Łukasz Langa added the comment: > That was incredibly inappropriate. You'll have to let the readers of this thread judge that for themselves. You're right that you added me to nosy. I missed it as I've been busy with other things at the time. You let *3 hours* pass between opening this issue

[issue40874] Update to libmpdec-2.5.0

Stefan Krah added the comment: Major correction: Victor *did* ask for a news entry, but otherwise I would not have added one. -- ___ Python tracker ___

[issue40874] Update to libmpdec-2.5.0

Stefan Krah added the comment: > The bot did ask you to add a news entry. And I deliberately did not, out of politeness. Two release managers were added and they did not ask. > Other core developer go through great length to keep backwards compatibility > for older or less commonly used

[issue40874] Update to libmpdec-2.5.0

Christian Heimes added the comment: > Also note that people did not react at all to the fact that > coroutine storage was not thread safe across several releases. That's whataboutism. > No one asked for News entry. The bot did ask you to add a news entry. According to

[issue40874] Update to libmpdec-2.5.0

Stefan Krah added the comment: Also note that people did not react at all to the fact that coroutine storage was not thread safe across several releases. No one asked for News entry. But "breaking" a fringe distro seems to be a major disaster. --

[issue40874] Update to libmpdec-2.5.0

Stefan Krah added the comment: > I have opened bpo-41161 to address the issue. Thanks, that is a more considerate approach, I'll add the note! -- ___ Python tracker ___

[issue40874] Update to libmpdec-2.5.0

Stefan Krah added the comment: > This has nothing to do with your excellent fault rate (lack of any issues). I sounds like that though for random people who read this issue and think that Łukasz is the grand release manager who puts a person in his place. That was incredibly inappropriate.

[issue40874] Update to libmpdec-2.5.0

Christian Heimes added the comment: > > unreviewed and under-documented commit. > > libmpdec has been one of the few zero fault areas of Python. > Please stop spreading FUD. This has nothing to do with your excellent fault rate (lack of any issues). The commit had no Misc/NEWS.d blurb and

[issue40874] Update to libmpdec-2.5.0

Stefan Krah added the comment: > unreviewed and under-documented commit. libmpdec has been one of the few zero fault areas of Python. Please stop spreading FUD. -- ___ Python tracker

[issue40874] Update to libmpdec-2.5.0

Stefan Krah added the comment: > Anthony noted a new failure related to your unreviewed and under-documented > commit. He claimed a failure in Ubuntu (in a manner that I took as petulant), which isn't the case. It is a failure in a custom Ubuntu distro that uses --with-system-libmpdec in an

[issue40874] Update to libmpdec-2.5.0

Anthony Sottile added the comment: Łukasz: what would you recommend for downstream packagers? I have essentially two options (assuming this isn't reverted in cpython master which I believe makes the most sense since cpython still works fine with older libmpdec): - revert this individual

[issue40874] Update to libmpdec-2.5.0

Łukasz Langa added the comment: Stefan brought libmpdec-2.5.0 to 3.9 shortly before Beta 2. Due to us being busy with the importlib fiasco, this went under our radar. It shouldn't have. It's a large chunk of refactored code merged without review after the beta freeze. Betas aren't for

[issue40874] Update to libmpdec-2.5.0

Stefan Krah added the comment: --with-system-libmpdec is a **long term** tool for distributions. Pinning the version number ensures that they use the correct version. -- ___ Python tracker

[issue40874] Update to libmpdec-2.5.0

Stefan Krah added the comment: This is no release blocker. Version 2.5.0 has been in 3.9 for a long time, and people should use the correct version. -- priority: release blocker -> normal ___ Python tracker

[issue40874] Update to libmpdec-2.5.0

Change by Christian Heimes : -- nosy: +christian.heimes priority: normal -> release blocker ___ Python tracker ___ ___

[issue40874] Update to libmpdec-2.5.0

Stefan Krah added the comment: You are talking to the author of libmpdec *and* the _decimal module. Perhaps this problem has occurred to me, too: $ diff -ur mpdecimal-2.5.0/libmpdec cpython-commit/Modules/_decimal/libmpdec/ Only in mpdecimal-2.5.0/libmpdec: .objs Only in

[issue40874] Update to libmpdec-2.5.0

Anthony Sottile added the comment: > Otherwise, why use the system libmpdec at all and not the version shipped with Python? the packages are faithful reproductions of upstream packages, deviating from those introduces surprises for downstreams > If I install into a venv, I also don't use

[issue40874] Update to libmpdec-2.5.0

Stefan Krah added the comment: If Python is packaged with **system** libmpdec, you can only use the official Ubuntu Python/libmpdec version combination. Which are packaged by Matthias Klose, who is on the CC list here. Otherwise, why use the system libmpdec at all and not the version

[issue40874] Update to libmpdec-2.5.0

Anthony Sottile added the comment: I package pythons for ubuntu: https://github.com/deadsnakes/python3.9-nightly/actions/runs/151286686 https://github.com/deadsnakes/python3.10-nightly/actions/runs/151287821 -- ___ Python tracker

[issue40874] Update to libmpdec-2.5.0

Stefan Krah added the comment: Or is this CoC bait again? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40874] Update to libmpdec-2.5.0

Stefan Krah added the comment: Please name a buildbot that does not pass. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue40874] Update to libmpdec-2.5.0

Anthony Sottile added the comment: reverting this patch passes all the tests, what's the motivation and why were there no code reviews for this? -- ___ Python tracker ___

[issue40874] Update to libmpdec-2.5.0

Stefan Krah added the comment: Ubuntu is my main system, and it does not break the build. If you use --with-system-libmpdec, you need to keep in sync with the external libmpdec. -- ___ Python tracker

[issue40874] Update to libmpdec-2.5.0

Anthony Sottile added the comment: especially this late in the beta period for 3.9 -- it would be unfortunate for 3.10 but it's an explicit break of feature freeze for 3.9 -- ___ Python tracker

[issue40874] Update to libmpdec-2.5.0

Anthony Sottile added the comment: this breaks builds for ubuntu, I'd suggest reverting this (especially because it appears to build fine without this patch) 2020-06-29T08:52:56.8303672Z x86_64-linux-gnu-gcc -pthread -fPIC -Wdate-time -D_FORTIFY_SOURCE=2 -Wno-unused-result -Wsign-compare

[issue40874] Update to libmpdec-2.5.0

Stefan Krah added the comment: A very brief guide for all users of --with-system-libmpdec: Python 3.7 and Python 3.8 both require the release with this sha256sum: 83c628b90f009470981cf084c5418329c88b19835d8af3691b930afccb7d79c7 mpdecimal-2.4.2.tar.gz Python 3.9 requires the release

[issue40874] Update to libmpdec-2.5.0

Stefan Krah added the comment: New changeset 119de0eba839993cf6a909dba5d60202ad5566d6 by Miss Islington (bot) in branch '3.9': bpo-40874 Update the required libmpdec version for the decimal module (GH-21202) https://github.com/python/cpython/commit/119de0eba839993cf6a909dba5d60202ad5566d6

[issue40874] Update to libmpdec-2.5.0

Change by miss-islington : -- pull_requests: +20357 pull_request: https://github.com/python/cpython/pull/21203 ___ Python tracker ___

[issue40874] Update to libmpdec-2.5.0

Stefan Krah added the comment: New changeset 8bea91b5e9ea07ca93958e131b436024f0b1b1cf by Stefan Krah in branch 'master': bpo-40874 Update the required libmpdec version for the decimal module (GH-21202) https://github.com/python/cpython/commit/8bea91b5e9ea07ca93958e131b436024f0b1b1cf

[issue40874] Update to libmpdec-2.5.0

Change by Stefan Krah : -- pull_requests: +20355 pull_request: https://github.com/python/cpython/pull/21202 ___ Python tracker ___

[issue40874] Update to libmpdec-2.5.0

Stefan Krah added the comment: New changeset 83bff88b4b16fb30491faa9263bbd6f3df4bab56 by Miss Islington (bot) in branch '3.9': bpo-40874: Update to libmpdec-2.5.0 (GH-20652) https://github.com/python/cpython/commit/83bff88b4b16fb30491faa9263bbd6f3df4bab56 --

[issue40874] Update to libmpdec-2.5.0

Change by Stefan Krah : -- versions: +Python 3.10 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40874] Update to libmpdec-2.5.0

Stefan Krah added the comment: New changeset 087d612efebe7c64e5f079b07e0454111859830e by Stefan Krah in branch 'master': bpo-40874: Update to libmpdec-2.5.0 (GH-20652) https://github.com/python/cpython/commit/087d612efebe7c64e5f079b07e0454111859830e --

[issue40874] Update to libmpdec-2.5.0

Change by miss-islington : -- nosy: +miss-islington nosy_count: 3.0 -> 4.0 pull_requests: +19874 pull_request: https://github.com/python/cpython/pull/20654 ___ Python tracker

[issue40874] Update to libmpdec-2.5.0

Change by Stefan Krah : -- keywords: +patch pull_requests: +19872 stage: -> patch review pull_request: https://github.com/python/cpython/pull/20652 ___ Python tracker ___

[issue40874] Update to libmpdec-2.5.0

New submission from Stefan Krah : Synopsis: There are no relevant new features for _decimal, but it would be too much work/error prone to have divergent code in libmpdec-2.5.0 and Python 3.9, especially for the Linux distributions. I'll release libmpdec-2.5.0/libmpdec++-2.5.0 in a month or