[issue40932] subprocess docs should warn of shlex use on Windows

Ammar Askar added the comment: Thank you Steve and Zachary for reviewing, this warning is in the docs now. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue40932] subprocess docs should warn of shlex use on Windows

miss-islington added the comment: New changeset f9a8386e44a695551a1e54e709969e90e9b96bc4 by Ammar Askar in branch 'master': bpo-40932: Note security caveat of shlex.quote on Windows (GH-21502) https://github.com/python/cpython/commit/f9a8386e44a695551a1e54e709969e90e9b96bc4 --

[issue40932] subprocess docs should warn of shlex use on Windows

Ammar Askar added the comment: Hmm, it'd be hard to enumerate them all. The module does say, "...simple syntaxes resembling that of the Unix shell" but that's it. Distinguishing at the OS level for shlex does seem a bit weird given the existence of WSL and non-compliant shells on Linux like

[issue40932] subprocess docs should warn of shlex use on Windows

Steve Dower added the comment: I wonder whether we should be more specific about the shells that shlex works for? Since WSL makes *sh (Bash, Dash, Sh, etc.) easily available on Windows, and I believe PowerShell on Linux keeps its own quoting rules. --

[issue40932] subprocess docs should warn of shlex use on Windows

Change by Ammar Askar : -- keywords: +patch nosy: +ammar2 nosy_count: 7.0 -> 8.0 pull_requests: +20643 stage: -> patch review pull_request: https://github.com/python/cpython/pull/21502 ___ Python tracker

[issue40932] subprocess docs should warn of shlex use on Windows

Change by Chris Jerdonek : -- nosy: +chris.jerdonek ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40932] subprocess docs should warn of shlex use on Windows

Change by Ned Deily : -- components: +Windows nosy: +paul.moore, steve.dower, tim.golden, zach.ware title: subprocess docs don't qualify the instruction to use shlex.quote by OS -> subprocess docs should warn of shlex use on Windows versions: +Python 3.10, Python 3.9