[issue40943] PEP 353: Drop support for PyArg_ParseTuple() "#" formats when PY_SSIZE_T_CLEAN is not defined

STINNER Victor added the comment: commit 4ebf4a6bfad4afcbab3baf9c0159c7767e2a64c0 Author: Inada Naoki Date: Fri May 7 11:56:48 2021 +0900 bpo-40943: Fix skipitem() didn't raise SystemError (GH-25937) `convertitem()` raises `SystemError` when '#' is used without

[issue40943] PEP 353: Drop support for PyArg_ParseTuple() "#" formats when PY_SSIZE_T_CLEAN is not defined

Change by Inada Naoki : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue40943] PEP 353: Drop support for PyArg_ParseTuple() "#" formats when PY_SSIZE_T_CLEAN is not defined

miss-islington added the comment: New changeset 569ca81adf0be92be8752f6cc6492117f9ef3c0b by Miss Islington (bot) in branch '3.10': bpo-40943: Fix skipitem() didn't raise SystemError (GH-25937) https://github.com/python/cpython/commit/569ca81adf0be92be8752f6cc6492117f9ef3c0b --

[issue40943] PEP 353: Drop support for PyArg_ParseTuple() "#" formats when PY_SSIZE_T_CLEAN is not defined

Change by miss-islington : -- nosy: +miss-islington nosy_count: 3.0 -> 4.0 pull_requests: +24620 pull_request: https://github.com/python/cpython/pull/25961 ___ Python tracker

[issue40943] PEP 353: Drop support for PyArg_ParseTuple() "#" formats when PY_SSIZE_T_CLEAN is not defined

Change by Inada Naoki : -- pull_requests: +24605 stage: resolved -> patch review pull_request: https://github.com/python/cpython/pull/25937 ___ Python tracker ___

[issue40943] PEP 353: Drop support for PyArg_ParseTuple() "#" formats when PY_SSIZE_T_CLEAN is not defined

Serhiy Storchaka added the comment: Sorry, I was confused by Victor's long msg371219. -- ___ Python tracker ___ ___

[issue40943] PEP 353: Drop support for PyArg_ParseTuple() "#" formats when PY_SSIZE_T_CLEAN is not defined

Inada Naoki added the comment: >Why PR 20784 has been merged? Was not the plan to emit a deprecation warning >first? We had been emitted DeprecationWarning since Python 3.8. See GH-12473. GH-20784 changed the DeprecationWarning to SystemError. --

[issue40943] PEP 353: Drop support for PyArg_ParseTuple() "#" formats when PY_SSIZE_T_CLEAN is not defined

Serhiy Storchaka added the comment: Why PR 20784 has been merged? Was not the plan to emit a deprecation warning first? -- ___ Python tracker ___

[issue40943] PEP 353: Drop support for PyArg_ParseTuple() "#" formats when PY_SSIZE_T_CLEAN is not defined

Inada Naoki added the comment: There is a still warning, not error. https://github.com/python/cpython/blob/985ac016373403e8ad41f8d563c4355ffa8d49ff/Python/getargs.c#L2535-L2542 -- resolution: fixed -> status: closed -> open ___ Python tracker

[issue40943] PEP 353: Drop support for PyArg_ParseTuple() "#" formats when PY_SSIZE_T_CLEAN is not defined

STINNER Victor added the comment: libxml2 is hit by this issue: * https://gitlab.gnome.org/GNOME/libxml2/-/issues/203 * https://gitlab.gnome.org/GNOME/libxml2/-/merge_requests/87 (my proposed fix) -- ___ Python tracker

[issue40943] PEP 353: Drop support for PyArg_ParseTuple() "#" formats when PY_SSIZE_T_CLEAN is not defined

Change by STINNER Victor : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue40943] PEP 353: Drop support for PyArg_ParseTuple() "#" formats when PY_SSIZE_T_CLEAN is not defined

STINNER Victor added the comment: New changeset 37bb2895561d3e63a631f10875567b4e33b30c07 by Victor Stinner in branch 'master': bpo-40943: PY_SSIZE_T_CLEAN required for '#' formats (GH-20784) https://github.com/python/cpython/commit/37bb2895561d3e63a631f10875567b4e33b30c07 --

[issue40943] PEP 353: Drop support for PyArg_ParseTuple() "#" formats when PY_SSIZE_T_CLEAN is not defined

Change by STINNER Victor : -- title: PEP 353: Drop support for PyArg_ParseTuple() format when PY_SSIZE_T_CLEAN is not defined -> PEP 353: Drop support for PyArg_ParseTuple() "#" formats when PY_SSIZE_T_CLEAN is not defined ___ Python tracker