[issue41052] Opt out serialization/deserialization for heap type

STINNER Victor added the comment: Thanks for the fix Serhiy! -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue41052] Opt out serialization/deserialization for heap type

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue41052] Opt out serialization/deserialization for heap type

Serhiy Storchaka added the comment: New changeset 0aaecb30483e98fc29c1f4253967d05da092f0c5 by Serhiy Storchaka in branch '3.9': [3.9] bpo-41052: Fix pickling heap types implemented in C with protocols 0 and 1 (GH-22870). (GH-22963)

[issue41052] Opt out serialization/deserialization for heap type

Change by Serhiy Storchaka : -- pull_requests: +21880 pull_request: https://github.com/python/cpython/pull/22963 ___ Python tracker ___

[issue41052] Opt out serialization/deserialization for heap type

Serhiy Storchaka added the comment: New changeset 8cd1dbae32d9303caac3a473d3332f17bc98c921 by Serhiy Storchaka in branch 'master': bpo-41052: Fix pickling heap types implemented in C with protocols 0 and 1 (GH-22870)

[issue41052] Opt out serialization/deserialization for heap type

Serhiy Storchaka added the comment: I came to the same conclusion after trying to fix it. But we cannot just do it now. We have to fix bugs in Python 3.9 and support protocols 0 and 1 for some deprecation period. Also protocols 0 and 1 are used in some third-party implementations for other

[issue41052] Opt out serialization/deserialization for heap type

Change by Serhiy Storchaka : -- pull_requests: +21812 pull_request: https://github.com/python/cpython/pull/22870 ___ Python tracker ___

[issue41052] Opt out serialization/deserialization for heap type

Antoine Pitrou added the comment: At some point, pickle protocols 0 and 1 should be deprecated and slated for removal. Protocol 2 is 17 years ago already, and protocol 3 has become the default in Python 3. That would probably be a better use of contributor time than trying to make heap

[issue41052] Opt out serialization/deserialization for heap type

Dong-hee Na added the comment: > It would be better to fix copyreg._reduce_ex() instead of disabling pickling > for these types one by one I agree :) -- ___ Python tracker

[issue41052] Opt out serialization/deserialization for heap type

Serhiy Storchaka added the comment: There are other heap types implemented in C in the stdlib and third-party libraries for which pickling with protocols 0 and 1 works incorrectly. It would be better to fix copyreg._reduce_ex() instead of disabling pickling for these types one by one.

[issue41052] Opt out serialization/deserialization for heap type

Change by Dong-hee Na : -- pull_requests: +21250 pull_request: https://github.com/python/cpython/pull/22189 ___ Python tracker ___

[issue41052] Opt out serialization/deserialization for heap type

Dong-hee Na added the comment: New changeset 814b07bf814a804f60b897d18f1dbb5578b2c7fd by Dong-hee Na in branch '3.9': [3.9] bpo-41052: Opt out serialization/deserialization for _random.Random (GH-21002). (GH-21030)

[issue41052] Opt out serialization/deserialization for heap type

Change by Dong-hee Na : -- pull_requests: +20201 pull_request: https://github.com/python/cpython/pull/21030 ___ Python tracker ___

[issue41052] Opt out serialization/deserialization for heap type

Dong-hee Na added the comment: New changeset 6989af0bc7ea1e9a1acea16794e6f723d7b44110 by Dong-hee Na in branch 'master': bpo-41052: Opt out serialization/deserialization for _random.Random (GH-21002) https://github.com/python/cpython/commit/6989af0bc7ea1e9a1acea16794e6f723d7b44110

[issue41052] Opt out serialization/deserialization for heap type

Change by Dong-hee Na : -- keywords: +patch pull_requests: +20177 stage: -> patch review pull_request: https://github.com/python/cpython/pull/21002 ___ Python tracker ___

[issue41052] Opt out serialization/deserialization for heap type

Change by Dong-hee Na : -- nosy: +shihai1991 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue41052] Opt out serialization/deserialization for heap type

New submission from Dong-hee Na : See https://bugs.python.org/issue40077#msg371813 We noticed that heap type has different behavior about serialization/deserialization. Basically it can occur the regression issues. Two things needed. 1. opt out serialization/deserialization for converted