[issue41244] Change to use str.join() instead of += when concatenating string

2020-07-08 Thread Yury Selivanov
Yury Selivanov added the comment: > Changes in bpo-41242 were rejected not because the new code is worse, but > because it is not obviously and significantly better that the existing code. > Here status quo wins for the same reasons. This rule saves us from endless > rewriting the code and

[issue41244] Change to use str.join() instead of += when concatenating string

2020-07-08 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Changes in bpo-41242 were rejected not because the new code is worse, but because it is not obviously and significantly better that the existing code. Here status quo wins for the same reasons. This rule saves us from endless rewriting the code and allows

[issue41244] Change to use str.join() instead of += when concatenating string

2020-07-08 Thread Zachary Ware
Zachary Ware added the comment: That is not performance-critical code, and in that case it is clearer to use `+=` than str.join. Closing the issue; Andrew or Yury can of course reopen it if they disagree with my assessment. -- nosy: +zach.ware resolution: -> wont fix stage: patch

[issue41244] Change to use str.join() instead of += when concatenating string

2020-07-08 Thread Wansoo Kim
Change by Wansoo Kim : -- keywords: +patch pull_requests: +20546 stage: -> patch review pull_request: https://github.com/python/cpython/pull/21398 ___ Python tracker ___

[issue41244] Change to use str.join() instead of += when concatenating string

2020-07-08 Thread Wansoo Kim
New submission from Wansoo Kim : https://bugs.python.org/issue41242 According to BPO-41242, it is better to use join than += when concatenating multiple strings. https://github.com/python/cpython/blob/b26a0db8ea2de3a8a8e4b40e69fc8642c7d7cb68/Lib/asyncio/queues.py#L82 However, the link above