[issue41354] filecmp.cmp documentation does not match actual code

Change by Roundup Robot : -- nosy: +python-dev nosy_count: 4.0 -> 5.0 pull_requests: +28340 pull_request: https://github.com/python/cpython/pull/30120 ___ Python tracker ___ __

[issue41354] filecmp.cmp documentation does not match actual code

Łukasz Langa added the comment: Closed in favor of BPO-42958. Thanks for your report, Christof! -- nosy: +lukasz.langa resolution: -> out of date stage: patch review -> resolved status: open -> closed superseder: -> filecmp.cmp(shallow=True) isn't actually shallow when only mtime dif

[issue41354] filecmp.cmp documentation does not match actual code

Christof Hanke added the comment: Andrei, See https://bugs.python.org/issue42958 Someone else stumbled over this topic. Maybe you can merge these two requests? Otherwise, I'm fine with a new arg. Christof -- ___ Python tracker

[issue41354] filecmp.cmp documentation does not match actual code

Andrei Kulakov added the comment: Christof: I've left one comment on the PR. Generally your reasoning (on why unexpected deep cmp is not ideal), makes sense to me. However, this is a backwards incompatible change that will probably affect a large number of a lot of scripts that quietly run

[issue41354] filecmp.cmp documentation does not match actual code

Christof Hanke added the comment: I understand that you are reluctant to change existing code. But for me as a sysadmin, the current behavior doesn't make sense for two reasons: * st.st_size is part of _sig. why would you do a deep compare if the two files have a different length ? * comp

[issue41354] filecmp.cmp documentation does not match actual code

Scott added the comment: I suggest changing the documentation rather than the code. The mix up is in the wording. Documentation below "If shallow is true, files with identical os.stat() signatures are taken to be equal. Otherwise, the contents of the files are compared." The "Otherwise" ap

[issue41354] filecmp.cmp documentation does not match actual code

Change by Christof Hanke : -- keywords: +patch pull_requests: +20722 stage: -> patch review pull_request: https://github.com/python/cpython/pull/21580 ___ Python tracker ___ _

[issue41354] filecmp.cmp documentation does not match actual code

New submission from Christof Hanke : help(filecmp.cmp) says: """ cmp(f1, f2, shallow=True) Compare two files. Arguments: f1 -- First file name f2 -- Second file name shallow -- Just check stat signature (do not read the files). defaults to