[issue41402] email: ContentManager.set_content calls nonexistent method encode() on bytes

Łukasz Langa added the comment: Thanks, Johannes! ✨  ✨ -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue41402] email: ContentManager.set_content calls nonexistent method encode() on bytes

miss-islington added the comment: New changeset a3185da26f8c818907c297d92c533deaa96f40fd by Miss Islington (bot) in branch '3.10': bpo-41402: Fix email ContentManager calling .encode() on bytes (GH-21631) https://github.com/python/cpython/commit/a3185da26f8c818907c297d92c533deaa96f40fd

[issue41402] email: ContentManager.set_content calls nonexistent method encode() on bytes

Łukasz Langa added the comment: New changeset 395f4c7fbfb89b8724a4abf84410b5e1e374932d by Miss Islington (bot) in branch '3.9': bpo-41402: Fix email ContentManager calling .encode() on bytes (GH-21631) (GH-27687)

[issue41402] email: ContentManager.set_content calls nonexistent method encode() on bytes

Change by miss-islington : -- pull_requests: +26173 pull_request: https://github.com/python/cpython/pull/27687 ___ Python tracker ___

[issue41402] email: ContentManager.set_content calls nonexistent method encode() on bytes

Change by miss-islington : -- nosy: +miss-islington nosy_count: 5.0 -> 6.0 pull_requests: +26172 pull_request: https://github.com/python/cpython/pull/27686 ___ Python tracker

[issue41402] email: ContentManager.set_content calls nonexistent method encode() on bytes

Łukasz Langa added the comment: New changeset b33186bc43bb5aaf652dd9d093a08fdde796d499 by Johannes Reiff in branch 'main': bpo-41402: Fix email ContentManager calling .encode() on bytes (GH-21631) https://github.com/python/cpython/commit/b33186bc43bb5aaf652dd9d093a08fdde796d499 --

[issue41402] email: ContentManager.set_content calls nonexistent method encode() on bytes

Change by Łukasz Langa : -- versions: +Python 3.11 -Python 3.8 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue41402] email: ContentManager.set_content calls nonexistent method encode() on bytes

Johannes Reiff added the comment: Could someone comment on the way forward? Or ideally just merge my PR (it was approved on GitHub)? I am still very much interested in this bug getting fixed. -- ___ Python tracker

[issue41402] email: ContentManager.set_content calls nonexistent method encode() on bytes

Johannes Reiff added the comment: It has been almost a month since the last update, so pinging as suggested in the Developer's Guide. Do I need to do something before the PR can be merged? -- ___ Python tracker

[issue41402] email: ContentManager.set_content calls nonexistent method encode() on bytes

Johannes Reiff added the comment: Thanks! Is there anything I need to do regarding the Python 3.8 and 3.9 backports? -- ___ Python tracker ___

[issue41402] email: ContentManager.set_content calls nonexistent method encode() on bytes

R. David Murray added the comment: The fix looks good to me. Don't know how I made that mistake, and obviously I didn't write a test for it... -- ___ Python tracker ___

[issue41402] email: ContentManager.set_content calls nonexistent method encode() on bytes

Change by Roundup Robot : -- keywords: +patch nosy: +python-dev nosy_count: 3.0 -> 4.0 pull_requests: +20772 stage: -> patch review pull_request: https://github.com/python/cpython/pull/21631 ___ Python tracker

[issue41402] email: ContentManager.set_content calls nonexistent method encode() on bytes

New submission from Johannes Reiff : If assigning binary content to an EmailMessage via set_content(), the function email.contentmanager.set_bytes_content() is called. This function fails when choosing the 7bit transfer encoding because of a call to data.decode('ascii'). --