[issue41562] StreamReaderProtocol inheritance

2020-11-28 Thread Andrew Svetlov
Andrew Svetlov added the comment: Fixing a non-broken thing is not a world-class idea, I think. -- ___ Python tracker ___ ___

[issue41562] StreamReaderProtocol inheritance

2020-11-28 Thread Dan Pascu
Dan Pascu added the comment: While it may not be affected at a functional level (at least not in a way I can see right now), it is confusing when reading that code. Isn't clarity and avoiding confusion a desired trait for core python code? What about all these recommendations from the Zen

[issue41562] StreamReaderProtocol inheritance

2020-11-26 Thread Andrew Svetlov
Andrew Svetlov added the comment: You are right, but the existing inheritance is also correct (while a little redundant). Sorry, I don't think we should do anything: don't fix if not broken. -- resolution: -> not a bug stage: -> resolved status: open -> closed

[issue41562] StreamReaderProtocol inheritance

2020-08-16 Thread Dan Pascu
New submission from Dan Pascu : I noticed that StreamReaderProtocol is defined like this: class StreamReaderProtocol(FlowControlMixin, protocols.Protocol): ... but FlowControlMixin already inherits protocols.Protocol: class FlowControlMixin(protocols.Protocol): ... It seems