[issue41620] Python Unittest does not return results object when the test is skipped

Łukasz Langa added the comment: Thanks for the report and initial patch, Iman! ✨ 🍰 ✨ And thanks Serhiy for pushing this across the finish line. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue41620] Python Unittest does not return results object when the test is skipped

miss-islington added the comment: New changeset 243b8de0b15061704581974c0a27db1232a43b93 by Miss Islington (bot) in branch '3.10': bpo-41620: TestCase.run() now always return a TestResult instance (GH-28030) https://github.com/python/cpython/commit/243b8de0b15061704581974c0a27db1232a43b93 -

[issue41620] Python Unittest does not return results object when the test is skipped

Łukasz Langa added the comment: New changeset 0c5e0aa73f6f70d16d21ad9e1eb2d0fe3a334f0a by Miss Islington (bot) in branch '3.9': bpo-41620: TestCase.run() now always return a TestResult instance (GH-28030) (GH-28065) https://github.com/python/cpython/commit/0c5e0aa73f6f70d16d21ad9e1eb2d0fe3a33

[issue41620] Python Unittest does not return results object when the test is skipped

Change by miss-islington : -- nosy: +miss-islington nosy_count: 8.0 -> 9.0 pull_requests: +26508 pull_request: https://github.com/python/cpython/pull/28064 ___ Python tracker _

[issue41620] Python Unittest does not return results object when the test is skipped

Łukasz Langa added the comment: New changeset 7e246a3a7b43762480ee4fe0cfb859e8e997a8c8 by Serhiy Storchaka in branch 'main': bpo-41620: TestCase.run() now always return a TestResult instance (GH-28030) https://github.com/python/cpython/commit/7e246a3a7b43762480ee4fe0cfb859e8e997a8c8

[issue41620] Python Unittest does not return results object when the test is skipped

Change by miss-islington : -- pull_requests: +26509 pull_request: https://github.com/python/cpython/pull/28065 ___ Python tracker ___ __

[issue41620] Python Unittest does not return results object when the test is skipped

Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +26475 stage: test needed -> patch review pull_request: https://github.com/python/cpython/pull/28030 ___ Python tracker

[issue41620] Python Unittest does not return results object when the test is skipped

Serhiy Storchaka added the comment: It is a bug because there is a difference between the following cases: @skip("skipped") def test1(self): ... @other_decorator @skip("skipped") def test2(self): ... def test2(self): self.skipTest("skipped")

[issue41620] Python Unittest does not return results object when the test is skipped

Iman Tabrizian added the comment: I'll add a documentation and unit test and update the PR. -- ___ Python tracker ___ ___ Python-bu

[issue41620] Python Unittest does not return results object when the test is skipped

Irit Katriel added the comment: I agree with Iman that this looks like a bug because the code updates the result object with skip info but then doesn't return it. The patch needs a unit test covering this, as well as probably a doc update. -- ___

[issue41620] Python Unittest does not return results object when the test is skipped

Change by Irit Katriel : -- Removed message: https://bugs.python.org/msg393489 ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue41620] Python Unittest does not return results object when the test is skipped

Change by Irit Katriel : -- Removed message: https://bugs.python.org/msg384971 ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue41620] Python Unittest does not return results object when the test is skipped

Irit Katriel added the comment: Actually I take it back - this looks like a bug. The code updates the result object with skip info but then doesn't return it. But the patch needs a unit test covering this. -- keywords: +easy ___ Python tracker

[issue41620] Python Unittest does not return results object when the test is skipped

Change by Irit Katriel : -- versions: +Python 3.11 -Python 3.9 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue41620] Python Unittest does not return results object when the test is skipped

Irit Katriel added the comment: The justification on the PR is: "The problem is that when I'm trying to collect test results if one of the tests is being skipped the error below pops up because test_result object is None. AttributeError: 'NoneType' object has no attribute 'testsRun'" which

[issue41620] Python Unittest does not return results object when the test is skipped

Terry J. Reedy added the comment: You should justify the proposed change here on the issue, and see if the doc says anything about the issue either way. -- nosy: +ezio.melotti, michael.foord, rbcollins, terry.reedy ___ Python tracker

[issue41620] Python Unittest does not return results object when the test is skipped

New submission from Iman Tabrizian : Result object is null when a test case is skipeed. -- messages: 375820 nosy: Tabrizian priority: normal pull_requests: 21054 severity: normal status: open title: Python Unittest does not return results object when the test is skipped versions: Python